From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C3585459C6;
	Wed, 18 Sep 2024 11:14:08 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4C8A1427E9;
	Wed, 18 Sep 2024 11:14:08 +0200 (CEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62])
 by mails.dpdk.org (Postfix) with ESMTP id 744074025C
 for <dev@dpdk.org>; Wed, 18 Sep 2024 11:14:06 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=JuPn9vZsKNk0gW/GkkwDBWJs2ipLXwOZj7l3Gnv92Du6lkYjjtmRHumAj4URqiThcBE4UT13xheKtzK+zINnlSMUY9rVgMdYxvY9MGw0hHjOBY0NYwfx6O37WzM69RhOI24YKd+eRNKZ2NjFA5Stx4MqWkzHHFCqfGTuTVGCjNaSR9z4JRCHtOMPFtiOW7Kwom9diN5umTgZoOlEaGk02Qlt1K48kq5arVUYp4ZK81fLVIB6BoGg9pyguqS3Dzb7S1n6GUf+YRw5IYaAg2TESVBek22RKanR+ErMsJBujS9Dl6w9b8begpBTRp5aUZJPIbiS6XQhVeNJcYFc+dXVaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=;
 b=sgUxz6iSVPnaHZ4ZVXwO1f87ldsYVK0lzdWCKfHER9iYu0Mg0GBfCNEnCIltfw4tAxFEobdybhLFdWQ79Jiw+GjHW8JAkRb9J/KIACURPYO8zMl+PoUNH8B1G89RKeNg3WdeC+8H80TmCW2emp7sH4fLioHywVk08XKxhi1JAuCHIImv1dNUuxgd//idxsFPls3oY6bRcwOHPo1WzCJHyL2tTH2FKVc2I9GUWJDaio2TBQfIlDFXNdKDrbczu3Y29s0dnCntdR1frdwa4Z2DCh6S1x0n5DIbgLrU2rHhu0rEpga7jCNP5yWNgAhnjon8VOOhhfGzZsuUKb2KSbEivw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;
 dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; 
 dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FORcAcTImC3VO+jULR5YD9MPGU81/5BIeguEUjIfy6I=;
 b=n1AQ9Bidf4EzIehAJKja7HoDWqFKYZMiPda7RysqDBGZNtuI/ZES7lIbJoThBlbmlCTbpDet6NDvPlcZmMGUTz/3Iug3Q4aY5cLQIp5CsAnnKzhOP82xNEcOOq6ekzmbqkxoxYRQd/Qv+Y0NCH7YTkRYW5T06XlePbK5kS60+mtK52Xxfcsztn8MwaUCfwg8lzsN6GP9Cn74leGMj0i55axRcpNHC8PDkoZLhAFFnzZH8oZfqB5AGxTOy2s2TNAJ2EyriGyqAq7zuM3pe8X70Y61jKo03qrfHl2bdvDNOR+w1I2wL7Ocvroons9v7/TBercJCAyE+VN9+etbP3VFWw==
Received: from DUZPR01CA0186.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:4b3::15) by AS8PR07MB7141.eurprd07.prod.outlook.com
 (2603:10a6:20b:25a::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.24; Wed, 18 Sep
 2024 09:14:04 +0000
Received: from DB1PEPF000509E2.eurprd03.prod.outlook.com
 (2603:10a6:10:4b3:cafe::63) by DUZPR01CA0186.outlook.office365.com
 (2603:10a6:10:4b3::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.25 via Frontend
 Transport; Wed, 18 Sep 2024 09:14:04 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74)
 smtp.mailfrom=ericsson.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=ericsson.com;
Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates
 192.176.1.74 as permitted sender)
 receiver=protection.outlook.com; 
 client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C
Received: from oa.msg.ericsson.com (192.176.1.74) by
 DB1PEPF000509E2.mail.protection.outlook.com (10.167.242.52) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.7918.13 via Frontend Transport; Wed, 18 Sep 2024 09:14:03 +0000
Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by
 smtp-central.internal.ericsson.com (100.87.178.65) with Microsoft SMTP Server
 id 15.2.1544.11; Wed, 18 Sep 2024 11:14:03 +0200
Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])
 by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id
 44756380070; Wed, 18 Sep 2024 11:14:03 +0200 (CEST)
From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
To: <dev@dpdk.org>
CC: <hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>, "Stephen
 Hemminger" <stephen@networkplumber.org>, Tyler Retzlaff
 <roretzla@linux.microsoft.com>, =?UTF-8?q?Morten=20Br=C3=B8rup?=
 <mb@smartsharesystems.com>, Jack Bond-Preston
 <jack.bond-preston@foss.arm.com>, David Marchand <david.marchand@redhat.com>, 
 Chengwen Feng <fengchengwen@huawei.com>, =?UTF-8?q?Mattias=20R=C3=B6nnblom?=
 <mattias.ronnblom@ericsson.com>
Subject: [PATCH v9 5/6] eal: add unit tests for atomic bit access functions
Date: Wed, 18 Sep 2024 11:04:44 +0200
Message-ID: <20240918090445.725283-6-mattias.ronnblom@ericsson.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20240918090445.725283-1-mattias.ronnblom@ericsson.com>
References: <20240917104811.723863-2-mattias.ronnblom@ericsson.com>
 <20240918090445.725283-1-mattias.ronnblom@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DB1PEPF000509E2:EE_|AS8PR07MB7141:EE_
X-MS-Office365-Filtering-Correlation-Id: 478bdaf5-1cb5-4781-f4c7-08dcd7c23dc3
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
 ARA:13230040|1800799024|36860700013|376014|82310400026; 
X-Microsoft-Antispam-Message-Info: =?utf-8?B?eVNmS2R1L0RMYnU0RXdFZTFTbzM2RXNna0M5eXM1WElwL1psOUZDSHlOTHdD?=
 =?utf-8?B?WkVTOXBRR1dQQzNBOExCVWpja3Z3M0FPaTY1VkRTYzV3aGVXbHhGOEsyb1Nn?=
 =?utf-8?B?djhOSUNZZEVZajZBZmVCMW50Umh4dmJEalVJVld1eGExblRYL1B2YndDOHR4?=
 =?utf-8?B?MUlkM0ZUL1dVcmFMWGVIVEs1OEk3UWMxRE5MaURpamo2V3BSSnArSW1TaGMy?=
 =?utf-8?B?ck1WN3pQbndqdzlMSHVYWFhFazFPVWVnZTdZUlFyVm81dlZaRXNuaGZLajcz?=
 =?utf-8?B?M3hDUlgveTJLbmlzZ0tpNndWK3BLMzd4ekE3OTlLQjNPYzlZemxYMkIyMGFp?=
 =?utf-8?B?QmNocUNBOEJOM3lxZmc3eENPM0syRlR2bXhQK2s0T1VxanFnWE5ycy85emtH?=
 =?utf-8?B?c3cybVQ3a3YvcHVudkVKUE5GQTFKOTVwdEhpTnRPb0N2Y1VSeFRrR1dvNWI1?=
 =?utf-8?B?ZzJ5VzFuTUVBVDAyNVRxWGx0bzdYZXBUQmlpMytMVitxdFFpd2lLZzdqQTV0?=
 =?utf-8?B?NktQOFd4TzRhRjkrSU9hNlJKV3BPczBvWUppTDJ2UUZkYzFJVHAwbzZpU1lY?=
 =?utf-8?B?aXQ4Sk1seVl3L210ZXlzcytNT3NTMHdEVTQwTDcxQzJqakVGc2xaMzQ3MU5V?=
 =?utf-8?B?bzdUV1R0L21QVTVaVjhOWVp5bEdISGcyVEFFMkhjb0RsMkNQMEczbGNudWRF?=
 =?utf-8?B?a2FlWlNSY3YvOWMzNGJ1MDBMM21Ka3RmaDhDd2FrdDV6N0JZSmExNEFMM3E2?=
 =?utf-8?B?WnR6MDdDSkl4RFg2TjZhaVlCOE0za3dob1RON1g5dnRzODkxc1BwLzgzVzJk?=
 =?utf-8?B?cmkrRi9McjhaNjEyM0VDOGFyZlRaR2JiOGxpZjFVL3MrRjM1TUZhRFhTS3VN?=
 =?utf-8?B?L0dNa1EyUk9KK0hXak83cEc3ejhYLytaSlBIWTUwbnliemMyMGJQLy9UYy9l?=
 =?utf-8?B?UlFDc3pVTi9ta2wrV2daR0tJczROOGk5VHFMVzlQaHdWM3lxY0R1TThwMkZh?=
 =?utf-8?B?RmFGQUs3VVkzcmlGY04wQjU1ZEZKSStBbWRDb2JtME1BYlo3SW9RT0JaTTRM?=
 =?utf-8?B?NkVZT2d3ajV3R3FmVUw3M1lWSmxOdGVaT1cwMXNKNFJLRXBtdDNLTXYzd0k3?=
 =?utf-8?B?UCtheUd5K29jYU5EMHhCYmxTb1RRdWExWmV4a0xPb295ZXV4ZmlRZWhieFVh?=
 =?utf-8?B?dEZ5RkwyeW0rMkhyRUp6KzNQRTRlV1ZKTkdWOEVSQW5HbFRvWUVzYzY2Mjhk?=
 =?utf-8?B?Sk1SNVY1dWc2YVVXa0F6OU1RLzd1ckRpNnVUWnlyK0h5c2tpYWtkUmtBVUJM?=
 =?utf-8?B?Ujl5VW9uOXMvNmxRL2FSalRUYVVhbGNoSlZSeWx1b3FxWFVFK0xBSXFGeEZS?=
 =?utf-8?B?UFo0YWgvVlo5RldDaTc1eUIvUGFaRXEzWjRBNVpIQkxEN1V3R1Q2dVhTZW80?=
 =?utf-8?B?VUVrN2JwY1laaGdjbU45d3UybndmZmdFMTJwbW9uY1RUYkQwVVgybXRSK2ZF?=
 =?utf-8?B?bURhdUFuMVBRTThHdnA0T1lzajJScFkrQTdzaUFMQ0VFV3hBUkZDMCs1V1FU?=
 =?utf-8?B?RStiVnZIRnhhVFU5Mlcyb0pNMUFSbE5VVkpISkZFKzNxK1U3NXgzYnRQbml5?=
 =?utf-8?B?WnQxYjZGWXNYUEg5eFgza1ZIWEx4alNnSkhtUDRNK2xuUmxobmo1VVpob0pv?=
 =?utf-8?B?TTJSUndEc1ROUTJ4elRXcXNrVU9wejI1OEVDaGE5WjBOSHZOZDBuNVFGR1VQ?=
 =?utf-8?B?d1NoNmQzQndydHdWUFppVHZOdVhYRWUzQlBGS1o4R2Y3QnZmYVB5ZVRkTjdt?=
 =?utf-8?B?RlAxTm9JMmV0bEUvd0E2MWFBVUZCV0RmcTJ1WmxjQjJLRGZEQnh6c3RsNGNE?=
 =?utf-8?Q?ls2JlSz7FpOga?=
X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;
 CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);
 DIR:OUT; SFP:1101; 
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2024 09:14:03.8866 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 478bdaf5-1cb5-4781-f4c7-08dcd7c23dc3
X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];
 Helo=[oa.msg.ericsson.com]
X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E2.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7141
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Extend bitops tests to cover the rte_bit_atomic_*() family of
functions.

Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>

--

RFC v4:
 * Add atomicity test for atomic bit flip.

RFC v3:
 * Rename variable 'main' to make ICC happy.
---
 app/test/test_bitops.c | 313 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 312 insertions(+), 1 deletion(-)

diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c
index 322f58c066..b80216a0a1 100644
--- a/app/test/test_bitops.c
+++ b/app/test/test_bitops.c
@@ -3,10 +3,13 @@
  * Copyright(c) 2024 Ericsson AB
  */
 
+#include <inttypes.h>
 #include <stdbool.h>
 
-#include <rte_launch.h>
 #include <rte_bitops.h>
+#include <rte_cycles.h>
+#include <rte_launch.h>
+#include <rte_lcore.h>
 #include <rte_random.h>
 #include "test.h"
 
@@ -61,6 +64,304 @@ GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear,
 GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear,
 		    rte_bit_assign, rte_bit_flip, rte_bit_test, 64)
 
+#define bit_atomic_set(addr, nr)				\
+	rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed)
+
+#define bit_atomic_clear(addr, nr)					\
+	rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed)
+
+#define bit_atomic_assign(addr, nr, value)				\
+	rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed)
+
+#define bit_atomic_flip(addr, nr)					\
+    rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed)
+
+#define bit_atomic_test(addr, nr)				\
+	rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed)
+
+GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set,
+		    bit_atomic_clear, bit_atomic_assign,
+		    bit_atomic_flip, bit_atomic_test, 32)
+
+GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set,
+		    bit_atomic_clear, bit_atomic_assign,
+		    bit_atomic_flip, bit_atomic_test, 64)
+
+#define PARALLEL_TEST_RUNTIME 0.25
+
+#define GEN_TEST_BIT_PARALLEL_ASSIGN(size)				\
+									\
+	struct parallel_access_lcore ## size				\
+	{								\
+		unsigned int bit;					\
+		uint ## size ##_t *word;				\
+		bool failed;						\
+	};								\
+									\
+	static int							\
+	run_parallel_assign ## size(void *arg)				\
+	{								\
+		struct parallel_access_lcore ## size *lcore = arg;	\
+		uint64_t deadline = rte_get_timer_cycles() +		\
+			PARALLEL_TEST_RUNTIME * rte_get_timer_hz();	\
+		bool value = false;					\
+									\
+		do {							\
+			bool new_value = rte_rand() & 1;		\
+			bool use_test_and_modify = rte_rand() & 1;	\
+			bool use_assign = rte_rand() & 1;		\
+									\
+			if (rte_bit_atomic_test(lcore->word, lcore->bit, \
+						rte_memory_order_relaxed) != value) { \
+				lcore->failed = true;			\
+				break;					\
+			}						\
+									\
+			if (use_test_and_modify) {			\
+				bool old_value;				\
+				if (use_assign) 			\
+					old_value = rte_bit_atomic_test_and_assign( \
+						lcore->word, lcore->bit, new_value, \
+						rte_memory_order_relaxed); \
+				else {					\
+					old_value = new_value ?		\
+						rte_bit_atomic_test_and_set( \
+							lcore->word, lcore->bit, \
+							rte_memory_order_relaxed) : \
+						rte_bit_atomic_test_and_clear( \
+							lcore->word, lcore->bit, \
+							rte_memory_order_relaxed); \
+				}					\
+				if (old_value != value) {		\
+					lcore->failed = true;		\
+					break;				\
+				}					\
+			} else {					\
+				if (use_assign)				\
+					rte_bit_atomic_assign(lcore->word, lcore->bit, \
+							      new_value, \
+							      rte_memory_order_relaxed); \
+				else {					\
+					if (new_value)			\
+						rte_bit_atomic_set(	\
+							lcore->word, lcore->bit, \
+							rte_memory_order_relaxed); \
+					else				\
+						rte_bit_atomic_clear(	\
+							lcore->word, lcore->bit, \
+							rte_memory_order_relaxed); \
+				}					\
+			}						\
+									\
+			value = new_value;				\
+		} while (rte_get_timer_cycles() < deadline);		\
+									\
+		return 0;						\
+	}								\
+									\
+	static int							\
+	test_bit_atomic_parallel_assign ## size(void)			\
+	{								\
+		unsigned int worker_lcore_id;				\
+		uint ## size ## _t word = 0;				\
+		struct parallel_access_lcore ## size lmain = {		\
+			.word = &word					\
+		};							\
+		struct parallel_access_lcore ## size lworker = {	\
+			.word = &word					\
+		};							\
+									\
+		if (rte_lcore_count() < 2) {				\
+			printf("Need multiple cores to run parallel test.\n"); \
+			return TEST_SKIPPED;				\
+		}							\
+									\
+		worker_lcore_id = rte_get_next_lcore(-1, 1, 0);		\
+									\
+		lmain.bit = rte_rand_max(size);				\
+		do {							\
+			lworker.bit = rte_rand_max(size);		\
+		} while (lworker.bit == lmain.bit);			\
+									\
+		int rc = rte_eal_remote_launch(run_parallel_assign ## size, \
+					       &lworker, worker_lcore_id); \
+		TEST_ASSERT(rc == 0, "Worker thread launch failed");	\
+									\
+		run_parallel_assign ## size(&lmain);			\
+									\
+		rte_eal_mp_wait_lcore();				\
+									\
+		TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \
+		TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \
+			    "failed");					\
+									\
+		return TEST_SUCCESS;					\
+	}
+
+GEN_TEST_BIT_PARALLEL_ASSIGN(32)
+GEN_TEST_BIT_PARALLEL_ASSIGN(64)
+
+#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size)			\
+									\
+	struct parallel_test_and_set_lcore ## size			\
+	{								\
+		uint ## size ##_t *word;				\
+		unsigned int bit;					\
+		uint64_t flips;						\
+	};								\
+									\
+	static int							\
+	run_parallel_test_and_modify ## size(void *arg)		\
+	{								\
+		struct parallel_test_and_set_lcore ## size *lcore = arg; \
+		uint64_t deadline = rte_get_timer_cycles() +		\
+			PARALLEL_TEST_RUNTIME * rte_get_timer_hz();	\
+		do {							\
+			bool old_value;					\
+			bool new_value = rte_rand() & 1;		\
+			bool use_assign = rte_rand() & 1;		\
+									\
+			if (use_assign)					\
+				old_value = rte_bit_atomic_test_and_assign( \
+					lcore->word, lcore->bit, new_value, \
+					rte_memory_order_relaxed);	\
+			else						\
+				old_value = new_value ?			\
+					rte_bit_atomic_test_and_set(	\
+						lcore->word, lcore->bit, \
+						rte_memory_order_relaxed) : \
+					rte_bit_atomic_test_and_clear(	\
+						lcore->word, lcore->bit, \
+						rte_memory_order_relaxed); \
+			if (old_value != new_value)			\
+				lcore->flips++;				\
+		} while (rte_get_timer_cycles() < deadline);		\
+									\
+		return 0;						\
+	}								\
+									\
+	static int							\
+	test_bit_atomic_parallel_test_and_modify ## size(void)		\
+	{								\
+		unsigned int worker_lcore_id;				\
+		uint ## size ## _t word = 0;				\
+		unsigned int bit = rte_rand_max(size);			\
+		struct parallel_test_and_set_lcore ## size lmain = {	\
+			.word = &word,					\
+			.bit = bit					\
+		};							\
+		struct parallel_test_and_set_lcore ## size lworker = {	\
+			.word = &word,					\
+			.bit = bit					\
+		};							\
+									\
+		if (rte_lcore_count() < 2) {				\
+			printf("Need multiple cores to run parallel test.\n"); \
+			return TEST_SKIPPED;				\
+		}							\
+									\
+		worker_lcore_id = rte_get_next_lcore(-1, 1, 0);		\
+									\
+		int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \
+					       &lworker, worker_lcore_id); \
+		TEST_ASSERT(rc == 0, "Worker thread launch failed");	\
+									\
+		run_parallel_test_and_modify ## size(&lmain);		\
+									\
+		rte_eal_mp_wait_lcore();				\
+									\
+		uint64_t total_flips = lmain.flips + lworker.flips;	\
+		bool expected_value = total_flips % 2;			\
+									\
+		TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \
+			    "After %"PRId64" flips, the bit value "	\
+			    "should be %d", total_flips, expected_value); \
+									\
+		uint64_t expected_word = 0;				\
+		rte_bit_assign(&expected_word, bit, expected_value);	\
+									\
+		TEST_ASSERT(expected_word == word, "Untouched bits have " \
+			    "changed value");				\
+									\
+		return TEST_SUCCESS;					\
+	}
+
+GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32)
+GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64)
+
+#define GEN_TEST_BIT_PARALLEL_FLIP(size)				\
+									\
+	struct parallel_flip_lcore ## size				\
+	{								\
+		uint ## size ##_t *word;				\
+		unsigned int bit;					\
+		uint64_t flips;						\
+	};								\
+									\
+	static int							\
+	run_parallel_flip ## size(void *arg)				\
+	{								\
+		struct parallel_flip_lcore ## size *lcore = arg; \
+		uint64_t deadline = rte_get_timer_cycles() +		\
+			PARALLEL_TEST_RUNTIME * rte_get_timer_hz();	\
+		do {							\
+			rte_bit_atomic_flip(lcore->word, lcore->bit,	\
+					    rte_memory_order_relaxed);	\
+			lcore->flips++;					\
+		} while (rte_get_timer_cycles() < deadline);		\
+									\
+		return 0;						\
+	}								\
+									\
+	static int							\
+	test_bit_atomic_parallel_flip ## size(void)			\
+	{								\
+		unsigned int worker_lcore_id;				\
+		uint ## size ## _t word = 0;				\
+		unsigned int bit = rte_rand_max(size);			\
+		struct parallel_flip_lcore ## size lmain = {		\
+			.word = &word,					\
+			.bit = bit					\
+		};							\
+		struct parallel_flip_lcore ## size lworker = {		\
+			.word = &word,					\
+			.bit = bit					\
+		};							\
+									\
+		if (rte_lcore_count() < 2) {				\
+			printf("Need multiple cores to run parallel test.\n"); \
+			return TEST_SKIPPED;				\
+		}							\
+									\
+		worker_lcore_id = rte_get_next_lcore(-1, 1, 0);		\
+									\
+		int rc = rte_eal_remote_launch(run_parallel_flip ## size, \
+					       &lworker, worker_lcore_id); \
+		TEST_ASSERT(rc == 0, "Worker thread launch failed");	\
+									\
+		run_parallel_flip ## size(&lmain);			\
+									\
+		rte_eal_mp_wait_lcore();				\
+									\
+		uint64_t total_flips = lmain.flips + lworker.flips;	\
+		bool expected_value = total_flips % 2;			\
+									\
+		TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \
+			    "After %"PRId64" flips, the bit value "	\
+			    "should be %d", total_flips, expected_value); \
+									\
+		uint64_t expected_word = 0;				\
+		rte_bit_assign(&expected_word, bit, expected_value);	\
+									\
+		TEST_ASSERT(expected_word == word, "Untouched bits have " \
+			    "changed value");				\
+									\
+		return TEST_SUCCESS;					\
+	}
+
+GEN_TEST_BIT_PARALLEL_FLIP(32)
+GEN_TEST_BIT_PARALLEL_FLIP(64)
+
 static uint32_t val32;
 static uint64_t val64;
 
@@ -177,6 +478,16 @@ static struct unit_test_suite test_suite = {
 	.unit_test_cases = {
 		TEST_CASE(test_bit_access32),
 		TEST_CASE(test_bit_access64),
+		TEST_CASE(test_bit_access32),
+		TEST_CASE(test_bit_access64),
+		TEST_CASE(test_bit_atomic_access32),
+		TEST_CASE(test_bit_atomic_access64),
+		TEST_CASE(test_bit_atomic_parallel_assign32),
+		TEST_CASE(test_bit_atomic_parallel_assign64),
+		TEST_CASE(test_bit_atomic_parallel_test_and_modify32),
+		TEST_CASE(test_bit_atomic_parallel_test_and_modify64),
+		TEST_CASE(test_bit_atomic_parallel_flip32),
+		TEST_CASE(test_bit_atomic_parallel_flip64),
 		TEST_CASE(test_bit_relaxed_set),
 		TEST_CASE(test_bit_relaxed_clear),
 		TEST_CASE(test_bit_relaxed_test_set_clear),
-- 
2.34.1