From: Dean Marx <dmarx@iol.unh.edu>
To: probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu,
luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
juraj.linkes@pantheon.tech
Cc: dev@dpdk.org, Dean Marx <dmarx@iol.unh.edu>
Subject: [PATCH v2] dts: add package mode config and updated docs
Date: Wed, 18 Sep 2024 16:19:28 -0400 [thread overview]
Message-ID: <20240918201928.26100-1-dmarx@iol.unh.edu> (raw)
In-Reply-To: <20240812163538.29904-1-dmarx@iol.unh.edu>
In the current DTS setup description, the user installs poetry
with the --no-root option. However, adding 'package-mode = false'
to the pyproject.toml sets the same configuration, and running
poetry install --no-root will become an error in a future
poetry version.
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
doc/guides/tools/dts.rst | 6 +++---
dts/.devcontainer/devcontainer.json | 2 +-
dts/README.md | 4 ++--
dts/pyproject.toml | 1 +
4 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
index 8008c9f74d..65cce9e5ed 100644
--- a/doc/guides/tools/dts.rst
+++ b/doc/guides/tools/dts.rst
@@ -92,7 +92,7 @@ Setting up DTS environment
.. code-block:: console
- poetry install --no-root
+ poetry install
poetry shell
#. **SSH Connection**
@@ -449,8 +449,8 @@ The :ref:`doc build dependencies <doc_dependencies>` may be installed with Poetr
.. code-block:: console
- poetry install --no-root --only docs
- poetry install --no-root --with docs # an alternative that will also install DTS dependencies
+ poetry install --only docs
+ poetry install --with docs # an alternative that will also install DTS dependencies
poetry shell
After executing the meson command, build the documentation with:
diff --git a/dts/.devcontainer/devcontainer.json b/dts/.devcontainer/devcontainer.json
index 4d737f1b40..d96b4fdab2 100644
--- a/dts/.devcontainer/devcontainer.json
+++ b/dts/.devcontainer/devcontainer.json
@@ -13,7 +13,7 @@
// "forwardPorts": [],
// The next line runs commands after the container is created - in our case, installing dependencies.
- "postCreateCommand": "poetry install --no-root",
+ "postCreateCommand": "poetry install",
"extensions": [
"ms-python.vscode-pylance",
diff --git a/dts/README.md b/dts/README.md
index ee3fa1c968..2b3a7f89c5 100644
--- a/dts/README.md
+++ b/dts/README.md
@@ -37,7 +37,7 @@ to allow you to connect to hosts without specifying a password.
```shell
docker build --target dev -t dpdk-dts .
docker run -v $(pwd)/..:/dpdk -v /home/dtsuser/.ssh:/root/.ssh:ro -it dpdk-dts bash
-$ poetry install --no-root
+$ poetry install
$ poetry shell
```
@@ -46,7 +46,7 @@ $ poetry shell
```shell
docker build --target dev -t dpdk-dts .
docker run -v $(pwd)/..:/dpdk -it dpdk-dts bash
-$ poetry install --no-root
+$ poetry install
$ poetry shell
```
diff --git a/dts/pyproject.toml b/dts/pyproject.toml
index 38281f0e39..91d459f573 100644
--- a/dts/pyproject.toml
+++ b/dts/pyproject.toml
@@ -3,6 +3,7 @@
# Copyright(c) 2023 PANTHEON.tech s.r.o.
[tool.poetry]
+package-mode = false
name = "dts"
version = "0.1.0"
description = "DPDK Test Suite."
--
2.44.0
next prev parent reply other threads:[~2024-09-18 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 16:35 [PATCH v1] dts: add package mode config and updated README Dean Marx
2024-08-12 18:55 ` Nicholas Pratte
2024-09-11 15:33 ` Luca Vizzarro
2024-09-16 10:10 ` Juraj Linkeš
2024-09-18 20:19 ` Dean Marx [this message]
2024-09-19 9:27 ` [PATCH v2] dts: add package mode config and updated docs Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918201928.26100-1-dmarx@iol.unh.edu \
--to=dmarx@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=luca.vizzarro@arm.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).