From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61180459D0; Wed, 18 Sep 2024 22:54:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF7E3432B8; Wed, 18 Sep 2024 22:53:44 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 79B6B43246 for ; Wed, 18 Sep 2024 22:53:40 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2068a7c9286so1946035ad.1 for ; Wed, 18 Sep 2024 13:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726692820; x=1727297620; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+6hqMhc0E9TDs99Fu5BKypiDNT7B7d94ylR7Fbmsrwg=; b=Y5Z8roYXGJroFcS+R64aaFCu9J01hYZIp+lTLBNLEgUmYdEpCZLDDf2q+OQIo08vPa CvzlyEQ5k9hYyLV1ymSffQoFFHjyxop3hzZRLOvGPTPKyJP1fkbNq2Yl7buinCdylU2a p8xQh8pgHCKCn+83h8VzOv+LUZcNlCGLvUbAM+eqe4Dq87EkwrzjO8GxRqvE8gOxrIjo uDn1PBJI+T702h7ll1qyqJDSyv1PTUO7CuSugMOd/4WbnhK7Ya0SCI6k61iJThsNqFeJ bnPxyyGJf9Y/AdSHX7xJGzLw3jg8ORSgchAa7UeyC+8hGjaovpwMwTtQZX8O0YP3eZVw 4R/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726692820; x=1727297620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+6hqMhc0E9TDs99Fu5BKypiDNT7B7d94ylR7Fbmsrwg=; b=tB49WlSePAKXvkLOOQI/6QdIWrdMYLVyAFNLK6xHuhGq081pft0t5zOuIYpH8D0KdJ CGaM4hT+N0uOrGSTBBZHIUFK8oSfVFMNE4s3IVmwL8yljVBPy9lAK3fiYdNsoal5DYsd YLf8KfH65+3NAMuGokHhTz3Q3h11HppWvkjPTLpp1fLUnsb8O9vbhUyYwCJES93I8uY5 qHDeAN0fVD1sWRMXH4SI0xbCQhESDLJ684Jx/o+lSj/GsA4/LgAcEyMMwwxacWgZoADP 0tWNrAh8cxGnsx3D3sVsvHzM0rk3GFit/BGgeiOZsv2ZTU/8/yORCjlEGHUDzA4M2Mk+ aVmA== X-Gm-Message-State: AOJu0YxBwgrPDcfZxU+UIAwlQvVY3LwR1YoqMXfWwX/t3MBL1Cb83FrT l6lGz2crgTZPuYgyzxRya4PPiricbVn82xEnotywSVq3uNChy40CWEv8jsgz451gJplT0OszaX0 A X-Google-Smtp-Source: AGHT+IGgocvNZGi4y+CLlWKKVOU1l5SAUTk8wg3AbNSOTOzLSFRN9sFilvSxZ5xZ/8KKYe9YPDO5ow== X-Received: by 2002:a17:903:32ca:b0:1fd:5fa0:e98f with SMTP id d9443c01a7336-20782a6a145mr262765585ad.44.1726692819600; Wed, 18 Sep 2024 13:53:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2079471a2e6sm69415775ad.240.2024.09.18.13.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 13:53:39 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v24 05/15] eal: do not duplicate rte_init_alert() messages Date: Wed, 18 Sep 2024 13:52:04 -0700 Message-ID: <20240918205324.35449-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240918205324.35449-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240918205324.35449-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 0ded386472..7c26393d00 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.45.2