From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28EB7459D0; Wed, 18 Sep 2024 22:54:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05FFC432D0; Wed, 18 Sep 2024 22:53:47 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 1545743299 for ; Wed, 18 Sep 2024 22:53:42 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1fee6435a34so2419875ad.0 for ; Wed, 18 Sep 2024 13:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726692821; x=1727297621; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qGtmK3qwNHeGU/x2mdt2PswGscO2i82YPt0apqyqHN0=; b=ZWdu+m77dAqvaWXgprm/WIh5Esu7UVlGBngJSnSQCz5uoRtV+EDSXkMVoaTVAZFTey z1UngD+JvYIF8opnnHo2YQ865ZQ3yCcjHe+qw5xjvZ8ZLhIDNkR8zQlqdKX1XVS1wEmA /y5q6EOVShscLFCqHtf1zQRrcweoCzd9ZHm2iG3uRQdyPTHswlZ5YlPNonBycD3SGnEo TF+wORr4BBfaqNN1perB1Qyh8zMUcMW8GGKx51MPjxPHAHt/Eavf1NuiSdn5Jz5/Dl3l 7fnG9YB6IBNbK1ODuoXWhPZtoyJ5zaCZCa39QyfyxJvpvYu7iuoCU3FfaRb5snYxdCPJ wu0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726692821; x=1727297621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qGtmK3qwNHeGU/x2mdt2PswGscO2i82YPt0apqyqHN0=; b=X3n994oygXMsV6DS19PCT5lVnzMLjruGA09lVwcGKBlwVjaXv68ov4ejaPCAw4Ts07 /6XtoJspz6drFawdlUgKTx/+rBU5n6lIRmaX8czTYQ7cqg1W8jrzChdCj/ZWoeWC49rX +xdCVSNNXt9ADbjPtV/Bcjs8f4/h9v2NRCzBtQhM7BIQnmCC6Idjash+AwFZlsnEjRBc lCIm6rh1Tu4ZRniXgogmXigjmnnD99hpb5curbD90ubdV9zFInkxLiYvD62ykPSJbPZI EYCpv+oj6mBuORxywTHp5B3SaNJUgStPH8lqAvPiEz6p7YI3ZLOCcvXNq/vrIEeDEpe1 +T9w== X-Gm-Message-State: AOJu0YyRUOoj8WSt70axb5abWoxxuunCPUl5kb2IPevBc8U73XZf23Qa 4ElWJzbLxhPNVUiImMDDho2f8hKa0Ac43za+buqpiK/ud+keNam6HHSQAA7sgX22Sml8W1Ie129 3 X-Google-Smtp-Source: AGHT+IEOQzCdyww7tCundnUtb8jNkkmOWg1t54jTJPn4o/4WkBKMFLmjuPZVGEclVQfXNN47Tz5lKg== X-Received: by 2002:a17:902:e94d:b0:205:5f36:ffa0 with SMTP id d9443c01a7336-2076e393a75mr366351825ad.35.1726692821202; Wed, 18 Sep 2024 13:53:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2079471a2e6sm69415775ad.240.2024.09.18.13.53.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 13:53:40 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson Subject: [PATCH v24 06/15] eal: change rte_exit() output to match rte_log() Date: Wed, 18 Sep 2024 13:52:05 -0700 Message-ID: <20240918205324.35449-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240918205324.35449-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240918205324.35449-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with code: 1 [ 0.006250] EAL: Cannot init EAL: Permission denied Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 3e77995896..bcfcd6df6f 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -36,15 +36,13 @@ rte_exit(int exit_code, const char *format, ...) va_list ap; if (exit_code != 0) - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" - " Cause: ", exit_code); + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); va_start(ap, format); rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) - EAL_LOG(CRIT, - "EAL could not release all resources"); + EAL_LOG(CRIT, "EAL could not release all resources"); exit(exit_code); } -- 2.45.2