From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77E29459D7; Thu, 19 Sep 2024 17:07:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E4174338C; Thu, 19 Sep 2024 17:06:27 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 385954337F for ; Thu, 19 Sep 2024 17:06:24 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-71957eb256bso834520b3a.3 for ; Thu, 19 Sep 2024 08:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726758383; x=1727363183; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+6hqMhc0E9TDs99Fu5BKypiDNT7B7d94ylR7Fbmsrwg=; b=HCjLiz/rpArPIG6HR4rXOoVJx5PrHBeTt3zlfVb74BE6lh1ZW9Z+a1eIvApMDIv0LZ 7ISIVRbiYN6eC4Jx+Ni4FLPoI2SBmjns0WXHiLfrn2GWAOOLxmLFxT+lWRabTKHA7MUJ bHwbVeLdjtZPaYUWmX62AeJlE6LbmnC5YirNT7qjS/np2g5D+5ntC2ehh8yNFSeD4yKv ENDtv6z+4dQJ9GUHi0qww2xuwyzrw12Fsr0W5cl8BVuoxrh9L2Mdnzw3s8t3/sTOIiEn l8NF4DRlLNrMVy2PDlnuwBZR0VXmoTTz2a+KJ/Z3Nx43jsj3fCq62Ts2BgcIgSejCFif hXwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726758383; x=1727363183; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+6hqMhc0E9TDs99Fu5BKypiDNT7B7d94ylR7Fbmsrwg=; b=XADqZzzjb7DpQJeFLFy3kE7qW9dDi3d4fOAFCuoERRyXEgDapJqRNO3qKFXXnDlPzT iFTGckmpJnLfyh8xpqQC63TCjmgCOAvcrg2271630Lg5Iw/e2FSZd8Lk2gvY+kfzpNxY 86h20NSJQ5uIPr4cboidgb+R/xpVYJa1vQyX8jbDlUbdTVTsM6p8T8L4svwSFi1D4JLj ZLUhvzjG7UYLpNSyjp6qLdfXqAEK47vbHc1iPfYlwiF3nZLbQkJbNYqm7veOlDN7aVCe kx98fvAmA/i94rHP0ODhCSVSTqeB4SyQrGCiWvb3xUCoRyqcfgYRnS3IsCB+sQko4Grd DKkw== X-Gm-Message-State: AOJu0Ywja1Gg0rBhRnR/so5vc4E2slEuRp0FOjHndB3MYMxshn1IUu9k FY0C3WylbVjeT9Bm++z6bSG6WL/1Jtf3aAAVipIzH+PhkaQ8S19G2YmTL8zCP+ndSokhVuGcVps M X-Google-Smtp-Source: AGHT+IGZGcuffzG1KBUd0PmWIboSpnLHTbrJ5M1+rCTcZv7N4n0PE0NOE/6kK5LScxWniocC4zswXw== X-Received: by 2002:a05:6a00:b8c:b0:717:8e01:c593 with SMTP id d2e1a72fcca58-71936a366f8mr32918583b3a.3.1726758383338; Thu, 19 Sep 2024 08:06:23 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944adfd3dsm8620841b3a.92.2024.09.19.08.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2024 08:06:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v25 05/15] eal: do not duplicate rte_init_alert() messages Date: Thu, 19 Sep 2024 08:04:11 -0700 Message-ID: <20240919150609.5281-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240919150609.5281-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240919150609.5281-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 0ded386472..7c26393d00 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.45.2