From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29A1A45A11; Mon, 23 Sep 2024 17:44:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E359C402F1; Mon, 23 Sep 2024 17:44:02 +0200 (CEST) Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) by mails.dpdk.org (Postfix) with ESMTP id CD4AD402CA for ; Mon, 23 Sep 2024 17:44:00 +0200 (CEST) Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-20573eb852aso34913545ad.1 for ; Mon, 23 Sep 2024 08:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1727106240; x=1727711040; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HWLkO674CEgO1R9cuWUakQxmvxGT4zWOFFOnQ2O1TlM=; b=IO8sAQvfxflg211hwqt5V4QVcUTDNpo1a+8ZM1Rvz1UHY3Cbie988eywa5QBedePkW JnNaZTuEmHRWbse0IQzh6uPCuye7Zhae3L4IFpsJnnrSsSTrtyOU1WwK2VRpBGA644jX CBAXGhcpVkOHdPn9YdIVtYtiNDq2okdd2Q2ZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727106240; x=1727711040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HWLkO674CEgO1R9cuWUakQxmvxGT4zWOFFOnQ2O1TlM=; b=E/sz4zhK+ofjosuhGS756x4X6OSX2Sh+D/JHro1ioqHF24Vt9qnoOFRnEys4/VGhRq QIISsr6fpt/EYkb8IVjd9HII05QfmrTdkJAJQ66O7AkTW1rEYgvtHftZjzv0eh2pkEI2 pBRcfkK624om3xGF0u1Wy2/A9pIV80xVuE6o1UpFUpxm4Rcfp+VJpwj8i2fRJzYOfGfZ agXNa541h1T7qEG9D37CHm9Wwzo0koJJDQ/EkEwtMsfQski31wYPL1I9+41KhaRD5Vzk +jdNdrxUiUEY5X3qh3zUALiNlck2hKLCvqw7B0XOGZal7AOYKFm5BC0j/iLYurrA7Clq zQGg== X-Gm-Message-State: AOJu0Yxrog5HGYDK8x1hlS5ON3PNA4S0okNM/X8B9hXHrIaDkBz4EDjk 7hsKNgJ2ug2tg45cVyNuTJ8AuCq/O542dxhBf0L49kFOLmS42kdUlZMgc4VymgtZ8uSQTgyiYQs hUs3RaFQ1GPCufmOQVlXRTbcItCcdSodp X-Google-Smtp-Source: AGHT+IGDKPjvEMlEtUCUzhc+PQaM73y4/xAQoOdG0WMFqTEnqy42adFsAei5qRcj6CGMJmOrmEHMqZ7KGKoR X-Received: by 2002:a17:902:e54e:b0:206:9818:5431 with SMTP id d9443c01a7336-20aed0f2a1fmr591935ad.20.1727106239936; Mon, 23 Sep 2024 08:43:59 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-207946b73bcsm4273015ad.94.2024.09.23.08.43.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Sep 2024 08:43:59 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::1083]) by postal.iol.unh.edu (Postfix) with ESMTP id 94EE0605C351; Mon, 23 Sep 2024 11:43:58 -0400 (EDT) From: jspewock@iol.unh.edu To: wathsala.vithanage@arm.com, thomas@monjalon.net, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, juraj.linkes@pantheon.tech, yoan.picchi@foss.arm.com, probb@iol.unh.edu, npratte@iol.unh.edu, alex.chapman@arm.com, Honnappa.Nagarahalli@arm.com Cc: dev@dpdk.org, Jeremy Spewock Subject: [PATCH v2 2/2] dts: add port stats checks test suite Date: Mon, 23 Sep 2024 11:43:46 -0400 Message-ID: <20240923154346.15390-3-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240923154346.15390-1-jspewock@iol.unh.edu> References: <20240802172928.212277-1-jspewock@iol.unh.edu> <20240923154346.15390-1-jspewock@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock This patch adds a new test suite to DTS that validates the accuracy of the port statistics using testpmd. The functionality is tested by sending a packet of a fixed side to the SUT and verifying that the statistic for packets received, received bytes, packets sent, and sent bytes all update accordingly. Depends-on: patch-144268 ("dts: add text parser for testpmd verbose output") Depends-on: patch-144270 ("dts: add VLAN methods to testpmd shell) Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_port_stats_checks.py | 160 +++++++++++++++++++++ 2 files changed, 162 insertions(+), 1 deletion(-) create mode 100644 dts/tests/TestSuite_port_stats_checks.py diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index df390e8ae2..72af3bbe36 100644 --- a/dts/framework/config/conf_yaml_schema.json +++ b/dts/framework/config/conf_yaml_schema.json @@ -187,7 +187,8 @@ "enum": [ "hello_world", "os_udp", - "pmd_buffer_scatter" + "pmd_buffer_scatter", + "port_stats_checks" ] }, "test_target": { diff --git a/dts/tests/TestSuite_port_stats_checks.py b/dts/tests/TestSuite_port_stats_checks.py new file mode 100644 index 0000000000..c873ebe61a --- /dev/null +++ b/dts/tests/TestSuite_port_stats_checks.py @@ -0,0 +1,160 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2024 University of New Hampshire + +"""Port Statistics testing suite. + +This test suite tests the functionality of querying the statistics of a port and verifies that the +values provided in the statistics accurately reflect the traffic that has been handled on the port. +This is shown by sending a packet of a fixed size to the SUT and verifying that the number of RX +packets has increased by 1, the number of RX bytes has increased by the specified size, the number +of TX packets has also increased by 1 (since we expect the packet to be forwarded), and the number +of TX bytes has also increased by the same fixed amount. +""" + +from typing import ClassVar, Tuple + +from scapy.layers.inet import IP # type: ignore[import-untyped] +from scapy.layers.l2 import Ether # type: ignore[import-untyped] +from scapy.packet import Packet, Raw # type: ignore[import-untyped] + +from framework.params.testpmd import SimpleForwardingModes +from framework.remote_session.testpmd_shell import ( + RtePTypes, + TestPmdShell, + TestPmdVerbosePacket, +) +from framework.test_suite import TestSuite + + +class TestPortStatsChecks(TestSuite): + """DPDK Port statistics testing suite. + + Support for port statistics is tested by sending a packet of a fixed size denoted by + `total_packet_len` and verifying the that TX/RX packets of the TX/RX ports updated by exactly + 1 and the TX/RX bytes of the TX/RX ports updated by exactly `total_packet_len`. This is done by + finding the total amount of packets that were sent/received which did not originate from this + test suite and taking the sum of the lengths of each of these "noise" packets and subtracting + it from the total values in the port statistics so that all that is left are relevant values. + """ + + #: Port where traffic will be received on the SUT. + recv_port: ClassVar[int] = 0 + #: Port where traffic will be sent from on the SUT. + send_port: ClassVar[int] = 1 + + #: + ip_header_len: ClassVar[int] = 20 + #: + ether_header_len: ClassVar[int] = 14 + + #: Length of the packet being sent including the IP and frame headers. + total_packet_len: ClassVar[int] = 100 + #: Packet to send during testing. + send_pkt: ClassVar[Packet] = ( + Ether() / IP() / Raw("X" * (total_packet_len - ip_header_len - ether_header_len)) + ) + + def extract_noise_information( + self, verbose_out: list[TestPmdVerbosePacket] + ) -> Tuple[int, int, int, int]: + """Extract information about packets that were not sent by the framework in `verbose_out`. + + Extract the number of sent/received packets that did not originate from this test suite as + well as the sum of the lengths of said "noise" packets. Note that received packets are only + examined on the port with the ID `self.recv_port` since these are the receive stats that + will be analyzed in this suite. Sent packets are also only examined on the port with the ID + `self.send_port`. + + Packets are considered to be "noise" when they don't match the expected structure of the + packets that are being sent by this test suite. Specifically, the source and destination + mac addresses as well as the software packet type are checked on packets received by + testpmd to ensure they match the proper addresses of the TG and SUT nodes. Packets that are + sent by testpmd however only check the source mac address and the software packet type. + This is because MAC forwarding mode adjusts both addresses, but only the source will belong + to the TG or SUT node. + + Args: + verbose_out: Parsed testpmd verbose output to collect the noise information from. + + Returns: + A tuple containing the total size of received noise in bytes, the number of received + noise packets, size of all noise packets sent by testpmd in bytes, and the number of + noise packets sent by testpmd. + """ + recv_noise_bytes = 0 + recv_noise_packets = 0 + sent_noise_bytes = 0 + num_sent_packets = 0 + for verbose_packet in verbose_out: + if verbose_packet.was_received and verbose_packet.port_id == self.recv_port: + if ( + verbose_packet.src_mac.lower() != self._tg_port_egress.mac_address.lower() + or verbose_packet.dst_mac.lower() != self._sut_port_ingress.mac_address.lower() + or verbose_packet.sw_ptype != (RtePTypes.L2_ETHER | RtePTypes.L3_IPV4) + ): + recv_noise_bytes += verbose_packet.length + recv_noise_packets += 1 + elif not verbose_packet.was_received and verbose_packet.port_id == self.send_port: + if ( + verbose_packet.src_mac.lower() != self._sut_port_egress.mac_address.lower() + or verbose_packet.sw_ptype != (RtePTypes.L2_ETHER | RtePTypes.L3_IPV4) + ): + sent_noise_bytes += verbose_packet.length + num_sent_packets += 1 + + return recv_noise_bytes, recv_noise_packets, sent_noise_bytes, num_sent_packets + + def test_stats_updates(self) -> None: + """Send a packet with a fixed length and verify port stats updated properly. + + Send a packet with a total length of `self.total_packet_len` and verify that the rx port + only received one packet and the number of rx_bytes increased by exactly + `self.total_packet_len`. Also verify that the tx port only sent one packet and that the + tx_bytes of the port increase by exactly `self.total_packet_len`. + + Noise on the wire is ignored by extracting the total number of noise packets and the sum of + the lengths of those packets and subtracting them from the totals that are provided by the + testpmd command `show port info all`. + + Test: + Start testpmd in MAC forwarding mode and set verbose mode to 3 (RX and TX). + Start packet forwarding and then clear all port statistics. + Send a packet, then stop packet forwarding and collect the port stats. + Parse verbose info from stopping packet forwarding and verify values in port stats. + """ + with TestPmdShell(self.sut_node, forward_mode=SimpleForwardingModes.mac) as testpmd: + testpmd.set_verbose(3) + testpmd.start() + testpmd.clear_port_stats_all() + self.send_packet_and_capture(self.send_pkt) + port_stats_all, forwarding_info = testpmd.show_port_stats_all() + verbose_information = TestPmdShell.extract_verbose_output(forwarding_info) + + # Gather information from irrelevant packets sent/ received on the same port. + rx_irr_bytes, rx_irr_pakts, tx_irr_bytes, tx_irr_pakts = self.extract_noise_information( + verbose_information + ) + recv_relevant_packets = port_stats_all[self.recv_port].rx_packets - rx_irr_pakts + sent_relevant_packets = port_stats_all[self.send_port].tx_packets - tx_irr_pakts + recv_relevant_bytes = port_stats_all[self.recv_port].rx_bytes - rx_irr_bytes + sent_relevant_bytes = port_stats_all[self.send_port].tx_bytes - tx_irr_bytes + + self.verify( + recv_relevant_packets == 1, + f"Port {self.recv_port} received {recv_relevant_packets} packets but expected to only " + "receive 1.", + ) + self.verify( + recv_relevant_bytes == self.total_packet_len, + f"Number of bytes received by port {self.recv_port} did not match the amount sent.", + ) + self.verify( + sent_relevant_packets == 1, + f"Number was packets sent by port {self.send_port} was not equal to the number " + f"received by port {self.recv_port}.", + ) + self.verify( + sent_relevant_bytes == self.total_packet_len, + f"Number of bytes sent by port {self.send_port} did not match the number of bytes " + f"received by port {self.recv_port}.", + ) -- 2.46.0