From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09B9145A19; Tue, 24 Sep 2024 08:00:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 822D2402F1; Tue, 24 Sep 2024 08:00:27 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) by mails.dpdk.org (Postfix) with ESMTP id 6FD6E402D8 for ; Tue, 24 Sep 2024 08:00:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xFHf0dCltE93ICw5qlS9h4Z/T3SW569AT5rMCEkGfG275Yt/ZcNE1zUoxCeLNcW3gq5fxCdejY9Q7XxKYwrsGXRbcWtdF3mtQ2g79+WntOxmYF79gKExIvMVSFDFJWtzg4QjyJvjIYS8GtjbsiaL0UbWKlZicWs91/OOrnmyP0keZ8MGolUaBC9l6E/aFpBMZcp5LHgUwBJFF8inydFyl9RfbMEYbb+Y1j6g/GMFM93LATMQQdN1u1n1Nw0HBmBIgj+8EB6PLPNx34mb8kc9k2worxP8p75BhLYqLZaIEoBcD+jzZDTPkdj7GzsqPGoieli0Hp4AuGBirQCNbR3K1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zUPpoRZpoO94Uw5tLl4nNtPfBFphnhL90/dAIGZ18Rk=; b=dT5vB+16w+R2PX1eSdpQqOjqlz+lE19HFdyRB4OgObMUMtEtZeIoZozkxvWTdFo5b3+hkgYJDWv66v7Gw9zVCI5SSDVRfEKkddcpNdFHDcZ8HDfvt4PjmO0swRANbcBsPhf4lQr8efU0fiD1Gd+AVBY/iWuR5Y04/hSB0dwKjZz8tToDK1knUhuW2P8Z554X94z96yrTYxjl+g2lIEnOhDLzUkh56JwhgQ6yblRcfSkuVXjTEgPsVp85JRpD26clzmaXGEicF6sPL82YM2/PxZYXb4+fUMbGlhoZdNOXDlM3a0tJf1m16aikszwcyjPM4DV3PjuK8kWlFnuwGoED2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zUPpoRZpoO94Uw5tLl4nNtPfBFphnhL90/dAIGZ18Rk=; b=H4Z5DsrA9k7iF/KjRgxBEK+74rk1Qc1dt1+OzZg7h2Em/0byrcRoKXI1gI0XPruSWelT0hOy8yRfpjS6sXjmZKDTxSCDP+nhh/6vbvgJWhDHXq0y7H/ydokZNC5Kn9GeYWhxSUkTSq37cLiezYB2XqZrJF3e76tpAo7gaF0F+nQuzr81GNItSiAV6GMrIAmqnmska3G9OQ3aGKGOcX8YThtqpBqf+FlLLBMTXl3IdUvOJt5Ar3Ld8rIOzpCXsxQoM0XMvEyERfdMM9h3Pb5x0nuwyDx4+fTerHvx6C8IiAkbnVKBGgLlYWQICdMDIF8hOcZeVnnFxUC6foSbG57Jqg== Received: from MN2PR19CA0013.namprd19.prod.outlook.com (2603:10b6:208:178::26) by SJ1PR12MB6148.namprd12.prod.outlook.com (2603:10b6:a03:459::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.27; Tue, 24 Sep 2024 06:00:18 +0000 Received: from BL6PEPF0001AB4C.namprd04.prod.outlook.com (2603:10b6:208:178:cafe::27) by MN2PR19CA0013.outlook.office365.com (2603:10b6:208:178::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.27 via Frontend Transport; Tue, 24 Sep 2024 06:00:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB4C.mail.protection.outlook.com (10.167.242.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 24 Sep 2024 06:00:18 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 23 Sep 2024 23:00:03 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 23 Sep 2024 23:00:00 -0700 From: "Minggang Li(Gavin)" To: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou CC: , , Alex Vesker Subject: [PATCH V2 2/3] net/mlx5/hws: add log for failing to create rule in HWS Date: Tue, 24 Sep 2024 08:59:37 +0300 Message-ID: <20240924055938.48374-3-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240924055938.48374-1-gavinl@nvidia.com> References: <20240910075853.292823-4-gavinl@nvidia.com> <20240924055938.48374-1-gavinl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4C:EE_|SJ1PR12MB6148:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d7b0ee8-80ed-4f9d-374f-08dcdc5e2acd X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?C3XlnVSRM9aJ9//ln//pZDX/tPBIZpL/jZwF2WSREGyzG0vQNKWaz5JM9yfb?= =?us-ascii?Q?M+GVZtOIHOI6gbYmUJbzEbWIiZOcbTt9kz4HTlkvk0hqs5jSkssBJRO+/7A9?= =?us-ascii?Q?AXIthCuPKFD0x+MCFz0dzsMYTdXxMADT5F+013DgvvtSwP2UC9YKjnjN6ZTI?= =?us-ascii?Q?vUEIaToILVxSd1h1sIB3XsKKvq7z/OtzN5m69Tq1zLDggoXRm7in7SvjYlyG?= =?us-ascii?Q?SMUK9lYuQzhfIsRiqlMx7qnFdTlncX7t9rsmnO113noPzvlKxmR0rWSFK+MQ?= =?us-ascii?Q?y8QCbxnMXTu10vfP9z+QHky4lcu2HL+sFT9p5ZDaID+91zk1jB/B9hRcfWNm?= =?us-ascii?Q?efiV+Zeo7DOBXXPt4CdfQXNzo3vEPxZKXDgTRGJRhrd3WD7Gn/aaCw/o3fXT?= =?us-ascii?Q?1eEY3JGIU2O7yP91uf+fCyFrwUjpDubzKcgifLqx6lWpUi1mVLX6HZfnAYTD?= =?us-ascii?Q?uEij2AYbothIufSGs+PIGOrA/Sbr6d5hoe7v6mAemnk37fs3Rn1jLwWeWuR5?= =?us-ascii?Q?FQzapT49md0CBwfFuxgQqQlfr19IgpdVluvacqS9CtPXwon7ITUmp6Q0cKsW?= =?us-ascii?Q?fWBzbH85H/3RafnEhvhu5HcrYnMRHChh+I4In0tItRV0fiVkePFJNeuiFyJ6?= =?us-ascii?Q?/A7j5/we/2+PEG3abtPT1VZsXLSazcUz21LVIxydyTmhUVkq17hHMSUppsO8?= =?us-ascii?Q?Ks5XWk8Ug+fe6UoGWV8l6dhG6g9meiONHq+TxaUK4LiAqX9PPKfwmIK+/sRV?= =?us-ascii?Q?NAolVY9PKKKUPCn1Nz6edRV+zPc7rqv/M6lGUbqCZ1xHk5aNhZw7KsR/6nDB?= =?us-ascii?Q?Q4vLN3z9QGAKb12uXwiJfb+P4LggJnziYt+G5fnsg2ev43l2WoYSPIwXjYBa?= =?us-ascii?Q?5stESWFrE3WwnbL0u7OHSkJG799Sy36HWXlNtosrAA2hUeS23Oh3yfRtWcOb?= =?us-ascii?Q?kaF44PG3D34TyqQ5PfNqefm6V5LoOECHGGOWM/tCc7UdNPb9mz2ZjMqWPFTv?= =?us-ascii?Q?Y1wVmzxxdUPvurMtoWp7dXvgV447S72H65sOgylSrABCfguFrw7mcFEW1eWQ?= =?us-ascii?Q?+79x64NhQERHNKd0FdGsflPnbnd/lSYwq/sBHQTJZduhUDtuLePaNddKwR3B?= =?us-ascii?Q?b59CNyfCfLBrmfSXkJy0e6TmW3q7XRWeHUH56cCUEAv7t6EgaStFRctJ7uJH?= =?us-ascii?Q?rxxdwXn4OboWX3HdeYijaLwVUFkNKYo1H1govBwuhp2YZporo5l82XgxmraT?= =?us-ascii?Q?y2ygH2HZyx5q1Q+InwquxM3CYGFQQ9IHsFP/KQEIXQSKr9jjidFA22vkhU+A?= =?us-ascii?Q?eMvpr9WiV7IpBOTb7JSEk4qwG/4PdQ596A5QcrKQmHIHggDpClSMPXJy2l5i?= =?us-ascii?Q?/gHexBs=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2024 06:00:18.0865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d7b0ee8-80ed-4f9d-374f-08dcdc5e2acd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6148 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Signed-off-by: Minggang Li(Gavin) Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 1edb7eac74..5d66d81ea5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -638,6 +638,7 @@ static int mlx5dr_rule_destroy_hws(struct mlx5dr_rule *rule, /* Rule is not completed yet */ if (rule->status == MLX5DR_RULE_STATUS_CREATING) { + DR_LOG(NOTICE, "Cannot destroy, rule creation still in progress"); rte_errno = EBUSY; return rte_errno; } @@ -806,12 +807,14 @@ static int mlx5dr_rule_enqueue_precheck(struct mlx5dr_rule *rule, struct mlx5dr_context *ctx = rule->matcher->tbl->ctx; if (unlikely(!attr->user_data)) { + DR_LOG(DEBUG, "User data must be provided for rule operations"); rte_errno = EINVAL; return rte_errno; } /* Check if there is room in queue */ if (unlikely(mlx5dr_send_engine_full(&ctx->send_queue[attr->queue_id]))) { + DR_LOG(NOTICE, "No room in queue[%d]", attr->queue_id); rte_errno = EBUSY; return rte_errno; } @@ -823,6 +826,7 @@ static int mlx5dr_rule_enqueue_precheck_move(struct mlx5dr_rule *rule, struct mlx5dr_rule_attr *attr) { if (unlikely(rule->status != MLX5DR_RULE_STATUS_CREATED)) { + DR_LOG(DEBUG, "Cannot move, rule status is invalid"); rte_errno = EINVAL; return rte_errno; } @@ -835,6 +839,7 @@ static int mlx5dr_rule_enqueue_precheck_create(struct mlx5dr_rule *rule, { if (unlikely(mlx5dr_matcher_is_in_resize(rule->matcher))) { /* Matcher in resize - new rules are not allowed */ + DR_LOG(NOTICE, "Resizing in progress, cannot create rule"); rte_errno = EAGAIN; return rte_errno; } @@ -1068,6 +1073,7 @@ int mlx5dr_rule_hash_calculate(struct mlx5dr_matcher *matcher, mlx5dr_table_is_root(matcher->tbl) || matcher->tbl->ctx->caps->access_index_mode == MLX5DR_MATCHER_INSERT_BY_HASH || matcher->tbl->ctx->caps->flow_table_hash_type != MLX5_FLOW_TABLE_HASH_TYPE_CRC32) { + DR_LOG(DEBUG, "Matcher is not supported"); rte_errno = ENOTSUP; return -rte_errno; } -- 2.34.1