From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
dev@dpdk.org
Subject: Re: [PATCH v4] eal: add build-time option to omit trace
Date: Tue, 24 Sep 2024 08:30:23 -0700 [thread overview]
Message-ID: <20240924083023.28bf896a@fedora> (raw)
In-Reply-To: <20240924133957.1505113-1-mb@smartsharesystems.com>
On Tue, 24 Sep 2024 13:39:57 +0000
Morten Brørup <mb@smartsharesystems.com> wrote:
> Some applications want to omit the trace feature.
> Either to reduce the memory footprint, to reduce the exposed attack
> surface, or for other reasons.
>
> This patch adds an option in rte_config.h to include or omit trace in the
> build. Trace is included by default.
>
> Omitting trace works by omitting all trace points.
> For API and ABI compatibility, the trace feature itself remains.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
This is good compact solution. In future, it would be nice if DPDK could
use static keys to isolate rarely used features. But static keys require
runtime modification of instructions.
https://docs.kernel.org/6.7/staging/static-keys.html
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-09-24 15:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 8:55 [PATCH] " Morten Brørup
2024-09-18 9:49 ` Jerin Jacob
2024-09-18 10:23 ` Morten Brørup
2024-09-19 8:06 ` [PATCH v2] " Morten Brørup
2024-09-19 8:51 ` Jerin Jacob
2024-09-19 13:15 ` Morten Brørup
2024-09-19 13:54 ` Jerin Jacob
2024-09-19 15:35 ` Morten Brørup
2024-09-19 15:49 ` Jerin Jacob
2024-09-19 16:08 ` Morten Brørup
2024-09-19 16:34 ` Jerin Jacob
2024-09-20 9:08 ` [PATCH v3] " Morten Brørup
2024-09-23 8:39 ` Jerin Jacob
2024-09-24 13:50 ` Morten Brørup
2024-09-24 13:39 ` [PATCH v4] " Morten Brørup
2024-09-24 15:30 ` Stephen Hemminger [this message]
2024-09-24 15:41 ` Jerin Jacob
2024-09-24 15:53 ` Morten Brørup
2024-09-24 15:57 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924083023.28bf896a@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).