From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9C9045A16; Tue, 24 Sep 2024 12:53:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA0E340395; Tue, 24 Sep 2024 12:53:43 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2048.outbound.protection.outlook.com [40.107.92.48]) by mails.dpdk.org (Postfix) with ESMTP id 24D4B4028E for ; Tue, 24 Sep 2024 12:53:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O/S8rPsLm+GplLwAy8ktDeQF1EbHDQmwVtmbIuoLOw0zq7mLcLBJRkyeEWI7uyIzyl4Qkbb4s9jEsGw4yJAC2DnH5Clsj5lasnPZZPX45wc93bjZsz1t6hna99+NLW13Sz4ph/tpXlWwGlr/KyIV9RRtc3l2FJEIg+d8zLzyMj2LroFw6OjRU8gbXc5HnCqntkbMYfEqWICCGohyNPnLIiUpE5qF9qbYhwFnlf5GMZjjKNpTTdh4l30EHOdnaBl2hYgtuJTGJG9/n+hCrW5xD2IOUidioIlQAyxO/Aka5FSn5hCGw8nmF5khzNY+/erbqKGS7KJtq2W6aVRvfw8SYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhJK3h4GsMWbvN6mDBdIYm/GNgk2VkE6zSp/Pewk+o0=; b=KjR5niHJ9kAeiMw2TDut0rk7TPrQGraqZonNbPL1iCpTl1+Eu+LJO5Etj+uWN9unB1w3I2v+tylCKQfAlwlrXwMpt+eEqk4QDb0Qbjo2ajvZGModHwgK2yOug2YDz2PTErp2my5y01npS/vcRk2UmcHO0drN1KpdfukKvyAuHLEBRp8loyGju63Sub6OAZMUoLr7cialuWM114up6a4vMxVCCmZs0p/RRbLdBd2l71gcWyjmAH0RPt6l1h7juZG9jfahyDRSUnQ9iHEDoXFLJnY/47n3CIakH5iSWDS4wDASqbfX0v8kMw7icqUYJZDDO/6iFKxKKTF6Ak2kf8Bkdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhJK3h4GsMWbvN6mDBdIYm/GNgk2VkE6zSp/Pewk+o0=; b=JsysAIzan/Aydxvcp0x3bzdtS19s078m53UIwjJtH4yIlXOJ6xMo30KMfYupb6+7xTOAlsKpPUNHb0F8Ofx8k9hEVyakTitvYq0833Om3baFI70I72Llnjof5IwnaPqFdeomdDUZ2SV4s/enRHlw3S4YLS56DK+bKtjJlQ54UjGcYVllmvJ6tZthxGPktKxn/wDzKujIsvo9zy0CL5WtMIYNt2SnGr4/A/px07Ai4b4pBG9dMGnf0GvhX+lDujeRIeAjRa5/2QVcnAJcGJHkQgyLQJnLxpPkrHTLO//ySHquqj1XagS/8e5+mdBiGVrgNc2pOXJt5OIrWPh2Ahi0NQ== Received: from BN9PR03CA0126.namprd03.prod.outlook.com (2603:10b6:408:fe::11) by CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.26; Tue, 24 Sep 2024 10:53:34 +0000 Received: from BL6PEPF0001AB77.namprd02.prod.outlook.com (2603:10b6:408:fe:cafe::83) by BN9PR03CA0126.outlook.office365.com (2603:10b6:408:fe::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.27 via Frontend Transport; Tue, 24 Sep 2024 10:53:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB77.mail.protection.outlook.com (10.167.242.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 24 Sep 2024 10:53:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:21 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Sep 2024 03:53:18 -0700 From: "Minggang Li(Gavin)" To: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou CC: , , Alex Vesker Subject: [PATCH V3 2/3] net/mlx5/hws: add log for failing to create rule in HWS Date: Tue, 24 Sep 2024 13:52:57 +0300 Message-ID: <20240924105258.58037-3-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240924105258.58037-1-gavinl@nvidia.com> References: <20240924055938.48374-4-gavinl@nvidia.com> <20240924105258.58037-1-gavinl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB77:EE_|CY8PR12MB7705:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c2b7df6-0bab-4796-bee1-08dcdc8722be X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Jqw7fCzhz18/BzHcXkNG61jefeIG9P+LaX8kDPAJVOKLc8N/ZDMpMYF7dcu9?= =?us-ascii?Q?BjjI+wTA/VFkUmxrIHc5cVLaLtl5oH1vncw8PNgSJSWZHfxdQhwg7xkIMR0H?= =?us-ascii?Q?MdrVcmerx0OrncSU9Sbvn+c5PkbH9x/0eC9LJWuLzE/psbEWuerstoNh8Yoq?= =?us-ascii?Q?eMpmxw1hZCYVGH7bTv/LveEM3YVJd9RnrZn9sJfQNLdeAhukK9xcOdzgTfKY?= =?us-ascii?Q?H7+o5Ydlzmrr81jd7UrlimE4Ej4j3frmGW9LUs8mgc8TcX6jQ8RZMvBEzfEb?= =?us-ascii?Q?TewNDcK/taZhHTAlYPcJY9VTcnXf2Vk2DTGtqSrUrtM2FDmUuz0MbhdS8EyZ?= =?us-ascii?Q?MohmF+kkqvxQPveks8mS5x5/LI2hJvoj6yiio5wAOXCGjJJGYJvCMM2Yp/hH?= =?us-ascii?Q?0YpfTaacexc0/WW9tYOw52qJEO9Lqxsd7Qz0Ke7i5RRxJon9sxl4txlDI9to?= =?us-ascii?Q?NGY+ZfINAZaZh860ZxXj2aISPkwBIi2zaueymwNanIwgQEf5foOCp4xnrio6?= =?us-ascii?Q?8lBdh0E+ysCc6H3shOzuLF1/xvMkNjDHBUgYhL11YNcDTeXhu8wsjEJZJsra?= =?us-ascii?Q?Gabs6rbPXHUYx0WtwA61aGvv4ydbXmThCRb/E1IoaLhuD5ctHGLzvoU+iSyW?= =?us-ascii?Q?VVItpi5pIUNk61QjQv3DLsqKp6Vfxi2p+CbFIJw2kXgqpuBuAMzK5WeWc6qN?= =?us-ascii?Q?7H++ohrkCeLBkLc++CnfmEB7+bznQLZKV1SHmr6E6W009W2p3ulQRXJRgVPw?= =?us-ascii?Q?kTwMVsKpC7eMsfTyef40dk+rNENIouv5zJ/QzrQb/5cr/u4oV2y9lUmjhTvg?= =?us-ascii?Q?55blQLFlsvIsFYqRwhSvV23lCxf3Tzy1X6orAtxcjOolX/dL2QtYhqUMEstC?= =?us-ascii?Q?wz01qQ7uUy6wK59dbBxKxkNWRyV5ll5QubZx205zl1h68NAllWcE5Mfygvnd?= =?us-ascii?Q?RmVGzyq2K4W+JNr5RkCi11nAT6fFqAsGv35pBjWwvHtw3O0uPdhbbIezzj3x?= =?us-ascii?Q?ooxURgkiyZHt86hrcs4cN/8VwspCFIU3slosYmfpdOIu3zbMGLlkrOwTbCw2?= =?us-ascii?Q?J125C3sJI2qA/iqIsUhOkQ+Yn+dO2uNS20J2Suk0CKlAdi2Xrs28VCG5lEc0?= =?us-ascii?Q?tzlTw02FmUG/N8mVPDKhuGA7YkBgIV98XoRdgweKKW0TH+q1ReUVr+cxedkR?= =?us-ascii?Q?2E33IhN7lE+X/taJ8JtQ04KcG2cljyTEhfhDWptDjVusOtecpreToQrqGHjf?= =?us-ascii?Q?mKF0FF8PlICVDZkjpxyjpp4YpJwY5NHfcsSSG7JYyuJWaFFwD94/95wm5Wbz?= =?us-ascii?Q?+XFSyYhCMp2XFjcXLvEcSumot3o20YyBoSr7mqHdZOwN7trpD1rCdhNFLXDz?= =?us-ascii?Q?xZsokIs=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2024 10:53:33.9358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c2b7df6-0bab-4796-bee1-08dcdc8722be X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB77.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7705 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add log messages about the reason why the flow was failed to be created. Signed-off-by: Minggang Li(Gavin) Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 1edb7eac74..5d66d81ea5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -638,6 +638,7 @@ static int mlx5dr_rule_destroy_hws(struct mlx5dr_rule *rule, /* Rule is not completed yet */ if (rule->status == MLX5DR_RULE_STATUS_CREATING) { + DR_LOG(NOTICE, "Cannot destroy, rule creation still in progress"); rte_errno = EBUSY; return rte_errno; } @@ -806,12 +807,14 @@ static int mlx5dr_rule_enqueue_precheck(struct mlx5dr_rule *rule, struct mlx5dr_context *ctx = rule->matcher->tbl->ctx; if (unlikely(!attr->user_data)) { + DR_LOG(DEBUG, "User data must be provided for rule operations"); rte_errno = EINVAL; return rte_errno; } /* Check if there is room in queue */ if (unlikely(mlx5dr_send_engine_full(&ctx->send_queue[attr->queue_id]))) { + DR_LOG(NOTICE, "No room in queue[%d]", attr->queue_id); rte_errno = EBUSY; return rte_errno; } @@ -823,6 +826,7 @@ static int mlx5dr_rule_enqueue_precheck_move(struct mlx5dr_rule *rule, struct mlx5dr_rule_attr *attr) { if (unlikely(rule->status != MLX5DR_RULE_STATUS_CREATED)) { + DR_LOG(DEBUG, "Cannot move, rule status is invalid"); rte_errno = EINVAL; return rte_errno; } @@ -835,6 +839,7 @@ static int mlx5dr_rule_enqueue_precheck_create(struct mlx5dr_rule *rule, { if (unlikely(mlx5dr_matcher_is_in_resize(rule->matcher))) { /* Matcher in resize - new rules are not allowed */ + DR_LOG(NOTICE, "Resizing in progress, cannot create rule"); rte_errno = EAGAIN; return rte_errno; } @@ -1068,6 +1073,7 @@ int mlx5dr_rule_hash_calculate(struct mlx5dr_matcher *matcher, mlx5dr_table_is_root(matcher->tbl) || matcher->tbl->ctx->caps->access_index_mode == MLX5DR_MATCHER_INSERT_BY_HASH || matcher->tbl->ctx->caps->flow_table_hash_type != MLX5_FLOW_TABLE_HASH_TYPE_CRC32) { + DR_LOG(DEBUG, "Matcher is not supported"); rte_errno = ENOTSUP; return -rte_errno; } -- 2.34.1