DPDK patches and discussions
 help / color / mirror / Atom feed
From: jspewock@iol.unh.edu
To: paul.szczepanek@arm.com, probb@iol.unh.edu, thomas@monjalon.net,
	alex.chapman@arm.com, Honnappa.Nagarahalli@arm.com,
	wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com,
	Luca.Vizzarro@arm.com, juraj.linkes@pantheon.tech,
	npratte@iol.unh.edu
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>
Subject: [PATCH v3 1/2] dts: add symbolic link to dpdk-devbind script
Date: Tue, 24 Sep 2024 12:28:41 -0400	[thread overview]
Message-ID: <20240924162842.11714-2-jspewock@iol.unh.edu> (raw)
In-Reply-To: <20240924162842.11714-1-jspewock@iol.unh.edu>

From: Jeremy Spewock <jspewock@iol.unh.edu>

The devbind script is used throughout DTS to manage drivers on the
remote hosts. Currently, the only way to copy this script onto a host
is to either copy the entire DPDK directory onto a host, or reach out
of the dts directory into its parent DPDK directory to access the
script. The first is undesirable if the host doesn't require any other
DPDK tools since you would be copying extra unneeded information and
the second is undesirable since it enforces the assumption that DTS is
being run from within the DPDK directory. To solve this issue a symbolic
link is added which links the devbind script from the parent into the
DTS directory.

Since this file is not part of DTS and therefore is not expected to
follow DTS formatting rules, it is excluded from the DTS formatting
script.

Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
---
 devtools/dts-check-format.sh | 9 +++++----
 dts/dpdk-devbind.py          | 1 +
 2 files changed, 6 insertions(+), 4 deletions(-)
 create mode 120000 dts/dpdk-devbind.py

diff --git a/devtools/dts-check-format.sh b/devtools/dts-check-format.sh
index 3f43e17e88..adc199d34e 100755
--- a/devtools/dts-check-format.sh
+++ b/devtools/dts-check-format.sh
@@ -13,6 +13,7 @@ usage() {
 format=true
 lint=true
 typecheck=true
+ignore="dpdk-devbind.py"
 
 # Comments after args serve as documentation; must be present
 while getopts "hflt" arg; do
@@ -54,14 +55,14 @@ if $format; then
 			heading "Formatting in $directory/"
 			if command -v black > /dev/null; then
 				echo "Formatting code with black:"
-				black .
+				black --exclude "$ignore" .
 			else
 				echo "black is not installed, not formatting"
 				errors=$((errors + 1))
 			fi
 			if command -v isort > /dev/null; then
 				echo "Sorting imports with isort:"
-				isort .
+				isort --skip "$ignore" .
 			else
 				echo "isort is not installed, not sorting imports"
 				errors=$((errors + 1))
@@ -90,7 +91,7 @@ if $lint; then
 	fi
 	heading "Linting in $directory/"
 	if command -v pylama > /dev/null; then
-		pylama .
+		pylama --skip "$ignore" .
 		errors=$((errors + $?))
 	else
 		echo "pylama not found, unable to run linter"
@@ -104,7 +105,7 @@ if $typecheck; then
 	fi
 	heading "Checking types in $directory/"
 	if command -v mypy > /dev/null; then
-		mypy .
+		mypy --exclude "$ignore" .
 		errors=$((errors + $?))
 	else
 		echo "mypy not found, unable to check types"
diff --git a/dts/dpdk-devbind.py b/dts/dpdk-devbind.py
new file mode 120000
index 0000000000..9d042fad14
--- /dev/null
+++ b/dts/dpdk-devbind.py
@@ -0,0 +1 @@
+../usertools/dpdk-devbind.py
\ No newline at end of file
-- 
2.46.0


  reply	other threads:[~2024-09-24 16:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 17:22 [PATCH 0/1] dts: add driver binding on TG jspewock
2024-08-12 17:22 ` [PATCH 1/1] dts: add binding to different drivers to TG node jspewock
2024-08-12 17:49   ` Nicholas Pratte
2024-09-09 12:16   ` Juraj Linkeš
2024-09-09 15:55     ` Jeremy Spewock
2024-09-16 10:04       ` Juraj Linkeš
2024-09-18 18:50         ` Jeremy Spewock
2024-09-19  9:10           ` Juraj Linkeš
2024-09-12 13:00   ` Patrick Robb
2024-09-19 18:16 ` [PATCH v2 0/1] dts: add driver binding on TG jspewock
2024-09-19 18:16   ` [PATCH v2 1/1] dts: add binding to different drivers to TG node jspewock
2024-09-24  9:12     ` Juraj Linkeš
2024-09-24 13:57       ` Jeremy Spewock
2024-09-24 14:03         ` Juraj Linkeš
2024-09-24 16:28 ` [PATCH v3 0/2] dts: add driver binding on TG jspewock
2024-09-24 16:28   ` jspewock [this message]
2024-09-25  5:48     ` [PATCH v3 1/2] dts: add symbolic link to dpdk-devbind script Juraj Linkeš
2024-09-27 11:49     ` Luca Vizzarro
2024-09-24 16:28   ` [PATCH v3 2/2] dts: add binding to different drivers to TG node jspewock
2024-09-25  6:01     ` Juraj Linkeš
2024-09-27 11:50     ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240924162842.11714-2-jspewock@iol.unh.edu \
    --to=jspewock@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Luca.Vizzarro@arm.com \
    --cc=alex.chapman@arm.com \
    --cc=dev@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=npratte@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    --cc=wathsala.vithanage@arm.com \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).