From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH] net/r8169: add support for hw initialization
Date: Wed, 25 Sep 2024 08:16:57 -0700 [thread overview]
Message-ID: <20240925081657.0ac9f849@fedora> (raw)
In-Reply-To: <20240925075421.38142-1-howard_wang@realsil.com.cn>
On Wed, 25 Sep 2024 15:54:21 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:
> static int
> rtl_dev_close(struct rte_eth_dev *dev)
> {
> + //struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> + //struct rte_intr_handle *intr_handle = pci_dev->intr_handle;
No commented out code please.
As checkpatch warns, DPDK does not use C99 style comments.
next prev parent reply other threads:[~2024-09-25 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 7:54 Howard Wang
2024-09-25 15:16 ` Stephen Hemminger
2024-09-25 15:16 ` Stephen Hemminger [this message]
2024-09-25 15:17 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925081657.0ac9f849@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).