From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CE9645A2A; Wed, 25 Sep 2024 17:17:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C2024025D; Wed, 25 Sep 2024 17:17:02 +0200 (CEST) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by mails.dpdk.org (Postfix) with ESMTP id EC2D74025D for ; Wed, 25 Sep 2024 17:16:59 +0200 (CEST) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6c579748bf4so61396d6.1 for ; Wed, 25 Sep 2024 08:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727277419; x=1727882219; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=X8YzfmCf+xCUUeqZe0YeFc3e/xjhi6+MrtJ/q+KiI+M=; b=OC3ujvQW5XqvclTHAIB23VZmS5OuY4AJc760mQ605LOH9a1FVH2m5MbEZMqxf4lgCZ DCdkqPNPG4A3Ox4Yu4oSNQjBy41Tzhz1fow9PEXEJw31pi52RmFO1VrXn/YrAOgfPPn9 fxNjyJXt46ii6NcWVFcs6zdDZjkHJod1YzSe/dH8CmQoE6Y0Nt2xXTgnBeRcd8dNqgei kU0odm2c21XFuH/YvuA/+EdONp+n+sW9BJPBFUeLUBil2ysvNXQOxveq653bLKzVbSRk dTUN1ZPDJrbn3WUqzfXMHWjvh7dr72Y9BHmVfdCl6yAYuCx9sIWjGPZf+Fbizwcce9Y1 ixVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727277419; x=1727882219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X8YzfmCf+xCUUeqZe0YeFc3e/xjhi6+MrtJ/q+KiI+M=; b=SQeo6EMIiNIABp2q5kLVNlhEci9b4j7+VZjOl6fMEcEbhnfvRDCamoNgsfOvB5id8G 1eg/43fS6pbFdnOEiGs82zE2TLorf5u1jRadnIhkKmjM+rgKqG7HVSLq/z6M7o5EhQ/z ZpDdblUQdwB0UAz494yJEV1df/dBmM5sBCiVkf+wd7IFX9pVmjZUU28fmA6nOYm86MZF 16JgK+ao+Ox7ZvvPL11x/CJ3cQyERriOoyQXEi5D7lwJKiB68e/Lxdh9EC9mqOr/L9uN Z8sm6yxYYx0ZzUjz5tTAdVw698jVeE/irqm+cJeoZnzKcQZ5wy38nqKgzpn18bcPxIaG bpVw== X-Gm-Message-State: AOJu0YwTwpnpjP+DwHhkvVFMhyBZ/h60lSQ66Gc17trJbXjqjLPiKoVx T/g76XInukSClO3Tdf+w7WBhmLrP/NIoHoprNKhPnIga7Lkn15CaCIWsxS2YuNluWZdUCCvTQBf ngr0= X-Google-Smtp-Source: AGHT+IHQ66KHnzDl5BMktrn1uF7Ypaxdlw+3nAmct/g2wXGwBD31je1B22CBHnjYHC6DIzk65fbgEg== X-Received: by 2002:a05:6214:5884:b0:6cb:2ab7:fa24 with SMTP id 6a1803df08f44-6cb2ab80169mr15673846d6.34.1727277419212; Wed, 25 Sep 2024 08:16:59 -0700 (PDT) Received: from fedora ([173.242.185.50]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb0f78be9esm17048806d6.135.2024.09.25.08.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 08:16:59 -0700 (PDT) Date: Wed, 25 Sep 2024 08:16:57 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH] net/r8169: add support for hw initialization Message-ID: <20240925081657.0ac9f849@fedora> In-Reply-To: <20240925075421.38142-1-howard_wang@realsil.com.cn> References: <20240925075421.38142-1-howard_wang@realsil.com.cn> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 25 Sep 2024 15:54:21 +0800 Howard Wang wrote: > static int > rtl_dev_close(struct rte_eth_dev *dev) > { > + //struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev); > + //struct rte_intr_handle *intr_handle = pci_dev->intr_handle; No commented out code please. As checkpatch warns, DPDK does not use C99 style comments.