From: Stephen Hemminger <stephen@networkplumber.org>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH dpdk v2] mbuf: fix strict aliasing error in allocator
Date: Wed, 25 Sep 2024 08:47:41 -0700 [thread overview]
Message-ID: <20240925084741.60852bd6@fedora> (raw)
In-Reply-To: <20240925154053.80861-2-rjarry@redhat.com>
On Wed, 25 Sep 2024 11:40:54 -0400
Robin Jarry <rjarry@redhat.com> wrote:
> From: Robin Jarry <rjarry@redhat.com>
> To: dev@dpdk.org
> Subject: [PATCH dpdk v2] mbuf: fix strict aliasing error in allocator
> Date: Wed, 25 Sep 2024 11:40:54 -0400
>
> When building an application with -fstrict-aliasing -Wstrict-aliasing=2,
> we get errors triggered by rte_mbuf_raw_alloc() which is called inline
> from rte_pktmbuf_alloc().
>
> ../dpdk/lib/mbuf/rte_mbuf.h: In function ‘rte_mbuf_raw_alloc’:
> ../dpdk/lib/mbuf/rte_mbuf.h:600:42: error: dereferencing type-punned
> pointer might break strict-aliasing rules [-Werror=strict-aliasing]
> 600 | if (rte_mempool_get(mp, (void **)&m) < 0)
> | ^~
>
> Avoid incorrect casting by using an inline union variable.
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
Thanks, union is safer than cast.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-09-25 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 14:00 [PATCH dpdk] " Robin Jarry
2024-09-25 15:21 ` Morten Brørup
2024-09-25 15:23 ` Stephen Hemminger
2024-09-25 15:24 ` Robin Jarry
2024-09-25 15:40 ` [PATCH dpdk v2] " Robin Jarry
2024-09-25 15:47 ` Stephen Hemminger [this message]
2024-09-26 16:38 ` [PATCH dpdk] " Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925084741.60852bd6@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).