From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [PATCH v5 00/10] support reinit flow
Date: Wed, 25 Sep 2024 14:08:48 -0700 [thread overview]
Message-ID: <20240925140848.2e6b2aca@fedora> (raw)
In-Reply-To: <20230817042820.137957-1-okaya@kernel.org>
On Thu, 17 Aug 2023 00:28:11 -0400
okaya@kernel.org wrote:
> From: Sinan Kaya <okaya@kernel.org>
>
> We want to be able to call rte_eal_init() and rte_eal_cleanup()
> APIs back to back for maintanance reasons.
>
> Here is a summary of the code we have seen so far:
>
> 1. some code support getting called multiple times by keeping
> a static variable.
> 2. some code initializes once but never clean up after them and
> don't have a cleanup API.
> 3. some code assumes that they only get called once during the
> lifecycle of the process.
>
> Most changes in this patch center around following the #1 design
> principle.
>
> Why?
>
> It is not always ideal to reinitialize a DPDK process. Memory needs
> to be reinitialized, hugetables need to warm up etc.
>
> Limitations:
>
> This sequence could only be done by main lcore, and never ever in a signal handler.
> Do not try and trap signals like abort, bus error, illegal instruction and try to
> use this for recovery. It is a recipe for failure.
>
This patch series suffers bit rot and does not apply anymore. Needs to be rebase
and resubmit.
There probably needs to be more unit-tests for restart.
Also some documentation for example, for which NIC's does this work?
Probably not all.
prev parent reply other threads:[~2024-09-25 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 4:28 okaya
2023-08-17 4:28 ` [PATCH v5 01/10] eal: cleanup plugins data okaya
2023-08-17 4:28 ` [PATCH v5 02/10] eal: fixes for re-initialization issues okaya
2023-08-17 4:28 ` [PATCH v5 03/10] tailq: skip init if already initialized okaya
2023-08-17 4:28 ` [PATCH v5 04/10] eal_memzone: bail out on initialized okaya
2023-08-17 4:28 ` [PATCH v5 05/10] memseg: init once okaya
2023-08-17 4:28 ` [PATCH v5 06/10] eal_memory: skip initialization okaya
2023-08-17 4:28 ` [PATCH v5 07/10] eal_interrupts: don't reinitialize threads okaya
2023-08-17 4:28 ` [PATCH v5 08/10] eal: initialize worker threads once okaya
2023-08-17 4:28 ` [PATCH v5 09/10] eal: declare the reinit via cleanup/init feature unsupported okaya
2023-08-17 13:59 ` Stephen Hemminger
2024-09-25 21:08 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925140848.2e6b2aca@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).