From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC51F459FD; Fri, 27 Sep 2024 20:04:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9407540652; Fri, 27 Sep 2024 20:03:11 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 1EF9640609 for ; Fri, 27 Sep 2024 20:03:09 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2068a7c9286so26151315ad.1 for ; Fri, 27 Sep 2024 11:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1727460188; x=1728064988; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9YIL2S0KVY+pufIsnQ43hDpUs6eMSo0I8c3X8RTsx9g=; b=exrD9bxjpKaCdDPbvlOqaTEwSGJHD714FnT+LN5MUWIK7UfqeR5II4Zb4TJxl0tR7o 0Oir3SgIj4F5KWcZWE9yqPvfiRgE+pdPZvd7yrWOhwT5X+a6iIqi5IEKAw3eJMpHw7Ef Ju/00nB7IT2lm3dOzj/iF9av4A3wnRjWPr2Oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727460188; x=1728064988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9YIL2S0KVY+pufIsnQ43hDpUs6eMSo0I8c3X8RTsx9g=; b=gpd6vPvIhMFcOOyU1WO9qZA8KWhkEY6gSqAQdmCfvvQUcWV52EDhJiWPHhU35f0TJz eWuyoubpdM0T6MnUTXHwuUy5JoB7R5/KAQR32KTafBCzkVDcgCM6xYsQlBzRZLKt3xY3 SNHU8HIxavrWN9GL47d1qeUJ2hbQGjKlTdlbIa7V7H0EFNn/PYQuEA/vm8woiYHXa9CN NbzqvFy9S0KvQ6sSf4PALIL76r3KVCJolwJLL8+SFycIKR2BSmqLfrPoVE+tWiNcDPZF c1HldFO+tYT1B0G3xX6UUgNfIiQhvFBTHPUInjhNNo22Atxk/b1Jqj3OgNTNF27116tB df0A== X-Gm-Message-State: AOJu0Yyux8xFfIEqiQP59hJ5OS6H9cVYq47dPs8fA6znMVgxyhHaw6fE 7/D+5ovTvDwAhPhzWsqEciIuUGHhkRu7R2lh3Di3lQIEW9u9v5Sk15Hzw+K8CKwW8vmnZKvQdhP kL7yI7VzQSY/4OQP7kHmkSzswIcO+XFxnIKLMS8sxuZSbshYRrbV3YZtmaf++U4Hb1fYiHTHLK/ 0AN/qeC3SbmdA8BTw2hl9L2ureKZ99dRItOyeibJa4BA== X-Google-Smtp-Source: AGHT+IGu3LaV4GdsRPHs1dz1aeBaigwpFEQ7+xF9q4K7D/TYiMudK9BMaryr/QsaI7uxLRB6HbmrIg== X-Received: by 2002:a17:902:fc84:b0:20b:239b:929d with SMTP id d9443c01a7336-20b36cdcbc0mr69755125ad.7.1727460187674; Fri, 27 Sep 2024 11:03:07 -0700 (PDT) Received: from dhcp-10-123-154-23.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e4e4desm16198945ad.251.2024.09.27.11.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 11:03:07 -0700 (PDT) From: Sriharsha Basavapatna To: dev@dpdk.org Cc: Peter Spreadborough , Sriharsha Basavapatna , Kishore Padmanabha , Ajit Khaparde Subject: [PATCH v2 39/47] net/bnxt: tf_ulp: switch ulp to use rte crc32 hash Date: Fri, 27 Sep 2024 23:38:21 +0530 Message-Id: <20240927180829.525350-40-sriharsha.basavapatna@broadcom.com> X-Mailer: git-send-email 2.39.0.189.g4dbebc36b0 In-Reply-To: <20240927180829.525350-1-sriharsha.basavapatna@broadcom.com> References: <20240927180829.525350-1-sriharsha.basavapatna@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough The RTE hash is highly optimized and will use HW acceleration when available. Signed-off-by: Peter Spreadborough Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 4 ++++ drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c | 4 ++++ drivers/net/bnxt/tf_ulp/ulp_gen_hash.c | 28 ++++++++++++++++++++++---- 3 files changed, 32 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c index 99a6bac0ce..c591f9327c 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "bnxt.h" #include "bnxt_ulp.h" @@ -1457,6 +1458,9 @@ ulp_tf_init(struct bnxt *bp, int rc; uint32_t ulp_dev_id = BNXT_ULP_DEVICE_ID_LAST; + /* Select 64bit SSE4.2 intrinsic if available */ + rte_hash_crc_set_alg(CRC32_SSE42_x64); + /* Allocate and Initialize the ulp context. */ rc = ulp_tf_ctx_init(bp, session); if (rc) { diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c index 765ae9f6aa..e5bb24299e 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "bnxt.h" #include "bnxt_ulp.h" @@ -924,6 +925,9 @@ ulp_tfc_init(struct bnxt *bp, uint16_t sid; int rc; + /* Select 64bit SSE4.2 intrinsic if available */ + rte_hash_crc_set_alg(CRC32_SSE42_x64); + rc = bnxt_ulp_devid_get(bp, &ulp_dev_id); if (rc) { BNXT_DRV_DBG(ERR, "Unable to get device id from ulp.\n"); diff --git a/drivers/net/bnxt/tf_ulp/ulp_gen_hash.c b/drivers/net/bnxt/tf_ulp/ulp_gen_hash.c index 17bb9c6b32..7d68bfc778 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_gen_hash.c +++ b/drivers/net/bnxt/tf_ulp/ulp_gen_hash.c @@ -5,10 +5,10 @@ #include #include +#include #include "bnxt_tf_common.h" #include "ulp_gen_hash.h" #include "ulp_utils.h" -#include "tf_hash.h" static int32_t ulp_bit_alloc_list_alloc(struct bit_alloc_list *blist, @@ -203,8 +203,29 @@ ulp_gen_hash_tbl_list_key_search(struct ulp_gen_hash_tbl *hash_tbl, } /* calculate the hash */ - hash_id = tf_hash_calc_crc32(entry->key_data, - hash_tbl->key_tbl.data_size); + switch (hash_tbl->key_tbl.data_size) { + case 1: + hash_id = rte_hash_crc_1byte(*entry->key_data, + ~0U); + break; + case 2: + hash_id = rte_hash_crc_2byte(*((uint16_t *)entry->key_data), + ~0U); + break; + case 4: + hash_id = rte_hash_crc_4byte(*((uint32_t *)entry->key_data), + ~0U); + break; + case 8: + hash_id = rte_hash_crc_8byte(*((uint64_t *)entry->key_data), + ~0U); + break; + default: + hash_id = rte_hash_crc(entry->key_data, + hash_tbl->key_tbl.data_size, + ~0U); + break; + } hash_id = (uint16_t)(((hash_id >> 16) & 0xffff) ^ (hash_id & 0xffff)); hash_id &= hash_tbl->hash_mask; hash_id = hash_id * hash_tbl->hash_bkt_num; @@ -375,4 +396,3 @@ ulp_gen_hash_tbl_list_del(struct ulp_gen_hash_tbl *hash_tbl, return 0; } - -- 2.39.3