From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3663345A48; Fri, 27 Sep 2024 22:49:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B802C40669; Fri, 27 Sep 2024 22:48:12 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 7F6A040651 for ; Fri, 27 Sep 2024 22:48:05 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-20570b42f24so30368885ad.1 for ; Fri, 27 Sep 2024 13:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727470084; x=1728074884; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z4ivJFh4i+sS5Kt3NFIojkEwQfvp829B9cFV3HoaYyY=; b=ipLeYdzs6SBbaTy13UlqtNy3OWleMpjmFoFzHrTYrqSAPgQurh2z5FGckzi6wkw9br CMx8gLh21QZ1O6eic5vhE2FNzb7Uu2mM9ut34UTn+2KEvx5Lx8L/BrzyW65ofcj3K9cZ 1dILR5qO7346uCoJDOuXXgqE71fT7gkjdZKYXFgyxGVoZyxbMOhmy5HjZ5+iH1oRiGO1 z/6UAdUbCBmkAvgey3/Xwj77iI/S2z44eiYDkbqBhWf7pDuJmsrgDA0KLLCbT2V6a6WX Hbriidhlvt9WOxr/hRrpMeJp4dNmiY+lhI9CjCQLX800c1smRiq6QXfkts6z8bd4Xxdu fFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727470084; x=1728074884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z4ivJFh4i+sS5Kt3NFIojkEwQfvp829B9cFV3HoaYyY=; b=NNTGtNqSaY0/PkUEarZlJAfCq05+DLFmUH+grqU1x2jdvEHlgiYnIRMOlyuFSuRcgF LG6WcCG8RDgOIh6ZXfKGjmSbnHDgJ+Fjg1OMR54N3M8fnqDBBO0dz/7ho3pJjLCM+oYj /qvbIWgzlFtkDms6xuAyuLECWvMQtp243klcx86o1xYY5CDRz2EIwB1v5SMhIzHMyCwc q15IvpY7lGiqAzjcKcqwOZJ0wAn2b0F0TZtkKk6mniplKYOPoWerrpnNOs+tkkfKc+17 UjZvti0Bf0JH4LPyUh2aQEwnWq1ZMbV1Yp6Y709r2rYy97p2ZAm6pSIvJe3D5C+caTf6 mE/Q== X-Gm-Message-State: AOJu0Yy3EMKhzcIzK/3JSdb+K/IWwAsl2lJbEBRsiV9hRdbnHSGn0VsG 38SU48fGAcHgY9tB811Q4FIT4odbhXkGg99Bsi6bHorv83u6ZycABcgtS6bZXj7oT/qhKU2YMtV 7 X-Google-Smtp-Source: AGHT+IFMQtyYJr1UEgKSYTTelDH/ObgfDDU+WOWmgpyMOp4aYHOFI5Ir4USAVb09lA9X3WrEAQ0Npg== X-Received: by 2002:a05:6a20:2d20:b0:1d3:2922:2cad with SMTP id adf61e73a8af0-1d4fa78a4d3mr6612184637.34.1727470084513; Fri, 27 Sep 2024 13:48:04 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db294533sm2036531a12.12.2024.09.27.13.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 13:48:04 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , wei.zhao1@intel.com, stable@dpdk.org Subject: [PATCH 09/16] net/e1000: fix use-after-free Date: Fri, 27 Sep 2024 13:45:45 -0700 Message-ID: <20240927204742.546164-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240927204742.546164-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver cleanup code was freeing the filter object then dereferencing it. Bugzilla ID: 1550 Fixes: 6a4d050e2855 ("net/igb: flush all the filter") Cc: wei.zhao1@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 095be27b08..973d0d2407 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -3907,11 +3907,11 @@ igb_delete_2tuple_filter(struct rte_eth_dev *dev, filter_info->twotuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->twotuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_TTQF(filter->index), E1000_TTQF_DISABLE_MASK); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } @@ -4348,7 +4348,6 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, filter_info->fivetuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->fivetuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_FTQF(filter->index), E1000_FTQF_VF_BP | E1000_FTQF_MASK); @@ -4357,6 +4356,7 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, E1000_WRITE_REG(hw, E1000_SPQF(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } -- 2.45.2