From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 103B445A48; Fri, 27 Sep 2024 22:49:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43961406B4; Fri, 27 Sep 2024 22:48:14 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id AA34740616 for ; Fri, 27 Sep 2024 22:48:06 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7e6ba3f93fdso1655737a12.1 for ; Fri, 27 Sep 2024 13:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727470086; x=1728074886; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aIwRcdXEEaAbSiV8gAOvH2ZxU8+AoNggqgvuXg+vn2M=; b=zrhM4P3HVuWGpLk8KSQRcYh9LVhqOKuN8R70pVYd1q5fukBU7uhM/63mYUBpmLH8lA taQBWaRVJissXYM6dD9bTUUhjmx01FC/a2hVnCWZCDl7rX2NXhjqfFnaLhnlYDNMdj4Q lfWmoAhCfIA7RfV5iuPDnCiJaNzLM5kchVYtTpODLueOUZRp9iBefKGq78qE8slDUB+F CNUlCyd8XfULYH+nJq5/OGm73KPXHFSrzcQ5TQ2P59EfGtYDroBMQKVuNBjvAuZRmHNR zmaqOF7MODF2ri1XXnxhBP5MojYfLwG27Q7LCzWBHkDDm11sgFLw7Hnm0flvE8lQC/Cg +ZbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727470086; x=1728074886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aIwRcdXEEaAbSiV8gAOvH2ZxU8+AoNggqgvuXg+vn2M=; b=WxS76ueqwe/WSq2nGD5X5I1V/2Cg7M7fPGkU/Tm5HLx19fQ6+8gGDh/5KMzEHIs/z3 6B+MS38hEK+9IAgnpSRah+/IPghu0EFe2ETcSEEnlajiTTreQkJwiun4Hjzr+ecf4Qzc GXQimhXaloJyyu1fN6FA6Qckw4rpGnIRpCQ+fzR4fWN9+kmZ3M8HL3IGwtCw0JWb5SuU JzzQV76ONk+PAxe0Lbrd2TEqPYSXWq+CcM4NyS8SfwCazBa0urWLj4/1mfB0CixlG6/n XZ1Pvg0iNwtG6hdhBQCs2D5CJ+UaGsqWeTUmplK50j3FQwpp3AoIVQt88frUn1fEkx9g ClEA== X-Gm-Message-State: AOJu0YxZbqKxsCDaK0CfZ4i6US0Au42GBlE1S9UYO19/0icTQTIm9cL+ 9pjfdFrqodP3UC3LOQQ7y7aFWo7ktg2nA6T4fb7kwcmT8ctlXr8y30fABZHfrKMim1uE39JYenk a X-Google-Smtp-Source: AGHT+IGxzAga/xhDOPOGznjPsNKljttcSeW0VaZ10JbrLuzSiTC1oZPKv5vk2PV3vpy2It9lyeSTpQ== X-Received: by 2002:a05:6a20:c797:b0:1d2:e78a:36a2 with SMTP id adf61e73a8af0-1d4fa64d7acmr6081193637.8.1727470085804; Fri, 27 Sep 2024 13:48:05 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db294533sm2036531a12.12.2024.09.27.13.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 13:48:05 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ivan.malov@oktetlabs.ru, Andrew Rybchenko , Ivan Malov , Andy Moreton Subject: [PATCH 10/16] net/sfc: fix use-after-free warning messages Date: Fri, 27 Sep 2024 13:45:46 -0700 Message-ID: <20240927204742.546164-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240927204742.546164-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If compiler detection of use-after-free is enabled then this drivers debug messages will cause warnings. Change to move debug message before the object is freed. Bugzilla ID: 1551 Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows") Cc: ivan.malov@oktetlabs.ru Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_flow_rss.c | 4 ++-- drivers/net/sfc/sfc_mae.c | 23 +++++++++-------------- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/net/sfc/sfc_flow_rss.c b/drivers/net/sfc/sfc_flow_rss.c index e28c943335..8e2749833b 100644 --- a/drivers/net/sfc/sfc_flow_rss.c +++ b/drivers/net/sfc/sfc_flow_rss.c @@ -303,9 +303,9 @@ sfc_flow_rss_ctx_del(struct sfc_adapter *sa, struct sfc_flow_rss_ctx *ctx) TAILQ_REMOVE(&flow_rss->ctx_list, ctx, entries); rte_free(ctx->qid_offsets); - rte_free(ctx); - sfc_dbg(sa, "flow-rss: deleted ctx=%p", ctx); + + rte_free(ctx); } static int diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index 60ff6d2181..8f74f10390 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -400,9 +400,8 @@ sfc_mae_outer_rule_del(struct sfc_adapter *sa, efx_mae_match_spec_fini(sa->nic, rule->match_spec); TAILQ_REMOVE(&mae->outer_rules, rule, entries); - rte_free(rule); - sfc_dbg(sa, "deleted outer_rule=%p", rule); + rte_free(rule); } static int @@ -585,9 +584,8 @@ sfc_mae_mac_addr_del(struct sfc_adapter *sa, struct sfc_mae_mac_addr *mac_addr) } TAILQ_REMOVE(&mae->mac_addrs, mac_addr, entries); - rte_free(mac_addr); - sfc_dbg(sa, "deleted mac_addr=%p", mac_addr); + rte_free(mac_addr); } enum sfc_mae_mac_addr_type { @@ -785,10 +783,10 @@ sfc_mae_encap_header_del(struct sfc_adapter *sa, } TAILQ_REMOVE(&mae->encap_headers, encap_header, entries); + sfc_dbg(sa, "deleted encap_header=%p", encap_header); + rte_free(encap_header->buf); rte_free(encap_header); - - sfc_dbg(sa, "deleted encap_header=%p", encap_header); } static int @@ -983,9 +981,8 @@ sfc_mae_counter_del(struct sfc_adapter *sa, struct sfc_mae_counter *counter) } TAILQ_REMOVE(&mae->counters, counter, entries); - rte_free(counter); - sfc_dbg(sa, "deleted counter=%p", counter); + rte_free(counter); } static int @@ -1165,9 +1162,8 @@ sfc_mae_action_set_del(struct sfc_adapter *sa, sfc_mae_mac_addr_del(sa, action_set->src_mac_addr); sfc_mae_counter_del(sa, action_set->counter); TAILQ_REMOVE(&mae->action_sets, action_set, entries); - rte_free(action_set); - sfc_dbg(sa, "deleted action_set=%p", action_set); + rte_free(action_set); } static int @@ -1401,10 +1397,10 @@ sfc_mae_action_set_list_del(struct sfc_adapter *sa, sfc_mae_action_set_del(sa, action_set_list->action_sets[i]); TAILQ_REMOVE(&mae->action_set_lists, action_set_list, entries); + sfc_dbg(sa, "deleted action_set_list=%p", action_set_list); + rte_free(action_set_list->action_sets); rte_free(action_set_list); - - sfc_dbg(sa, "deleted action_set_list=%p", action_set_list); } static int @@ -1667,9 +1663,8 @@ sfc_mae_action_rule_del(struct sfc_adapter *sa, sfc_mae_outer_rule_del(sa, rule->outer_rule); TAILQ_REMOVE(&mae->action_rules, rule, entries); - rte_free(rule); - sfc_dbg(sa, "deleted action_rule=%p", rule); + rte_free(rule); } static int -- 2.45.2