From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5862545A48; Fri, 27 Sep 2024 22:49:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D109E40A8A; Fri, 27 Sep 2024 22:48:17 +0200 (CEST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 7CC1740663 for ; Fri, 27 Sep 2024 22:48:08 +0200 (CEST) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-71c5df16b10so719688b3a.0 for ; Fri, 27 Sep 2024 13:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727470087; x=1728074887; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=06J0UyE8Dnp7ti3PueEoXg75lBUxlkSP8fL1kmtEqoE=; b=PwLEdvNi+3F8hhDMvvspm5TlxwnsP2Slq3EBb+f1ZMpicg/kzN0gJ/oNicPFZbnAGG aUdm63Cjmz69DY7m1VWgsI6J3mGv1CkjvTSTfxbBShiO8em/F70bSjkQ21/5K3v1oH3o 7fMsX7j5td0nIb59R4ixd1SbQ68ktAGNmZY289XqAhwO8lgl20ACwUVzQz9vTcvGoluZ Is7THmbjXK9yfg3uozcVhwxYCazdmAW0TNlvapzMZV7N/Qk9bCozOS2bHyuT6kv2RKd+ s4YunFQz+M29qyDEpa6NaLW6OsxWXrVxh7Qw1PNIF7GI4pBuu/lOdnTsHLUlUOumYwu6 SVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727470087; x=1728074887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=06J0UyE8Dnp7ti3PueEoXg75lBUxlkSP8fL1kmtEqoE=; b=HlkkoisWCZhcXslyCk9T2ld8FALp9bW1Ed7i3GcU9T18EvXu/TxH2hqKwfqLgPGYNz p/5cPUiGNriby/AZyWikMdmzDibrAupw8nNKb9ELv7M33dDInv+uZ1EpWO/RqdeLqwiH GruRsMlgAp3Rab2cjoBmusf0vSQRa/Mhi+Arw5t688k8YOqOw/EbJ6IIw3cpNlhNE8vD aL4+EaeGAwahIIQeIB4NnqfZBiiXxsIPJrBukuz62tHYXCj1tEDxe8r4y6+j3xIGFg85 MkuiwD2RlILsGMao9qoNauzfRb7hu2b7hbJL3dpUZqtlPipxxxy9hIZiApFEXger+rfL 5zkA== X-Gm-Message-State: AOJu0Yz3m6v6khnAtGWw2rrjyszkARru3aPXrf6X5psISHEB5bl01VBJ PIkFsYyzaQ3ChvNkHX62CdJ4K1GWPiLnO8Z2xdO+1m0Os5F81U3rdfoC4xrQH0XEM2D1p0miiXy U X-Google-Smtp-Source: AGHT+IH5zzZxRhWvgSdadENHzoc6RNLfUH4nz9En4u27+UVrV9v+ZzwJPrmRg4zMnCNmcyiKbgvc/Q== X-Received: by 2002:a05:6a20:c704:b0:1cf:2988:c34c with SMTP id adf61e73a8af0-1d4fa6c77ecmr6635767637.22.1727470087706; Fri, 27 Sep 2024 13:48:07 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db294533sm2036531a12.12.2024.09.27.13.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 13:48:07 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , tianfei.zhang@intel.com, stable@dpdk.org, Rosen Xu , Andy Pei Subject: [PATCH 12/16] raw/ifpga/base: fix use after free Date: Fri, 27 Sep 2024 13:45:48 -0700 Message-ID: <20240927204742.546164-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240927204742.546164-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The TAILQ_FOREACH() macro would refer to info after it had been freed. Fix by introducing TAILQ_FOREACH_SAFE here. Fixes: 4a19f89104f8 ("raw/ifpga/base: support multiple cards") Cc: tianfei.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/base/opae_intel_max10.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c b/drivers/raw/ifpga/base/opae_intel_max10.c index dd97a5f9fd..d5a9ceb6e3 100644 --- a/drivers/raw/ifpga/base/opae_intel_max10.c +++ b/drivers/raw/ifpga/base/opae_intel_max10.c @@ -6,6 +6,13 @@ #include #include "opae_osdep.h" +#ifndef TAILQ_FOREACH_SAFE +#define TAILQ_FOREACH_SAFE(var, head, field, tvar) \ + for ((var) = TAILQ_FIRST((head)); \ + (var) && ((tvar) = TAILQ_NEXT((var), field), 1); \ + (var) = (tvar)) +#endif + int max10_sys_read(struct intel_max10_device *dev, unsigned int offset, unsigned int *val) { @@ -746,9 +753,9 @@ static int fdt_get_named_reg(const void *fdt, int node, const char *name, static void max10_sensor_uinit(struct intel_max10_device *dev) { - struct opae_sensor_info *info; + struct opae_sensor_info *info, *next; - TAILQ_FOREACH(info, &dev->opae_sensor_list, node) { + TAILQ_FOREACH_SAFE(info, &dev->opae_sensor_list, node, next) { TAILQ_REMOVE(&dev->opae_sensor_list, info, node); opae_free(info); } -- 2.45.2