From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D936B45A48; Fri, 27 Sep 2024 23:58:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5579540156; Fri, 27 Sep 2024 23:58:05 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 7531C40144 for ; Fri, 27 Sep 2024 23:58:04 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71c63a43146so286783b3a.3 for ; Fri, 27 Sep 2024 14:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727474283; x=1728079083; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=26OG243NS7hft6MhxJQN/XJG0OAqTbOMnzNR/wY+2yw=; b=WB3evEUkq4Fqx0i6TPJSSA0xFs3Gy08LS26eM6j3a+rAp8+IviDgkgIamyvDMZBorI KzHqntVIUEaD44S0Q7xX47xm2GOV6MoVTu5rCrI8s+BnwkQGkr8s66nqp4+hmpVdcpt+ uuIk62S+VVGW0XA/n/t3JM0vxiKF/wpHDMhhPPsynKPzIkkwpxuWd+MxGRGRP45ErSnR HLfw4p9nDhoK87HXYRlt66/sbkUD1MhlrfnmhKDvgU+cV9CfD3SC7Pu3kVXXP+1N3Xfu g/pYLnpu4CZRaKenEkXXgvmX/jFiMWRmmDPt9W3gV5aaMIEUl6YkYo7RIMpZclHtxdMw B+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727474283; x=1728079083; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=26OG243NS7hft6MhxJQN/XJG0OAqTbOMnzNR/wY+2yw=; b=oyohD5zo/ib5Hh6qR7iIUDnsuyuwNixQICIuSEg9W4o9bgXwCmjXdIdD0N3qJK13PK pCNXHmD3+DypJTlssCxTGTvn45hymgYCCDwgtBeX55NgspBr1K0NBxbcyJYmE8CdYzeW x+QRx2WPsTLVt7Y7BW1Ux35b+3nm1NJLb2pYD1/uen6aI6KhOlJnbE2nJ9iBzGQu5DhH jIRggsBCBt0vQl2LIC9v0zih0Hfoz9aPqrwXxPTX3T6boGX2I3l51tzy8jSWmFQTAZaW fwIwTUN0N3xOyMEZhvHfU/MDRB8RmPWMS7zFrwV+s50dcxiXJdL2G3RNwwnwerKcdbdl j/hg== X-Gm-Message-State: AOJu0YzfDyBfb81RJeWJ+V7ZTjRCohPM67lfcFzBol4+aMjQHZkawMQo yZxfJxtiv52ZaZ+05k3X6877OWJwkGPuwnE4wkxEc6u+XIeu8/VLvHjOf2mteRJMIh+GTqLkznY l X-Google-Smtp-Source: AGHT+IFC6y/zby+WRoxsV5TQNn7+Di5qWFFzXKU0pIj4CQfdTtwdTpPxL3CK0e4Nk0wXBRfm7kVF6A== X-Received: by 2002:a05:6a00:2d18:b0:706:6af8:e08a with SMTP id d2e1a72fcca58-71b25f00e5cmr7222995b3a.2.1727474283506; Fri, 27 Sep 2024 14:58:03 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b26538812sm2059794b3a.218.2024.09.27.14.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 14:58:03 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , chaoyong.he@corigine.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= Subject: [PATCH] net/nfp: fix duplicate call to rte_free Date: Fri, 27 Sep 2024 14:57:53 -0700 Message-ID: <20240927215753.606098-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Calling rte_free twice on same object will corrupt the heap. Warning is: In function 'nfp_pre_tun_table_check_del', inlined from 'nfp_flow_destroy' at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9: ../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry' used after 'rte_free' [-Werror=use-after-free] 3830 | rte_free(entry); | ^~~~~~~~~~~~~~~ ../drivers/net/nfp/flower/nfp_flower_flow.c:3825:9: note: call to 'rte_free' here 3825 | rte_free(entry); | ^~~~~~~~~~~~~~~ Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow action") Cc: chaoyong.he@corigine.com Signed-off-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_flower_flow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c index 0078455658..64a0062c8b 100644 --- a/drivers/net/nfp/flower/nfp_flower_flow.c +++ b/drivers/net/nfp/flower/nfp_flower_flow.c @@ -3822,7 +3822,6 @@ nfp_pre_tun_table_check_del(struct nfp_flower_representor *repr, goto free_entry; } - rte_free(entry); rte_free(find_entry); priv->pre_tun_cnt--; -- 2.45.2