From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CA54F45A55;
Sun, 29 Sep 2024 08:03:38 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 39F384060C;
Sun, 29 Sep 2024 08:03:22 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
by mails.dpdk.org (Postfix) with ESMTP id E265E4027F
for <dev@dpdk.org>; Sun, 29 Sep 2024 08:03:11 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.163.48])
by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XGYX51kKczFqmn;
Sun, 29 Sep 2024 14:02:45 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242])
by mail.maildlp.com (Postfix) with ESMTPS id E017C18009B;
Sun, 29 Sep 2024 14:03:10 +0800 (CST)
Received: from localhost.localdomain (10.28.79.22) by
kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Sun, 29 Sep 2024 14:03:10 +0800
From: Huisong Li <lihuisong@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<andrew.rybchenko@oktetlabs.ru>, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
CC: <dev@dpdk.org>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>,
<lihuisong@huawei.com>
Subject: [PATCH RESEND v7 5/5] app/testpmd: stop forwarding in new or destroy
event
Date: Sun, 29 Sep 2024 13:52:40 +0800
Message-ID: <20240929055241.29268-6-lihuisong@huawei.com>
X-Mailer: git-send-email 2.22.0
In-Reply-To: <20240929055241.29268-1-lihuisong@huawei.com>
References: <20220825024425.10534-1-lihuisong@huawei.com>
<20240929055241.29268-1-lihuisong@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.28.79.22]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
kwepemm600004.china.huawei.com (7.193.23.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
When testpmd receives the new or destroy event, the port related
information will be updated. Testpmd must stop packet forwarding
before updating the information to avoid some serious problems.
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
app/test-pmd/testpmd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 7aaf71f157..60e85ed067 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3965,6 +3965,8 @@ eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,
switch (type) {
case RTE_ETH_EVENT_NEW:
+ if (test_done == 0)
+ stop_packet_forwarding();
if (setup_on_probe_event)
setup_attached_port(port_id);
break;
@@ -3975,6 +3977,8 @@ eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,
"Could not set up deferred device removal\n");
break;
case RTE_ETH_EVENT_DESTROY:
+ if (test_done == 0)
+ stop_packet_forwarding();
ports[port_id].port_status = RTE_PORT_CLOSED;
printf("Port %u is closed\n", port_id);
if (rte_eal_alarm_set(100000, remove_invalid_ports_callback,
--
2.33.0