From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DD7045A6D; Mon, 30 Sep 2024 20:46:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF4964027D; Mon, 30 Sep 2024 20:46:11 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 0F77A4014F for ; Mon, 30 Sep 2024 20:46:10 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-718e285544fso3644798b3a.1 for ; Mon, 30 Sep 2024 11:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727721970; x=1728326770; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cm2gtyAqZz3EGk/OTptFy8cgF5k38n3LEFNsGm04QXU=; b=XKQ2SUeA/K5YDm5Lwi6hQfIvBsTgeROH0UzsFzFlQ9dfOQGSThgCq9spbaIPc7nS1e fx/9cCNTYKGP/FosMmt7ZZxq08nUvuUrO44sQCdO7AcmfdOEXlA4onqaMvFSajujw/Cr uqhALNmkHg6mO2eBGGtM3qHau0wxfWXY+IkztbuGI8yk4R3ZZTwpGvxNof+5BV5dMim7 cimbVT4a/4rbIrt8zzB9X9EAg9pJMqtl4Zid2i5dJGfNkR0MkGINULEIGti6EVkUoNMc rSp/YzfH7Mb6cnl31mmWQE7FzZ+ejNP/36perJoBQuwSxVZ8nsB1zeiRXB+W9DAlQ06e kDcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727721970; x=1728326770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cm2gtyAqZz3EGk/OTptFy8cgF5k38n3LEFNsGm04QXU=; b=eFy9GXvsSNrX7Wm2fuKAXzhJi3hVFzuw1A7g9f3lN28Ml7StPR6HlSAUkd9LMX4fGC ps9z/fpfllUvRgzJ08Rkyn8GXkB9R9J+4BsP8pNBnRRQyE/dW+pQOI6eBnFhgdWx8ril NgiCfYo+LvShVdACIF1MtqOzCXR89JNa4HLRp5B6VUdIhuOPu5N0o+8BEHe2JZR8ltS5 QhFYj+6PVugF6CFP74PQCD8730mPA2FaZxSL+MxLKOxL/XKSBuZ8aLvP7BUvWRVuDc6a RwhqRN0b2/HGOQqy5xeQqRz8slNKDOVHD7YkxpfW4HSt8nzfwl53gWp8C0P8caCHGt4S Zt6Q== X-Gm-Message-State: AOJu0YyPWEsTRXpKKzJiahJYvV8c4OmarVuA8edYRyTzsBOscgp5N7w+ fG7iiB3vWHV7sNvtiO0K/ulKlZre6TzZO5bC6WXh/Rv126Pmxda9QrZ2gtE3aA7f4Oku5Cq2t7e dvmxrKg== X-Google-Smtp-Source: AGHT+IGow/FHjVPtMoMzJ3S2zsN2v/iIEMqPhz3CE6J4hh4P0bJ2qR2pJwyU6LJSVEZyUdwZvCYBGw== X-Received: by 2002:a05:6a00:178d:b0:714:1a74:9953 with SMTP id d2e1a72fcca58-71b25f6ef48mr19822918b3a.16.1727721969918; Mon, 30 Sep 2024 11:46:09 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264bcca6sm6581895b3a.78.2024.09.30.11.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 11:46:09 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v4 00/17] Fix allocation bugs and hardening for rte_malloc Date: Mon, 30 Sep 2024 11:43:54 -0700 Message-ID: <20240930184600.7092-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240927204742.546164-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recent versions of GCC have some additional function attributes that can help with DPDK performance and stability. The alloc_align attribute tells the compiler what the alignment of the allocation will be, and the optimizer can use this to produce better code (especially memcpy and structure copies). The malloc attribute tells compiler that object is not overlapping and potentially aliasing. It also as an additional variant in GCC 11 or later that allows for detecting all sorts of common errors like calling free() on memory allocated with rte_malloc(). In order to use the malloc attribute the free function prototype needs to be moved before the allocator/create function prototype so that the malloc attribute can refer to it. This uncovered at least 16 pre-existing bugs in DPDK, these should go to stable. This patch set is structured with: - fix any new warnings that were discovered - add macros for enable the macros - enable the attributes The same attributes could be added to lots more functions in DPDK, but this patch set focuses on the key ones, and where problems exist in current code base. v4 - rename the malloc attributes to align with what glibc uses in cdefs.h combine the attribute and rte_malloc patches Stephen Hemminger (17): memzone: fix use after free in tracing cryptodev/bcmfs: fix mis-matched free dma/ixd: fix incorrect free function in cleanup event/cnxk: fix pointer mismatch in cleanup examples/vhost: fix free function mismatch net/cnxk: fix use-after-free bpf: fix free mismatch if convert fails net/e1000: fix use-after-free net/sfc: fix use-after-free warning messages net/cpfl: fix free of nonheap object net/nfp: fix duplicate call to rte_free raw/ifpga/base: fix use after free common/qat: fix use after free drivers/ifpga: fix free function mismatch baseband/la12xx: prevent use after free common/idpf: fix use after free due eal: add function attributes for allocation functions doc/guides/rel_notes/release_24_11.rst | 8 ++++ drivers/baseband/la12xx/bbdev_la12xx.c | 1 + drivers/common/idpf/base/idpf_osdep.h | 10 ++++- drivers/common/idpf/idpf_common_device.c | 3 +- drivers/common/qat/qat_device.c | 6 +-- drivers/crypto/bcmfs/bcmfs_device.c | 4 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/event/cnxk/cnxk_eventdev.c | 4 +- drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +- drivers/net/cpfl/cpfl_flow_parser.c | 1 - drivers/net/e1000/igb_ethdev.c | 4 +- drivers/net/nfp/flower/nfp_flower_flow.c | 1 - drivers/net/sfc/sfc_flow_rss.c | 4 +- drivers/net/sfc/sfc_mae.c | 23 ++++------ drivers/raw/ifpga/base/opae_intel_max10.c | 11 ++++- drivers/raw/ifpga/ifpga_rawdev.c | 8 ++-- examples/vhost_blk/vhost_blk.c | 2 +- lib/bpf/bpf_convert.c | 2 +- lib/eal/common/eal_common_memzone.c | 3 +- lib/eal/include/rte_common.h | 36 +++++++++++++++ lib/eal/include/rte_malloc.h | 55 +++++++++++++---------- 21 files changed, 124 insertions(+), 66 deletions(-) -- 2.45.2