From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1607245A6D;
Mon, 30 Sep 2024 20:47:10 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D830340A6C;
Mon, 30 Sep 2024 20:46:27 +0200 (CEST)
Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com
[209.85.210.44]) by mails.dpdk.org (Postfix) with ESMTP id B4E6440662
for <dev@dpdk.org>; Mon, 30 Sep 2024 20:46:18 +0200 (CEST)
Received: by mail-ot1-f44.google.com with SMTP id
46e09a7af769-7093997dffdso1062066a34.2
for <dev@dpdk.org>; Mon, 30 Sep 2024 11:46:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727721978;
x=1728326778; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=NIKMlyZ2ZqwKuu4XJ9qGt7h821Tno22ntchYBoMYUOs=;
b=g0SfPPUz3P6u3girpy8gf0RHm/yRY1Nhx6qtEt6bayZDRICHPgaJxTMDAkDzJyr9RM
SHi3mgezquONg2xCN8ojgMxx3P9Me1iaLbAks4e313ZM2897OKcIhI3sauaI+B4CMxRt
Q1JmedmTJXMQ71aaSfCf0UgZhu6zqPa4/UTE/hZtM4OSCmD1TUPrQR2worFqWJxwg0w1
pvFoWG3fcDq18XfE0mhLuHE85wVBALLHMrUolTL1MD8KKsjpDyOrSYvB4tD9URTi4qVp
9YUiXJSd8MFEmXJj80fTb/nVlWfLPrIK8fAx+KJzfQ15pINDtkDv/JvmUNa/sWVJvx1F
obzg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1727721978; x=1728326778;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=NIKMlyZ2ZqwKuu4XJ9qGt7h821Tno22ntchYBoMYUOs=;
b=U/cVmXY048QkoSEWMKRq6/PeSqIa9Yp5OYejFRBc/FHzDcq6mAfN37yUQleQQX+DTI
FeNopWR9sW27B+zzL5DONXGYn3abqSDqgpzaZcDvgDfVmmBIHpQrDyqCXzBKFze9WMI0
h3JRRSZCug4vLNSdZpglT67olp67xtUu+jK7S5fXIxw7rqrYxFZFPXsbuR3MTEATMbOz
HFmy3YtnoGPD1g/4ISFrwAqxCpdYxks+fMjRZ1IGv6HsHlYimVwwhaAsEsrqfBRh8Rcg
v+lcXvREGGzOWmTf6H2phU0adLSkahARLqIzdiEa8CC3/peuCmeMj7YMideSYhbk6HVZ
s5Zg==
X-Gm-Message-State: AOJu0YzVGU0XpQHfgPsV9oY6fDVCYJFMH5Sy7mhgQ7JkLVVanvJe/vUj
Q3lQEp2Ovw+p6ulvSrN5UZfvj1Yr/+9mT1oWWyOSmlqdTvM9F1mBpgF51FMeqjsgdlN1s5Uu4G5
P29dc0Q==
X-Google-Smtp-Source: AGHT+IHWlZNsus6v0X+Xibb/DkIYlJjDN2k74YW0TETiurXprGzWOivBXT65TvlxiT+mXX/CsCTu8A==
X-Received: by 2002:a05:6808:13c6:b0:3e0:7d53:251 with SMTP id
5614622812f47-3e39396160emr7999690b6e.15.1727721977847;
Mon, 30 Sep 2024 11:46:17 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-71b264bcca6sm6581895b3a.78.2024.09.30.11.46.17
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 30 Sep 2024 11:46:17 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Ivan Malov <ivan.malov@arknetworks.am>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Andy Moreton <amoreton@xilinx.com>
Subject: [PATCH v4 09/17] net/sfc: fix use-after-free warning messages
Date: Mon, 30 Sep 2024 11:44:03 -0700
Message-ID: <20240930184600.7092-10-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20240930184600.7092-1-stephen@networkplumber.org>
References: <20240927204742.546164-1-stephen@networkplumber.org>
<20240930184600.7092-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
If compiler detection of use-after-free is enabled then this drivers
debug messages will cause warnings. Change to move debug message
before the object is freed.
Bugzilla ID: 1551
Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ivan Malov <ivan.malov@arknetworks.am>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
drivers/net/sfc/sfc_flow_rss.c | 4 ++--
drivers/net/sfc/sfc_mae.c | 23 +++++++++--------------
2 files changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/net/sfc/sfc_flow_rss.c b/drivers/net/sfc/sfc_flow_rss.c
index e28c943335..8e2749833b 100644
--- a/drivers/net/sfc/sfc_flow_rss.c
+++ b/drivers/net/sfc/sfc_flow_rss.c
@@ -303,9 +303,9 @@ sfc_flow_rss_ctx_del(struct sfc_adapter *sa, struct sfc_flow_rss_ctx *ctx)
TAILQ_REMOVE(&flow_rss->ctx_list, ctx, entries);
rte_free(ctx->qid_offsets);
- rte_free(ctx);
-
sfc_dbg(sa, "flow-rss: deleted ctx=%p", ctx);
+
+ rte_free(ctx);
}
static int
diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c
index 60ff6d2181..8f74f10390 100644
--- a/drivers/net/sfc/sfc_mae.c
+++ b/drivers/net/sfc/sfc_mae.c
@@ -400,9 +400,8 @@ sfc_mae_outer_rule_del(struct sfc_adapter *sa,
efx_mae_match_spec_fini(sa->nic, rule->match_spec);
TAILQ_REMOVE(&mae->outer_rules, rule, entries);
- rte_free(rule);
-
sfc_dbg(sa, "deleted outer_rule=%p", rule);
+ rte_free(rule);
}
static int
@@ -585,9 +584,8 @@ sfc_mae_mac_addr_del(struct sfc_adapter *sa, struct sfc_mae_mac_addr *mac_addr)
}
TAILQ_REMOVE(&mae->mac_addrs, mac_addr, entries);
- rte_free(mac_addr);
-
sfc_dbg(sa, "deleted mac_addr=%p", mac_addr);
+ rte_free(mac_addr);
}
enum sfc_mae_mac_addr_type {
@@ -785,10 +783,10 @@ sfc_mae_encap_header_del(struct sfc_adapter *sa,
}
TAILQ_REMOVE(&mae->encap_headers, encap_header, entries);
+ sfc_dbg(sa, "deleted encap_header=%p", encap_header);
+
rte_free(encap_header->buf);
rte_free(encap_header);
-
- sfc_dbg(sa, "deleted encap_header=%p", encap_header);
}
static int
@@ -983,9 +981,8 @@ sfc_mae_counter_del(struct sfc_adapter *sa, struct sfc_mae_counter *counter)
}
TAILQ_REMOVE(&mae->counters, counter, entries);
- rte_free(counter);
-
sfc_dbg(sa, "deleted counter=%p", counter);
+ rte_free(counter);
}
static int
@@ -1165,9 +1162,8 @@ sfc_mae_action_set_del(struct sfc_adapter *sa,
sfc_mae_mac_addr_del(sa, action_set->src_mac_addr);
sfc_mae_counter_del(sa, action_set->counter);
TAILQ_REMOVE(&mae->action_sets, action_set, entries);
- rte_free(action_set);
-
sfc_dbg(sa, "deleted action_set=%p", action_set);
+ rte_free(action_set);
}
static int
@@ -1401,10 +1397,10 @@ sfc_mae_action_set_list_del(struct sfc_adapter *sa,
sfc_mae_action_set_del(sa, action_set_list->action_sets[i]);
TAILQ_REMOVE(&mae->action_set_lists, action_set_list, entries);
+ sfc_dbg(sa, "deleted action_set_list=%p", action_set_list);
+
rte_free(action_set_list->action_sets);
rte_free(action_set_list);
-
- sfc_dbg(sa, "deleted action_set_list=%p", action_set_list);
}
static int
@@ -1667,9 +1663,8 @@ sfc_mae_action_rule_del(struct sfc_adapter *sa,
sfc_mae_outer_rule_del(sa, rule->outer_rule);
TAILQ_REMOVE(&mae->action_rules, rule, entries);
- rte_free(rule);
-
sfc_dbg(sa, "deleted action_rule=%p", rule);
+ rte_free(rule);
}
static int
--
2.45.2