From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56B4D45A6D; Mon, 30 Sep 2024 20:46:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BC344066E; Mon, 30 Sep 2024 20:46:19 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 34FB8402BE for ; Mon, 30 Sep 2024 20:46:14 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7c3e1081804so2094845a12.3 for ; Mon, 30 Sep 2024 11:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727721973; x=1728326773; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v8Aok7msKv3e47qbX+0n/i5gaFzOgWTvqMZUsJlTOls=; b=EUwQ9pm1kQLy4Mh4cBn/W+2z+ynZcZEVPsaXv3FBflz6TUsGYgJV5dF5MOyIUsPlhx V3oHeefs2BpELtY5/bEyI1KCyzHWsHRz5HMgEExrU5CtEpwihGlXZcxIDmxial9/8QNr OMkv9XeAYEINrv0jD7PgceErjG3d22pixD+6npilijxLh+VVuikou9nApwuKLm3Q4aF3 NfEtRTWlMHP+NgbNYfhnkR0ofTnN61uX+SsPF3LP1NF+n4E3DcVc8bBYzhCwWBu4t2P3 M2MXTOCXnnhW3BP1M6p8Y6jHZq+gx15kjzFLzQ12iuCGJaAecQh6Q2sQOWIEdGX7F9vN 5CvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727721973; x=1728326773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8Aok7msKv3e47qbX+0n/i5gaFzOgWTvqMZUsJlTOls=; b=vP8//cBibkdMGyleaHltS7DPlcx4lMsdaqEoqc6slnhmWe3Mna/u3VU52hIv9HwQ94 ovkfoMbjgY2uZhSCn/SRI0gPd3SDteDyJtnXmILsU8NIhuF/nSUOvUQceU34g0qvwUj6 9H1jUpltXfdJpvcsPrLl4q/M/qdAooCZ/+vZuUX+ZzT3tMOqW7w4PFGJHqDd6cO2tZPS IGmgl9R9yni+Dyd4eQmWxyfC11lwBdV+abhUyoOcbDLXWDPisgM3ttmBXtkXBMiBrAuS Qop6soDvVywIAj407Oj7lUvUPAzr5sJVl73YnfnrnccA9BpQgA6YsixbglzeX8U+hdGb R61Q== X-Gm-Message-State: AOJu0YxGXijAtJGunu4VF7NvO4c9eZVNVLyhCdE+0cMMPuAqmUamRf+I EozgQ0VWmOo2fDNzDcL2kGgV7toEwKq157ce55CeM/13Wzr280F/tLoVzskJwdVJoMKNbovyhI1 KLFDd+w== X-Google-Smtp-Source: AGHT+IHYfHFYsyaXRilGs0TgiC88PgocRljLlHZwtNAUD+TFqWjYoAGg3cEZjInoxd2uEBCnLN7L0A== X-Received: by 2002:a05:6a21:6b0b:b0:1cc:e409:7d0c with SMTP id adf61e73a8af0-1d4fa6bf662mr20864119637.25.1727721973384; Mon, 30 Sep 2024 11:46:13 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264bcca6sm6581895b3a.78.2024.09.30.11.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 11:46:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , sthotton@marvell.com, stable@dpdk.org, Pavan Nikhilesh Subject: [PATCH v4 04/17] event/cnxk: fix pointer mismatch in cleanup Date: Mon, 30 Sep 2024 11:43:58 -0700 Message-ID: <20240930184600.7092-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240930184600.7092-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20240930184600.7092-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The code to cleanup in case of error was passing incorrect value to rte_free. The ports[] entry was allocated with rte_malloc and that should be used instead of the offset in that object. Fixes: 97a05c1fe634 ("event/cnxk: add port config") Cc: sthotton@marvell.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/event/cnxk/cnxk_eventdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c index 4b2d6bffa6..08c6ce0c07 100644 --- a/drivers/event/cnxk/cnxk_eventdev.c +++ b/drivers/event/cnxk/cnxk_eventdev.c @@ -121,8 +121,10 @@ cnxk_setup_event_ports(const struct rte_eventdev *event_dev, return 0; hws_fini: for (i = i - 1; i >= 0; i--) { + void *ws = event_dev->data->ports[i]; + event_dev->data->ports[i] = NULL; - rte_free(cnxk_sso_hws_get_cookie(event_dev->data->ports[i])); + rte_free(ws); } return -ENOMEM; } -- 2.45.2