From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E84E945A6D; Mon, 30 Sep 2024 20:47:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 348BE40A71; Mon, 30 Sep 2024 20:46:26 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id C7DEE40661 for ; Mon, 30 Sep 2024 20:46:17 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-718e285544fso3644880b3a.1 for ; Mon, 30 Sep 2024 11:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727721977; x=1728326777; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tvq5E5KXslKNmPC408QbgP3MTNkCviUF5WUYmeRxPkg=; b=e/Mtn4CMPBKfoy3iyH+/DjZ2/rjFOwCr9suysXImYNnfucEV6B+FLiG+w4Q+MzZDzB ICqsOYRSSnj09IiJLcPDhhcfT1gABkD1fTgKj8hhut47wwZkrMTyT8yY1FyOHX17vOcQ jXG8ovIM0r3OUkHHGlLz3N01IafIkmQ/ROM9gXb10/gOFX5OetHv8fleqT/3egoupPWC t3DYU8Rqc5IaaMmi4Uy4gk1rer4Q5VqdU2FXjwYMAyx69nJkVv9+iMb8HJ/8Zwo226iO 0vEinxEk9vGXn4P4pD+BpMGljIJL9tEUSkbNEb9MhygL3J7GUOiN0IHUYLc04luwsGaA crAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727721977; x=1728326777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tvq5E5KXslKNmPC408QbgP3MTNkCviUF5WUYmeRxPkg=; b=ifW9pQ+zwcu9CJp7RIuy4VzhSI5n3cqTe1l+EwR37ad5u71/CH9AbgrDYm7YQMzYnv GiQo//fyKEZoavN7Qs2DoaOIO77Y6T+pEk0hS1JgMNKRH0GSrT5EsrztQdncKkDmjXO4 OzcmY1FwJlnd7R4BJZ/BTol9TC3MfoAVClbPs2I85jjiOtqlY4s2oFul9XLgWSKs1I3S zFg7yL7uUT9+q5r6eH9aSEM+G7UlRAO8c1eNWXRY5ecS2bjARv3XUDxehrWsJeFBog8I TE2q+6KLqHu7NIkAiYFu6kSb2ZVLTEpnkFIvPBG6aytTkXD+++lY6R9LnWEtwZdBQYzE LwHw== X-Gm-Message-State: AOJu0YzXggSFpzPHcqQb081WHpgBO7xwgyBr4KialCyeI/adez/JFmqy ANAkAdZVB80M2VS50evXWlhBcu3S5GENfkRSwGTcHeXjFsrharaQESi1bDpuGLICkISXeFMxvDJ eP39m0A== X-Google-Smtp-Source: AGHT+IHbul6d0Ad1NiaPqPz/Ssf4MX0+yh++Jh6G+K72VFC+YMzWwISJ/3i/SWLJFxAaR6BfqthSFg== X-Received: by 2002:a05:6a21:1519:b0:1d2:e807:b5b3 with SMTP id adf61e73a8af0-1d4fa63ab10mr16832086637.8.1727721977019; Mon, 30 Sep 2024 11:46:17 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264bcca6sm6581895b3a.78.2024.09.30.11.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 11:46:16 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Wei Zhao Subject: [PATCH v4 08/17] net/e1000: fix use-after-free Date: Mon, 30 Sep 2024 11:44:02 -0700 Message-ID: <20240930184600.7092-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240930184600.7092-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20240930184600.7092-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver cleanup code was freeing the filter object then dereferencing it. Bugzilla ID: 1550 Fixes: 6a4d050e2855 ("net/igb: flush all the filter") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 095be27b08..973d0d2407 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -3907,11 +3907,11 @@ igb_delete_2tuple_filter(struct rte_eth_dev *dev, filter_info->twotuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->twotuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_TTQF(filter->index), E1000_TTQF_DISABLE_MASK); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } @@ -4348,7 +4348,6 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, filter_info->fivetuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->fivetuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_FTQF(filter->index), E1000_FTQF_VF_BP | E1000_FTQF_MASK); @@ -4357,6 +4356,7 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, E1000_WRITE_REG(hw, E1000_SPQF(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } -- 2.45.2