From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06C4845A76; Tue, 1 Oct 2024 07:50:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26DF24066F; Tue, 1 Oct 2024 07:49:31 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 64C1840662 for ; Tue, 1 Oct 2024 07:49:29 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-718e2855479so3657538b3a.1 for ; Mon, 30 Sep 2024 22:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1727761768; x=1728366568; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PjItn4UKNh32h4VjxiwoHdLhBhYvtTxKRydk1cNjExQ=; b=BYAQ4uzi9BS19KFI6tBuUYIJPSnREXfBdQ+WesavGxX3LqqQQUSdtvtw1/ifR1MdLH 39AgNtQNn7H0DY0blbwpTHMH62hGR2FGbSa0/VlCvJdc+cpf0/VjREMOyfTmAU/knHns Ttg2xtet9a/gTZ6X5095JxH7/GeNsJVDobaDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727761768; x=1728366568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PjItn4UKNh32h4VjxiwoHdLhBhYvtTxKRydk1cNjExQ=; b=vIS1NUgOr0dNq7cA0IxbyjaGi2w8CApQYg7a+VBb/uERjqtSVwTVS4oghfUGEDehnz QGezlbWDq62+htVKArSd1gh/vcW8RQmQ6MvDvFhky/EdmdwalG2jxoloucR7/9BvqLaA zBJprTfGEM32Ekk5Q71Y/AjHAITac/buB7dTg08HTPjHlbuTZLo7pYXtHMMnkPiL3lVW dWy7ccBO753GqQT4i4QNYnk0DeRdURS7NSm7B7VO6ORdEgoefytXLvS9jDZKTWtRa0Bs tyVu/7Ag5AW0ekLVs6X8N9lbUKDtUH3KWsNm1r17EwLYXUeA/A9N+CcmQ8ZPIL0GVg6D 0aSA== X-Gm-Message-State: AOJu0Yy51dtZYrFIvc0hRJImLedDZ1tJS2+3WLMA2cBWKFQjkAXRYqFg nt2TCANClvFO2IETVoY+lR7eSy6r5rxF+8AJLADl6hNaBKF11qcaE9PBNcb9u7gyMMMTTqIOwWO QfxgEusZiZ90iRJ1PVBNkeJMyteGC0Q8CF1YuwNfT3l80UPre0PHyOXacuEgF/XgPKzZLy6/gCz +td6rZHB0VFKycfQ21W/MpkygtmvW3GV4+J/sA3mZTeg== X-Google-Smtp-Source: AGHT+IHCCEGU33lZYK3kfhJ+Q9g0vaUlvuo0w+IVRnWwazhDcXyFnxGzzIKio3+rMPUk9wAIJ7BCug== X-Received: by 2002:a05:6a20:4993:b0:1d4:fd51:546f with SMTP id adf61e73a8af0-1d4fd5160c7mr15968827637.1.1727761768018; Mon, 30 Sep 2024 22:49:28 -0700 (PDT) Received: from dhcp-10-123-154-23.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db2c8af2sm7513792a12.48.2024.09.30.22.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 22:49:27 -0700 (PDT) From: Sriharsha Basavapatna To: dev@dpdk.org Cc: Sangtani Parag Satishbhai , Sriharsha Basavapatna , Ajit Khaparde Subject: [PATCH v3 07/47] net/bnxt: tf_core: fix slice count in case of HA entry move Date: Tue, 1 Oct 2024 11:27:53 +0530 Message-Id: <20241001055833.757163-8-sriharsha.basavapatna@broadcom.com> X-Mailer: git-send-email 2.39.0.189.g4dbebc36b0 In-Reply-To: <20241001055833.757163-1-sriharsha.basavapatna@broadcom.com> References: <20241001055833.757163-1-sriharsha.basavapatna@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sangtani Parag Satishbhai When entries are moved during HA, a shared move function transfers TCAM entries by using get/set message APIs, and the slice number of the entry is required to accomplish the movement. The slice number is calculated as the product of row_slice and entry size. Before calling get/set message APIs, the source entry size should be updated with the destination entry size; otherwise, it might corrupt the slice number field, which may result in writing an incorrect entry. A fix is made which now copies the entry size from the source to the destination before calling get/set message APIs, ensuring the correct slice number is modified. Signed-off-by: Sangtani Parag Satishbhai Reviewed-by: Sriharsha Basavapatna Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_tcam_mgr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c b/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c index 349f52caba..33b1e4121e 100644 --- a/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c +++ b/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c @@ -1717,6 +1717,11 @@ cfa_tcam_mgr_shared_entry_move(int sess_idx, struct cfa_tcam_mgr_context *contex uint8_t key[CFA_TCAM_MGR_MAX_KEY_SIZE]; uint8_t mask[CFA_TCAM_MGR_MAX_KEY_SIZE]; uint8_t result[CFA_TCAM_MGR_MAX_KEY_SIZE]; + /* + * Copy entry size before moving else if + * slice number is non zero and entry size is zero it will cause issues + */ + dst_row->entry_size = src_row->entry_size; int rc; @@ -1791,7 +1796,6 @@ cfa_tcam_mgr_shared_entry_move(int sess_idx, struct cfa_tcam_mgr_context *contex ROW_ENTRY_SET(dst_row, dst_row_slice); dst_row->entries[dst_row_slice] = entry_id; - dst_row->entry_size = src_row->entry_size; dst_row->priority = src_row->priority; ROW_ENTRY_CLEAR(src_row, entry->slice); entry->row = dst_row_index; -- 2.39.3