From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A3BB045A7B;
	Tue,  1 Oct 2024 17:35:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 71069402A7;
	Tue,  1 Oct 2024 17:35:44 +0200 (CEST)
Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com
 [209.85.214.175])
 by mails.dpdk.org (Postfix) with ESMTP id 8E18340299
 for <dev@dpdk.org>; Tue,  1 Oct 2024 17:35:43 +0200 (CEST)
Received: by mail-pl1-f175.google.com with SMTP id
 d9443c01a7336-20b93887decso19150305ad.3
 for <dev@dpdk.org>; Tue, 01 Oct 2024 08:35:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727796943;
 x=1728401743; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=mMOsAlVU2HGjszGjl7C65sZROKm0P5DMCrs1BegPDH0=;
 b=SXgiJwSYWDmJu1cgG2M5AqiRKVA4sc5Ez90lE304g7pnIyKW7Cy1ZkpncgOQnGhFFG
 UM0GGSxe/y9svupIBIWg6e0WiMGjt3N3EFGYo9KaFz6sogRVBI9r9Aop3GZcnzuqUjeO
 UFLmOafBglaFhcDWZSSWBCfzBK92Qpqi04EuA+z63304KJGT3LRANQp+3MTE2jO7UVNv
 VjJ1mr9Ko9zApoi4mNDPKGIm4N1eGxuWUgpd67cWiExfT/zJZJU+aDMh531MQ3vcIR7z
 69ktPSZUhvRfdsdnQBmxz5+hDCg8wD26YZtS+krxKzYfXj9hLgvS5PMkqISWn7FOpEKq
 Nd9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1727796943; x=1728401743;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=mMOsAlVU2HGjszGjl7C65sZROKm0P5DMCrs1BegPDH0=;
 b=Y3HiB3aAGmS6eqOtWM0+3SvBtNIMFXtPYbUKohDWO15Geq7zVJ5J2pOyiGBHIseCFf
 fMm8eRXhvuIXp2f/qJmZ9Rdaq3yXlwJErby0s84wKHcraGb3432BvKeglR2pOoW2B47q
 /c9awRvEry8lVHcQ/Q6RUwhZnykKLdVvTkdV49txMfG4cImddp8UR+no5iFbhTZJBwO1
 y9sZK/1Iw4JIsnuodY1xoIW553vNsRM2vxqhEECcyurHNgxq6OA2Bfo9rOVrR+VYKMlC
 RQ3NBClrHMBV3jXUbsQ06h4hsDAc16Bdfsnp6GHdN02e+S/E19v9dY9YlSB2ZXmzO0e0
 7ZFw==
X-Gm-Message-State: AOJu0Yxon1nufVu/Cog4N/+vGHUTD7LpiXfYE34/NVxzdjX2NvNvdc8u
 geNgDSDlOq3SWwKctzTapGVfnkcGIXK8/8F9NX4GHojnl9uoiDrQ5E0VQFUKxQA=
X-Google-Smtp-Source: AGHT+IHpClsy0gmkCkA9bBRY3dVH2zDYAEm0zDm8rZUaBqUbspolDOQfJXXxjK1gMsoMKlE0l1t6oA==
X-Received: by 2002:a17:902:e804:b0:206:a1ea:f4fe with SMTP id
 d9443c01a7336-20bc599e1d7mr1047855ad.10.1727796942759; 
 Tue, 01 Oct 2024 08:35:42 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-20b37d960bbsm71244845ad.84.2024.10.01.08.35.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Oct 2024 08:35:42 -0700 (PDT)
Date: Tue, 1 Oct 2024 08:35:40 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH dpdk v2 06/16] net: add ipv6 address utilities
Message-ID: <20241001083540.2d11ea62@hermes.local>
In-Reply-To: <20241001081728.301272-7-rjarry@redhat.com>
References: <20240821162516.610624-17-rjarry@redhat.com>
 <20241001081728.301272-1-rjarry@redhat.com>
 <20241001081728.301272-7-rjarry@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue,  1 Oct 2024 10:17:18 +0200
Robin Jarry <rjarry@redhat.com> wrote:

> +/** Shorthand to initialize IPv6 address values */
> +#define RTE_IPV6_ADDR(...) ((struct rte_ipv6_addr){.a = {__VA_ARGS__}})
> +
> +/**
> + * Copy an IPv6 address into another one.
> + *
> + * @param dst
> + *   The address into which to copy data.
> + * @param src
> + *   The address from which to copy.
> + */
> +static inline void
> +rte_ipv6_addr_cpy(struct rte_ipv6_addr *dst, const struct rte_ipv6_addr *src)
> +{
> +	rte_memcpy(dst, src, sizeof(*dst));
> +}
> +
> +/**

Please do not introduce more rte_memcpy() there is no reason not to just
use structure assignment, which makes the whole need for this function go away.