From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E618A45A84; Tue, 1 Oct 2024 23:44:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F0D540268; Tue, 1 Oct 2024 23:44:13 +0200 (CEST) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mails.dpdk.org (Postfix) with ESMTP id 3058040267 for ; Tue, 1 Oct 2024 23:44:12 +0200 (CEST) Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7a9a30a045cso569013085a.2 for ; Tue, 01 Oct 2024 14:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727819051; x=1728423851; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nOYBpeAttSOp6tFE0NCG8gm6cQzA4a/+ENKdcZoJQuc=; b=XuXl/wAC29GjrKardcV5pFQ3yiXg09iUZhvzEtnK4YEzTiMRkGHVOGA6xGnG3CIrI2 2Ta6pNZ5SaVLbArJqvWWn26/rSC6zgwGaamxiaEqRbCDivwidQ4TAknlbYyixdReVEjX BGfxuwSwMpl84Ij+OaVSyZV1QgpC7Lp4RR0nkDJt9zJYZls+4Eqm8HRWEIQJMg+A1p6L oWECAN1oIiZOjSfMJM1EKb6wqV2Nkr1GYff/Kk7ZeSuZLbsVqlXhi9pD257AgygKZCMs 7VmN9w80+UGBzeAXA4AQ7J8byAuF84O+lcNXGkTW5w/O8BP2sqT9dIIUy8U7znumyAlk nlVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727819051; x=1728423851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nOYBpeAttSOp6tFE0NCG8gm6cQzA4a/+ENKdcZoJQuc=; b=WJZEy5WIYMJ6WE4aKQl2xDjGTNtsafVm0R1jKV2YHAJEoFMvx2gNcT9f90A3T4aNIL G/QzGgiCn7KwlJ4CBhyEowA12AdfhEgknngunhqRfU2t+j4xdpwF+fP1HxgEfgRn2vWK IGTCY/ZVdqiCnfFPwU8KaPAkyfET/Sb6aTDBDBJdbz2U/RWnT5J0ujVInzrAPYdTD5uN KwGxrKl3W0aFhNaKWCocMb2Rprpt8EYPGVzOpenuF4HLrZwmGwW8f2CTzi86fiDV+gy3 Q43x6IiM/MG/AOQXi1fOdGuq7p6KXV1YsXE5L8yskIeeXQeCpNWbXyqQDwpoQo7sSEp/ YwQg== X-Gm-Message-State: AOJu0YwmdCdQ+lhLOuIsybss+QcDAu1yzu1EP3qmvhuPHhfwEiY5WSwm 1sHnLW4iWUO5f2bfo5FZQy9vkh5E95NA0AXPjCb98kGlqmFtpRaX95q0JC/snfk= X-Google-Smtp-Source: AGHT+IEGU+4mpFhATmeq57bZ1D2aOydmva0oD4YQ4W8p+LNTCN+0CV8POn2YuR1AY8nMq+CtwyAmtA== X-Received: by 2002:a05:620a:1998:b0:7ac:9dff:3e70 with SMTP id af79cd13be357-7ae626d64c9mr144436185a.28.1727819051217; Tue, 01 Oct 2024 14:44:11 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae377c09dfsm548696585a.16.2024.10.01.14.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 14:44:10 -0700 (PDT) Date: Tue, 1 Oct 2024 14:44:08 -0700 From: Stephen Hemminger To: Arkadiusz Kusztal Cc: dev@dpdk.org, ferruh.yigit@amd.com, kai.ji@intel.com, brian.dooley@intel.com Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api Message-ID: <20241001144408.6bcbdaf1@hermes.local> In-Reply-To: <20241001181150.43506-2-arkadiuszx.kusztal@intel.com> References: <20241001181150.43506-1-arkadiuszx.kusztal@intel.com> <20241001181150.43506-2-arkadiuszx.kusztal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 1 Oct 2024 19:11:48 +0100 Arkadiusz Kusztal wrote: > diff --git a/lib/net/version.map b/lib/net/version.map > index bec4ce23ea..47daf1464a 100644 > --- a/lib/net/version.map > +++ b/lib/net/version.map > @@ -4,11 +4,25 @@ DPDK_25 { > rte_eth_random_addr; > rte_ether_format_addr; > rte_ether_unformat_addr; > - rte_net_crc_calc; > - rte_net_crc_set_alg; > rte_net_get_ptype; > rte_net_make_rarp_packet; > rte_net_skip_ip6_ext; > + rte_net_crc; > + rte_net_crc_set; > > local: *; > }; Please keep the symbols in version.map in alphabetic order. And this would be an unannounced change to API/ABI which could cause pain for some users.