From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28EBC45A7E; Tue, 1 Oct 2024 18:37:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17C82402E3; Tue, 1 Oct 2024 18:37:22 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id BFDBD40299 for ; Tue, 1 Oct 2024 18:37:19 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7d4fa972cbeso4339133a12.2 for ; Tue, 01 Oct 2024 09:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727800638; x=1728405438; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y3UQfDwt6h0p1cTXLJHub1ibos1BMqHaxAy6mzFydWc=; b=t/aU/B8JBWCX7rzeMBeJr93Lf4QbDE+J2fHlPkiufmS4moGLt+SwNjH1BMWVLPmzF1 7aEhG+GWLkCMJjTFAO4NT9MrGg26L+jicdqZ8xVOgG3Czsj8BJT/MQM6SnZbB4XMQHxk vHOth+AwuHPAHSlqG6b1Vy0slF1taFU4ygYokTlhI07FDHA3y6zHzf2PzRgp2PGqUVIm 2HrLYN0V9lHSnDjlE7R9EW1fKz5qXioklIqeCFzZG6C5RxoLJVQsOsuByS2C0poimBSn NzAfXdlQUHkIfncSyqp89XdW11E4b2nTJmfJxwprznRu5/8IhVGQK2oS+F1/Sp7uD7ye kCuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727800638; x=1728405438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y3UQfDwt6h0p1cTXLJHub1ibos1BMqHaxAy6mzFydWc=; b=NhOcAtIkWMcv86wNesxjRILTJnVyKtoyquJ4OtzvShzJYctQ6btBodfbpqrEdYPJwd EAoYT4LdC6XFfL/CxJRLKqyzKpfm2nEoPCA9AHphMLL3dv1lyaXxZh7+CXlr5L2pbuXH otfoBC1t4CAQXl5IxdzXmzhbHDH+7DYmfIyl0SlHE1PAMULtnM47TEbWFD+ZryPaKUFr Kt2OAkPS87lx74s2Pr6Lo79OPywT+/U7Tohcgp2C4mV0s3wnowPqDQ6NjftHDWCOsp7W lY2ePdR6pqRs2KD1Y9XQyWIfnheSMcMZp04rDnaTWe4e9yZ7oG2wIH8AR9mcwhBUZbPl Swqw== X-Gm-Message-State: AOJu0YzMlQ70vwp9xFiQVRHAv9cD4uXc2F6UJkbzX4CxASTudmiGj/GO RpJpw4HcsOqHmHC2OLeTRf4Ug9f4qJ4I5U3cklKUiFK9OPIXp0AzHctUxAwpw3ArrzpUJie6Hh9 ejp4= X-Google-Smtp-Source: AGHT+IFZyQUdjMi7xZ9uVSB/FqrBEnU95/WFiLUdLmLLFpyKs+d2Y5NYFlwjBwxiOpGAKnzas/X3bg== X-Received: by 2002:a05:6a20:c6c2:b0:1d4:fdc7:578e with SMTP id adf61e73a8af0-1d5db1a9914mr405333637.7.1727800638648; Tue, 01 Oct 2024 09:37:18 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b26518818sm8213565b3a.129.2024.10.01.09.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 09:37:18 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v5 00/17] Fix allocation related bugs and add attributes Date: Tue, 1 Oct 2024 09:35:23 -0700 Message-ID: <20241001163708.355128-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240927204742.546164-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recent versions of GCC have some additional function attributes that can help with DPDK performance and stability. The alloc_align attribute tells the compiler what the alignment of the allocation will be, and the optimizer can use this to produce better code (especially memcpy and structure copies). The malloc attribute tells compiler that object is not overlapping and potentially aliasing. It also as an additional variant in GCC 11 or later that allows for detecting all sorts of common errors like calling free() on memory allocated with rte_malloc(). In order to use the malloc attribute the free function prototype needs to be moved before the allocator/create function prototype so that the malloc attribute can refer to it. This uncovered at least 16 pre-existing bugs in DPDK, these should go to stable. This patch set is structured with: - fix any new warnings that were discovered - add macros for enable the macros - enable the attributes The same attributes could be added to lots more functions in DPDK, but this patch set focuses on the key ones, and where problems exist in current code base. v5 - minor touchup to the function attribute wrappers Stephen Hemminger (17): memzone: fix use after free in tracing cryptodev/bcmfs: fix mis-matched free dma/ixd: fix incorrect free function in cleanup event/cnxk: fix pointer mismatch in cleanup examples/vhost: fix free function mismatch net/cnxk: fix use-after-free bpf: fix free mismatch if convert fails net/e1000: fix use-after-free net/sfc: fix use-after-free warning messages net/cpfl: fix free of nonheap object net/nfp: fix duplicate call to rte_free raw/ifpga/base: fix use after free common/qat: fix use after free drivers/ifpga: fix free function mismatch baseband/la12xx: prevent use after free common/idpf: fix use after free due eal: add function attributes for allocation functions doc/guides/rel_notes/release_24_11.rst | 8 ++++ drivers/baseband/la12xx/bbdev_la12xx.c | 1 + drivers/common/idpf/base/idpf_osdep.h | 10 ++++- drivers/common/idpf/idpf_common_device.c | 3 +- drivers/common/qat/qat_device.c | 6 +-- drivers/crypto/bcmfs/bcmfs_device.c | 4 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/event/cnxk/cnxk_eventdev.c | 4 +- drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +- drivers/net/cpfl/cpfl_flow_parser.c | 1 - drivers/net/e1000/igb_ethdev.c | 4 +- drivers/net/nfp/flower/nfp_flower_flow.c | 1 - drivers/net/sfc/sfc_flow_rss.c | 4 +- drivers/net/sfc/sfc_mae.c | 23 ++++------ drivers/raw/ifpga/base/opae_intel_max10.c | 11 ++++- drivers/raw/ifpga/ifpga_rawdev.c | 8 ++-- examples/vhost_blk/vhost_blk.c | 2 +- lib/bpf/bpf_convert.c | 2 +- lib/eal/common/eal_common_memzone.c | 3 +- lib/eal/include/rte_common.h | 34 ++++++++++++++ lib/eal/include/rte_malloc.h | 55 +++++++++++++---------- 21 files changed, 122 insertions(+), 66 deletions(-) -- 2.45.2