From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98EB445A7E; Tue, 1 Oct 2024 18:38:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADC1C40A76; Tue, 1 Oct 2024 18:37:34 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 4BE0F40677 for ; Tue, 1 Oct 2024 18:37:27 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7e6afa8baeaso4914544a12.3 for ; Tue, 01 Oct 2024 09:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727800646; x=1728405446; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NIKMlyZ2ZqwKuu4XJ9qGt7h821Tno22ntchYBoMYUOs=; b=e/gJz0PbsBd76dBO8l8kBoOCgBm0PEH8+qHqYdHYOKEQLKb/XS2o0S+FBjUv+9CgnE d5rB0+8ishEdPwFjrh9dxaElzMc0iBDaXZCsf5wlyPy1sHneovKbX7qLajW+L6dPGPs1 OT9JDrT0EB5xHs86vUTlH+H/ODo/+5ZtM8IVM2TdrLU119ZJ81SZx0i5FrzSyQFdxnSD t2MWCO8v/nAATfa9Q14sc/L133XgDFng0CuWwDvhkLIrXzLbSOB66+mOTNk7Np6YftRV MGuPSejaiHmHd9z8PHNqhfqMzaiMlwVE8BPTwtErTmeQcMrDQN8zgJVbbKXeVKv8z6qC 6gig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727800646; x=1728405446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NIKMlyZ2ZqwKuu4XJ9qGt7h821Tno22ntchYBoMYUOs=; b=FI15Jd8Im6G47WaGX/5i0SllwESFRwtma6BPsBM6dpPtYuE+8xxXg1RUGIRdtBCalz PjIdQCDd2qD/Zhq7+DVx7fZvg/lWjH79YJmxtN4wcIJt+6JpdUgPuueKIvOpMqfaRnl9 kiB8MBBBUGDwysQRS7tWHj6x8iTMJAlEiADyreJREF4rqwd7u3VZAq5nzXK1VHPoFyyV 4wE69JMpQff1XDeFsAyU3sQc/OzRWa3nfdxWg0TsuNOoyMPZ/Ip5SrAIS0XCxWqa4638 CxCOg4wgsbzI8pH9X54ezolJ8suw+crbIWQl3ZcStKJIMKQS6+HQsNsPcGz/OfEtrbaV rwCw== X-Gm-Message-State: AOJu0YzAYiS/XhALFfiIH5DThVn1WSlhH5+iMQsshDmNfXMluPD+IXNF nZYeZiMqGhZJxlu4V55hJbvkZNqcrKbvovOkvbUN81WDMATyNbqI+nZuKhfuJbbUQrf+Z//MBrh W1I4= X-Google-Smtp-Source: AGHT+IE0kW/TDIYX8s803XOVoTx81p6QglGtOmA+O8qAvXBEartiWWqeAIdRoPN8r0elcps2Y79uqg== X-Received: by 2002:a05:6a20:6f0a:b0:1d2:f0e2:4ad2 with SMTP id adf61e73a8af0-1d5e2d3d458mr487934637.44.1727800646464; Tue, 01 Oct 2024 09:37:26 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b26518818sm8213565b3a.129.2024.10.01.09.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 09:37:26 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ivan Malov , Andrew Rybchenko , Andy Moreton Subject: [PATCH v5 09/17] net/sfc: fix use-after-free warning messages Date: Tue, 1 Oct 2024 09:35:32 -0700 Message-ID: <20241001163708.355128-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241001163708.355128-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241001163708.355128-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If compiler detection of use-after-free is enabled then this drivers debug messages will cause warnings. Change to move debug message before the object is freed. Bugzilla ID: 1551 Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows") Signed-off-by: Stephen Hemminger Reviewed-by: Ivan Malov Acked-by: Andrew Rybchenko --- drivers/net/sfc/sfc_flow_rss.c | 4 ++-- drivers/net/sfc/sfc_mae.c | 23 +++++++++-------------- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/net/sfc/sfc_flow_rss.c b/drivers/net/sfc/sfc_flow_rss.c index e28c943335..8e2749833b 100644 --- a/drivers/net/sfc/sfc_flow_rss.c +++ b/drivers/net/sfc/sfc_flow_rss.c @@ -303,9 +303,9 @@ sfc_flow_rss_ctx_del(struct sfc_adapter *sa, struct sfc_flow_rss_ctx *ctx) TAILQ_REMOVE(&flow_rss->ctx_list, ctx, entries); rte_free(ctx->qid_offsets); - rte_free(ctx); - sfc_dbg(sa, "flow-rss: deleted ctx=%p", ctx); + + rte_free(ctx); } static int diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index 60ff6d2181..8f74f10390 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -400,9 +400,8 @@ sfc_mae_outer_rule_del(struct sfc_adapter *sa, efx_mae_match_spec_fini(sa->nic, rule->match_spec); TAILQ_REMOVE(&mae->outer_rules, rule, entries); - rte_free(rule); - sfc_dbg(sa, "deleted outer_rule=%p", rule); + rte_free(rule); } static int @@ -585,9 +584,8 @@ sfc_mae_mac_addr_del(struct sfc_adapter *sa, struct sfc_mae_mac_addr *mac_addr) } TAILQ_REMOVE(&mae->mac_addrs, mac_addr, entries); - rte_free(mac_addr); - sfc_dbg(sa, "deleted mac_addr=%p", mac_addr); + rte_free(mac_addr); } enum sfc_mae_mac_addr_type { @@ -785,10 +783,10 @@ sfc_mae_encap_header_del(struct sfc_adapter *sa, } TAILQ_REMOVE(&mae->encap_headers, encap_header, entries); + sfc_dbg(sa, "deleted encap_header=%p", encap_header); + rte_free(encap_header->buf); rte_free(encap_header); - - sfc_dbg(sa, "deleted encap_header=%p", encap_header); } static int @@ -983,9 +981,8 @@ sfc_mae_counter_del(struct sfc_adapter *sa, struct sfc_mae_counter *counter) } TAILQ_REMOVE(&mae->counters, counter, entries); - rte_free(counter); - sfc_dbg(sa, "deleted counter=%p", counter); + rte_free(counter); } static int @@ -1165,9 +1162,8 @@ sfc_mae_action_set_del(struct sfc_adapter *sa, sfc_mae_mac_addr_del(sa, action_set->src_mac_addr); sfc_mae_counter_del(sa, action_set->counter); TAILQ_REMOVE(&mae->action_sets, action_set, entries); - rte_free(action_set); - sfc_dbg(sa, "deleted action_set=%p", action_set); + rte_free(action_set); } static int @@ -1401,10 +1397,10 @@ sfc_mae_action_set_list_del(struct sfc_adapter *sa, sfc_mae_action_set_del(sa, action_set_list->action_sets[i]); TAILQ_REMOVE(&mae->action_set_lists, action_set_list, entries); + sfc_dbg(sa, "deleted action_set_list=%p", action_set_list); + rte_free(action_set_list->action_sets); rte_free(action_set_list); - - sfc_dbg(sa, "deleted action_set_list=%p", action_set_list); } static int @@ -1667,9 +1663,8 @@ sfc_mae_action_rule_del(struct sfc_adapter *sa, sfc_mae_outer_rule_del(sa, rule->outer_rule); TAILQ_REMOVE(&mae->action_rules, rule, entries); - rte_free(rule); - sfc_dbg(sa, "deleted action_rule=%p", rule); + rte_free(rule); } static int -- 2.45.2