From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E57D45A7E; Tue, 1 Oct 2024 18:38:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE6CE40B8C; Tue, 1 Oct 2024 18:37:35 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 1DAB840685 for ; Tue, 1 Oct 2024 18:37:28 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7cd8803fe0aso4006386a12.0 for ; Tue, 01 Oct 2024 09:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727800647; x=1728405447; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5rIUygztSKBo8hXRl59YcTQfr34c1sPRuIObTaqdxdQ=; b=nGsJGNsENwbNJb+xf63s5McDf0flBykHBwbmesytQN4qGfFNI703T2TecJ7n+Kikp6 Pj9yQDn/s2j/spTDpwHqU5RRIz8yIrrhFU0f8Ru54fdrXJ1KP1LPdSSaNrDA+0WTrgPO bVxf0SxN46RN/XHd+ZLNdIeFuX3E4HJ+dRH2krbj5o2TjQM1cAZxbO6aPE/cE7h1UsS8 dt2KYs1XXfO+sHW1DqLCl2MONRAvlw+CwrNovJN7diDy+72ht0Rc9dsYeNvjEYbXAtmx fRpbHyk+iWXh6zvoumosk9EsYSyIq7JM+B/y5H+7OcrwGbMEeHgPlZHhwGUgj5WbP0Rj MENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727800647; x=1728405447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5rIUygztSKBo8hXRl59YcTQfr34c1sPRuIObTaqdxdQ=; b=cxcH6SQXFZUyK1WvT1H3QbCCgACMfbRvbmlMYm00ec3+XR4C1gYZJ7mnGPf6t+B/ut IZn7MdQgC+lK/m7leN4EBk3i7/OP4Zcq0ICOSSUofl++2HuzSSq+bcYYoRJfvbFEbvhO b++itK48bmHGeahoXq5UAAteLwMfRMs7l0pxeqbDr8XWnwUfj9X/XF6oAQawh6/iUhjv KpHCcZxNgDyP1fkPnkXaJCaPWVnamMDa7txpMkENg4rnNibR1Z42E0O/B38LuszEqiE/ KCUeJDjfu0b/pXb80RipI2DPK8K/DvBh1nqzJSmP4TrWFvOsKqwkDy7lYgoJKNmbTAUu L3YA== X-Gm-Message-State: AOJu0Yy9GOKYIb6LDhHD/A0/DqCOLc8SP5042xTujWsJfCc1t2/NfHTa YVlanrcOIotCdItw23yipBoUVKDHdFsSuHoZn0IsH1bOFWelotBP3XTDEZkhpBkQtXpi8Omgjpd LWzE= X-Google-Smtp-Source: AGHT+IEKwEMSq47M+rAX+lADldSbG/LVTEPX8SQH5du853DoXG5m5niQlY6KGvilPD3U/QHtpIBeZw== X-Received: by 2002:a05:6a21:178a:b0:1cf:2513:8a01 with SMTP id adf61e73a8af0-1d5db1a96b9mr424964637.26.1727800647286; Tue, 01 Oct 2024 09:37:27 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b26518818sm8213565b3a.129.2024.10.01.09.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 09:37:26 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , wenjing.qiao@intel.com, stable@dpdk.org, Qi Zhang Subject: [PATCH v5 10/17] net/cpfl: fix free of nonheap object Date: Tue, 1 Oct 2024 09:35:33 -0700 Message-ID: <20241001163708.355128-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241001163708.355128-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241001163708.355128-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org With proper annotation, GCC discovers that this driver is calling rte_free() on an object that was not allocated (it is part of array in another object). In function ‘cpfl_flow_js_mr_layout’, inlined from ‘cpfl_flow_js_mr_action’ at ../drivers/net/cpfl/cpfl_flow_parser.c:848:9, inlined from ‘cpfl_flow_js_mod_rule’ at ../drivers/net/cpfl/cpfl_flow_parser.c:908:9, inlined from ‘cpfl_parser_init’ at ../drivers/net/cpfl/cpfl_flow_parser.c:932:8, inlined from ‘cpfl_parser_create’ at ../drivers/net/cpfl/cpfl_flow_parser.c:959:8: ../drivers/net/cpfl/cpfl_flow_parser.c:740:9: warning: ‘rte_free’ called on pointer ‘*parser.modifications’ with nonzero offset [28, 15479062120396] [-Wfree-nonheap-object] 740 | rte_free(js_mod->layout); | ^~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON") Cc: wenjing.qiao@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_flow_parser.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_parser.c b/drivers/net/cpfl/cpfl_flow_parser.c index 40569ddc6f..30abaad7c8 100644 --- a/drivers/net/cpfl/cpfl_flow_parser.c +++ b/drivers/net/cpfl/cpfl_flow_parser.c @@ -737,7 +737,6 @@ cpfl_flow_js_mr_layout(json_t *ob_layouts, struct cpfl_flow_js_mr_action_mod *js return 0; err: - rte_free(js_mod->layout); return -EINVAL; } -- 2.45.2