DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	sthotton@marvell.com, stable@dpdk.org,
	Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: [PATCH v5 04/17] event/cnxk: fix pointer mismatch in cleanup
Date: Tue,  1 Oct 2024 09:35:27 -0700	[thread overview]
Message-ID: <20241001163708.355128-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20241001163708.355128-1-stephen@networkplumber.org>

The code to cleanup in case of error was passing incorrect
value to rte_free. The ports[] entry was allocated with
rte_malloc and that should be used instead of the offset
in that object.

Fixes: 97a05c1fe634 ("event/cnxk: add port config")
Cc: sthotton@marvell.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/event/cnxk/cnxk_eventdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
index 4b2d6bffa6..08c6ce0c07 100644
--- a/drivers/event/cnxk/cnxk_eventdev.c
+++ b/drivers/event/cnxk/cnxk_eventdev.c
@@ -121,8 +121,10 @@ cnxk_setup_event_ports(const struct rte_eventdev *event_dev,
 	return 0;
 hws_fini:
 	for (i = i - 1; i >= 0; i--) {
+		void *ws = event_dev->data->ports[i];
+
 		event_dev->data->ports[i] = NULL;
-		rte_free(cnxk_sso_hws_get_cookie(event_dev->data->ports[i]));
+		rte_free(ws);
 	}
 	return -ENOMEM;
 }
-- 
2.45.2


  parent reply	other threads:[~2024-10-01 16:37 UTC|newest]

Thread overview: 196+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 20:45 [PATCH 00/16] Fix allocation issues and add hardening Stephen Hemminger
2024-09-27 20:45 ` [PATCH 01/16] eal: add function attributes for allocation functions Stephen Hemminger
2024-09-27 22:09   ` David Marchand
2024-09-27 23:10     ` Stephen Hemminger
2024-09-27 20:45 ` [PATCH 02/16] memzone: fix use after free in tracing Stephen Hemminger
2024-09-27 20:45 ` [PATCH 03/16] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-09-27 20:45 ` [PATCH 04/16] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-09-27 20:45 ` [PATCH 05/16] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-09-27 20:45 ` [PATCH 06/16] examples/vhost: fix free function mismatch Stephen Hemminger
2024-09-27 20:45 ` [PATCH 07/16] net/cnxk: fix use-after-free Stephen Hemminger
2024-09-27 20:45 ` [PATCH 08/16] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-09-27 20:45 ` [PATCH 09/16] net/e1000: fix use-after-free Stephen Hemminger
2024-09-27 20:45 ` [PATCH 10/16] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-09-28 11:52   ` Ivan Malov
2024-09-27 20:45 ` [PATCH 11/16] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-09-27 20:45 ` [PATCH 12/16] raw/ifpga/base: fix use after free Stephen Hemminger
2024-09-27 20:45 ` [PATCH 13/16] common/qat: " Stephen Hemminger
2024-09-27 20:45 ` [PATCH 14/16] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-09-27 20:45 ` [PATCH 15/16] eal: add alloc_function attribute to rte_malloc Stephen Hemminger
2024-09-27 20:45 ` [PATCH 16/16] mempool: annotate mempool create Stephen Hemminger
2024-09-28 11:49   ` Morten Brørup
2024-09-28 16:47 ` [PATCH v2 00/16] Fix allocation bugs and add malloc hardening Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 01/16] eal: add function attributes for allocation functions Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 02/16] memzone: fix use after free in tracing Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 03/16] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 04/16] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 05/16] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 06/16] examples/vhost: fix free function mismatch Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 07/16] net/cnxk: fix use-after-free Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 08/16] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 09/16] net/e1000: fix use-after-free Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 10/16] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 11/16] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 12/16] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 13/16] raw/ifpga/base: fix use after free Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 14/16] common/qat: " Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 15/16] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-09-28 16:47   ` [PATCH v2 16/16] eal: add alloc_function attribute to rte_malloc Stephen Hemminger
2024-09-29 15:34 ` [PATCH v3 00/18] Fix allocation bugs and add malloc hardening Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 01/18] memzone: fix use after free in tracing Stephen Hemminger
2024-09-30  9:15     ` fengchengwen
2024-09-29 15:34   ` [PATCH v3 02/18] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 03/18] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 04/18] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 05/18] examples/vhost: fix free function mismatch Stephen Hemminger
2024-09-30  9:16     ` fengchengwen
2024-09-29 15:34   ` [PATCH v3 06/18] net/cnxk: fix use-after-free Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 07/18] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 08/18] net/e1000: fix use-after-free Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 09/18] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-09-30  5:53     ` Andrew Rybchenko
2024-09-29 15:34   ` [PATCH v3 10/18] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 11/18] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 12/18] raw/ifpga/base: fix use after free Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 13/18] common/qat: " Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 14/18] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 15/18] baseband/la12xx: prevent use after free Stephen Hemminger
2024-09-30  8:25     ` Hemant Agrawal
2024-09-29 15:34   ` [PATCH v3 16/18] common/ipdf: fix use after free due Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 17/18] eal: add function attributes for allocation functions Stephen Hemminger
2024-09-30  9:19     ` fengchengwen
2024-10-08  8:29     ` Morten Brørup
2024-10-08 15:43       ` Stephen Hemminger
2024-09-29 15:34   ` [PATCH v3 18/18] eal: add alloc_function attribute to rte_malloc Stephen Hemminger
2024-09-30  9:20     ` fengchengwen
2024-09-30 18:43 ` [PATCH v4 00/17] Fix allocation bugs and hardening for rte_malloc Stephen Hemminger
2024-09-30 18:43   ` [PATCH v4 01/17] memzone: fix use after free in tracing Stephen Hemminger
2024-10-01 12:17     ` Burakov, Anatoly
2024-09-30 18:43   ` [PATCH v4 02/17] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-09-30 20:06     ` Ajit Khaparde
2024-09-30 18:43   ` [PATCH v4 03/17] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-10-01 12:41     ` Bruce Richardson
2024-09-30 18:43   ` [PATCH v4 04/17] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-09-30 18:43   ` [PATCH v4 05/17] examples/vhost: fix free function mismatch Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 06/17] net/cnxk: fix use-after-free Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 07/17] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 08/17] net/e1000: fix use-after-free Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 09/17] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 10/17] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 11/17] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 12/17] raw/ifpga/base: fix use after free Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 13/17] common/qat: " Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 14/17] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 15/17] baseband/la12xx: prevent use after free Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 16/17] common/idpf: fix use after free due Stephen Hemminger
2024-09-30 18:44   ` [PATCH v4 17/17] eal: add function attributes for allocation functions Stephen Hemminger
2024-10-01 12:21     ` Burakov, Anatoly
2024-10-01 12:25       ` David Marchand
2024-10-01 15:25         ` Stephen Hemminger
2024-10-02  8:42           ` Burakov, Anatoly
2024-10-01 16:35 ` [PATCH v5 00/17] Fix allocation related bugs and add attributes Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 01/17] memzone: fix use after free in tracing Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 02/17] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 03/17] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-10-01 17:04     ` Bruce Richardson
2024-10-01 16:35   ` Stephen Hemminger [this message]
2024-10-01 16:35   ` [PATCH v5 05/17] examples/vhost: fix free function mismatch Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 06/17] net/cnxk: fix use-after-free Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 07/17] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 08/17] net/e1000: fix use-after-free Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 09/17] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 10/17] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 11/17] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 12/17] raw/ifpga/base: fix use after free Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 13/17] common/qat: " Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 14/17] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 15/17] baseband/la12xx: prevent use after free Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 16/17] common/idpf: fix use after free due Stephen Hemminger
2024-10-01 16:35   ` [PATCH v5 17/17] eal: add function attributes for allocation functions Stephen Hemminger
2024-10-02  7:06     ` David Marchand
2024-10-02 15:42 ` [PATCH v6 00/17] Fix allocation related bugs and catch future bugs Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 01/17] memzone: fix use after free in tracing Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 02/17] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 03/17] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 04/17] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 05/17] examples/vhost: fix free function mismatch Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 06/17] net/cnxk: fix use-after-free Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 07/17] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 08/17] net/e1000: fix use-after-free Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 09/17] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 10/17] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 11/17] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 12/17] raw/ifpga/base: fix use after free Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 13/17] common/qat: " Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 14/17] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-10-02 15:42   ` [PATCH v6 15/17] baseband/la12xx: prevent use after free Stephen Hemminger
2024-10-02 15:43   ` [PATCH v6 16/17] common/idpf: fix use after free due Stephen Hemminger
2024-10-02 15:43   ` [PATCH v6 17/17] eal: add function attributes for allocation functions Stephen Hemminger
2024-10-02 16:45     ` Wathsala Wathawana Vithanage
2024-10-02 18:23       ` Ajit Khaparde
2024-10-08  9:03     ` Morten Brørup
2024-10-02 18:37 ` [PATCH v7 00/16] Fix allocation bugs and prevent future ones Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 01/16] memzone: fix use after free in tracing Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 02/16] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 03/16] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 04/16] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-10-03  5:52     ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-02 18:37   ` [PATCH v7 05/16] examples/vhost: fix free function mismatch Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 06/16] net/cnxk: fix use-after-free Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 07/16] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 08/16] net/e1000: fix use-after-free Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 09/16] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 10/16] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 11/16] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 12/16] raw/ifpga/base: fix use after free Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 13/16] common/qat: " Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 14/16] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 15/16] baseband/la12xx: prevent use after free Stephen Hemminger
2024-10-02 18:37   ` [PATCH v7 16/16] common/idpf: fix use after free due Stephen Hemminger
2024-10-04 14:28   ` [PATCH v7 00/16] Fix allocation bugs and prevent future ones David Marchand
2024-10-04 14:57     ` David Marchand
2024-10-08 16:50       ` Stephen Hemminger
2024-10-10 10:14         ` David Marchand
2024-10-08 15:41 ` [PATCH v8 00/17] Add function attributes to uncover allocation bugs Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 01/17] memzone: fix use after free in tracing Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 02/17] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 03/17] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 04/17] event/cnxk: fix pointer mismatch " Stephen Hemminger
2024-10-08 16:40     ` Stephen Hemminger
2024-10-08 16:43       ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-08 15:41   ` [PATCH v8 05/17] examples/vhost: fix free function mismatch Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 06/17] net/cnxk: fix use-after-free Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 07/17] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 08/17] net/e1000: fix use-after-free Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 09/17] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 10/17] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 11/17] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 12/17] raw/ifpga/base: fix use after free Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 13/17] common/qat: " Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 14/17] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 15/17] baseband/la12xx: prevent use after free Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 16/17] common/idpf: fix use after free due Stephen Hemminger
2024-10-08 15:41   ` [PATCH v8 17/17] eal: add function attributes for allocation functions Stephen Hemminger
2024-10-08 16:47 ` [PATCH v9 00/17] Use malloc function attribute to uncover bugs Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 01/17] memzone: fix use after free in tracing Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 02/17] cryptodev/bcmfs: fix mis-matched free Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 03/17] dma/ixd: fix incorrect free function in cleanup Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 04/17] event/cnxk: fix free of non-heap in cleanup code Stephen Hemminger
2024-10-08 16:54     ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-08 16:47   ` [PATCH v9 05/17] examples/vhost: fix free function mismatch Stephen Hemminger
2024-10-09  6:27     ` Chenbo Xia
2024-10-08 16:47   ` [PATCH v9 06/17] net/cnxk: fix use-after-free Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 07/17] bpf: fix free mismatch if convert fails Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 08/17] net/e1000: fix use-after-free Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 09/17] net/sfc: fix use-after-free warning messages Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 10/17] net/cpfl: fix free of nonheap object Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 11/17] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 12/17] raw/ifpga/base: fix use after free Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 13/17] common/qat: " Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 14/17] drivers/ifpga: fix free function mismatch Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 15/17] baseband/la12xx: prevent use after free Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 16/17] common/idpf: fix use after free due Stephen Hemminger
2024-10-08 16:47   ` [PATCH v9 17/17] eal: add function attributes for allocation functions Stephen Hemminger
2024-10-10 15:07   ` [PATCH v9 00/17] Use malloc function attribute to uncover bugs Konstantin Ananyev
2024-10-10 15:30   ` Wathsala Wathawana Vithanage
2024-10-10 16:58   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001163708.355128-5-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).