DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: 20230629203720.682f90c3@hermes.local
Cc: "Harry van Haaren" <harry.van.haaren@intel.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	hofors@lysator.liu.se, dev@dpdk.org,
	"Suanming Mou" <suanmingm@nvidia.com>,
	thomas@monjalon.net, david.marchand@redhat.com,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
	stable@dpdk.org
Subject: Re: [PATCH] service: avoid worker lcore exit deadlock
Date: Wed, 2 Oct 2024 07:02:54 -0700	[thread overview]
Message-ID: <20241002140254.GA11325@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20241001162603.793853-1-mattias.ronnblom@ericsson.com>

On Tue, Oct 01, 2024 at 06:26:03PM +0200, Mattias Rönnblom wrote:
> Calling rte_exit() from a worker lcore thread causes a deadlock in
> rte_service_finalize().
> 
> This patch makes rte_service_finalize() deadlock-free by avoiding the
> need to synchronize with service lcore threads, which in turn is
> achieved by moving service and per-lcore state from the heap to being
> statically allocated.
> 
> The BSS segment increases with ~156 kB (on x86_64 with default
> RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX).
> 
> According to the service perf autotest, this change also results in a
> slight reduction of service framework overhead.
> 
> Fixes: 33666b448f15 ("service: fix crash on exit")
> Cc: harry.van.haaren@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>


  reply	other threads:[~2024-10-02 14:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 16:26 Mattias Rönnblom
2024-10-02 14:02 ` Tyler Retzlaff [this message]
2024-10-03  6:57 ` [PATCH v2] service: fix deadlock on worker lcore exit David Marchand
2024-10-03  9:13   ` David Marchand
2024-10-03 15:50     ` Van Haaren, Harry
2024-10-11  8:50       ` David Marchand
  -- strict thread matches above, loose matches on Subject: below --
2023-07-04 21:43 [PATCH] service: avoid worker lcore exit deadlock Mattias Rönnblom
2023-07-06 11:33 ` Van Haaren, Harry
2024-10-01 13:54 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241002140254.GA11325@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=20230629203720.682f90c3@hermes.local \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=hofors@lysator.liu.se \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=suanmingm@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).