From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA3E045A8E; Wed, 2 Oct 2024 17:46:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1285940A6F; Wed, 2 Oct 2024 17:44:57 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 6EFC240677 for ; Wed, 2 Oct 2024 17:44:50 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-20b84bfbdfcso7246735ad.0 for ; Wed, 02 Oct 2024 08:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727883889; x=1728488689; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DdmWrgw09tadbkT7NdxbMIVnjX7ZkAUu8O2SQsLsM2k=; b=ejaaAu4Wx7rwoRrlqPSL5EvA3keknzwL4n7X8lCEZHjsLSVr6KRslMjZtfUjiLsHll wrBYJdiszbyBwC9vzjEKEaToBdQvF6n9OaLh23HRKgWWfqSNdCCWkZQBmaFWOI/qjwz2 rPDg1RrJa82UMRZaRC5pzO4hgO9dlzvAfFkdalOCeDOdZTMjhdA5k8ilZXftiSUtgpsa nCurkA4/mRHC0sGomnQaBXCQDwK7ymJnMnaJ63zAZtwnssuP49ULlgvxhgTNwULwHKZ2 M2dvfSma3wdvt6F1gOzGPN4m6CLDz2u1ttVybrGuxMJmI33I+n1MoJua7/6q4mt0g2uu cHgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727883889; x=1728488689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DdmWrgw09tadbkT7NdxbMIVnjX7ZkAUu8O2SQsLsM2k=; b=Fodfpew4c9aOvJLQWGi1xboq3hlHvEcnjAzbbN8px7G/T2Qx4tVeCJlKIVJsAJsRtl 8OVCNQoOimeA3Ol1ePecVPu225XXbuhMGcTwYKXBAbUF5SuS7GzWaLbvMAwh3gfLNrNP jH8UvZpcBKyY6OkumH4PjVoE8sb05eOzhc7Ozfw5hL8T7KXFwfEzPh8M5diAhK4zQYVN LGzlDW/t1+NpIU7pIMyccYqL3XZa5Tfoyt+2EoouiNJ+XQVBqsPsAIQeC19zsUz4Ax8j eyKR1tXeiOyZMAgJvUkEBUwzUduvsu11U7mE9UG9uG+1kQPm7taFjtNQ6p5RFpphLZqx EpXA== X-Gm-Message-State: AOJu0YwpC+yyWXx8efyqe8VDy/MZGxbtVdb+lFdM+wmyEGF/7Ys7jjEt tUOtCVDyqgvR9qUtrMH6OtoNsseKQG97JRZPKEHXAAcDc6DLZ3abc4V2xXukY4XnsWMBKKsVCn8 jU4c= X-Google-Smtp-Source: AGHT+IEMVAXuhJXkNNy5ZW/E3Oe3u+J3ARWfmCqDmZrcxCjG5mO6TqFIduJueMGoXjphWINe2Tu0cw== X-Received: by 2002:a17:903:22c4:b0:20b:46c6:3e47 with SMTP id d9443c01a7336-20be19a0972mr245575ad.29.1727883889585; Wed, 02 Oct 2024 08:44:49 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db2927c7sm10247363a12.1.2024.10.02.08.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 08:44:49 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Rosen Xu , Tianfei Zhang , Andy Pei Subject: [PATCH v6 12/17] raw/ifpga/base: fix use after free Date: Wed, 2 Oct 2024 08:42:56 -0700 Message-ID: <20241002154429.64357-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241002154429.64357-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241002154429.64357-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The TAILQ_FOREACH() macro would refer to info after it had been freed. Fix by introducing TAILQ_FOREACH_SAFE here. Fixes: 4a19f89104f8 ("raw/ifpga/base: support multiple cards") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/base/opae_intel_max10.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c b/drivers/raw/ifpga/base/opae_intel_max10.c index dd97a5f9fd..d5a9ceb6e3 100644 --- a/drivers/raw/ifpga/base/opae_intel_max10.c +++ b/drivers/raw/ifpga/base/opae_intel_max10.c @@ -6,6 +6,13 @@ #include #include "opae_osdep.h" +#ifndef TAILQ_FOREACH_SAFE +#define TAILQ_FOREACH_SAFE(var, head, field, tvar) \ + for ((var) = TAILQ_FIRST((head)); \ + (var) && ((tvar) = TAILQ_NEXT((var), field), 1); \ + (var) = (tvar)) +#endif + int max10_sys_read(struct intel_max10_device *dev, unsigned int offset, unsigned int *val) { @@ -746,9 +753,9 @@ static int fdt_get_named_reg(const void *fdt, int node, const char *name, static void max10_sensor_uinit(struct intel_max10_device *dev) { - struct opae_sensor_info *info; + struct opae_sensor_info *info, *next; - TAILQ_FOREACH(info, &dev->opae_sensor_list, node) { + TAILQ_FOREACH_SAFE(info, &dev->opae_sensor_list, node, next) { TAILQ_REMOVE(&dev->opae_sensor_list, info, node); opae_free(info); } -- 2.45.2