From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A4A945A9D; Wed, 2 Oct 2024 17:45:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0520440696; Wed, 2 Oct 2024 17:44:52 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id AA1F440654 for ; Wed, 2 Oct 2024 17:44:46 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-719b17b2da1so7136b3a.0 for ; Wed, 02 Oct 2024 08:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727883886; x=1728488686; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tvq5E5KXslKNmPC408QbgP3MTNkCviUF5WUYmeRxPkg=; b=Sfc3ZSRRfNk49RmmdddFQjTucS/wRZkbgUMPPPbsfSdDtnwR3xguZoc2ulWA0+yiF/ UxnBtLNvkozv2NK1mR8xObySiT5Y8GcsgQJzlSXyxUcqpg03lZmI0RGld8XGqfkWwJ9I ts4R/Ld727RV+1c5M+gP1hop2qmCdnnucNzBtOfvUU+Zq5AUjMe5YbkXUq3dqI8hc4Rh a1OlQhQ2uQmADBUJ5ZkwIkWVL+5Kq4ilL0fBDSy325RvBJDfWz2VcRn0RZMWfE3OQX15 TDBmkaWRWl9pY5IuRProbn3/slZbeGHQoT6fqFXqQZGDgscvCyO2vGhRqt1y2dkTxQ6e k1Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727883886; x=1728488686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tvq5E5KXslKNmPC408QbgP3MTNkCviUF5WUYmeRxPkg=; b=iQTmJVE8BPaE00jHxvPOlPIboKTR1fRDzMzgKhbrPEc850mszKDPN3r6AQLvlcrnjn JTTRLXd0IAFDAX6qyRQOEDH/kmRFcSAG0I96+no8xg2Z7Uw/MDaYFlttE5zlGO9M2Mbj Kx7m+33YHq/tVIQl/1RAyhFMK4t1p+3W5/8/LTyDOKGBgqR3r4tJFkai+C6QfQQ+049p JYFqdzf8tfYDxGDFDT7DKevvbnuefFKU3p23pf6WIov6rVUvDq4ctbq3y+CchCtc5cZa bafQ85uNw+pEkhLBeJMOuKi4HWq5rS/8r0/1wu5ZCxDRQIvSMUGxlVpTay4Kl07ePEa3 LklQ== X-Gm-Message-State: AOJu0YyJbC7qi6oVYiVLQZlzPrkH5pU74UMl/46XA35zxUkmbdYPWNfG hqos+YNvlKBOjq7m4pJeV450yNERBmG8zHCJ0fNpN+0FFNUKXnOfRVJJqdKPspXHaNE4TfS2ik+ Z X-Google-Smtp-Source: AGHT+IFfqXYxOeGB1xqipRKVVjQexp99zh5eddNHjmHGBthwqvCOotSJx1ryX2EbVAyJOC0aOYoV7g== X-Received: by 2002:a05:6a00:399a:b0:718:d94b:4b with SMTP id d2e1a72fcca58-71dc5c4df18mr5335445b3a.6.1727883885865; Wed, 02 Oct 2024 08:44:45 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db2927c7sm10247363a12.1.2024.10.02.08.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 08:44:45 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Wei Zhao Subject: [PATCH v6 08/17] net/e1000: fix use-after-free Date: Wed, 2 Oct 2024 08:42:52 -0700 Message-ID: <20241002154429.64357-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241002154429.64357-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241002154429.64357-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver cleanup code was freeing the filter object then dereferencing it. Bugzilla ID: 1550 Fixes: 6a4d050e2855 ("net/igb: flush all the filter") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 095be27b08..973d0d2407 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -3907,11 +3907,11 @@ igb_delete_2tuple_filter(struct rte_eth_dev *dev, filter_info->twotuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->twotuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_TTQF(filter->index), E1000_TTQF_DISABLE_MASK); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } @@ -4348,7 +4348,6 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, filter_info->fivetuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->fivetuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_FTQF(filter->index), E1000_FTQF_VF_BP | E1000_FTQF_MASK); @@ -4357,6 +4356,7 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, E1000_WRITE_REG(hw, E1000_SPQF(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } -- 2.45.2