From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E536C45A97; Thu, 3 Oct 2024 20:52:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC0C7402B3; Thu, 3 Oct 2024 20:52:00 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 74EBE402B1 for <dev@dpdk.org>; Thu, 3 Oct 2024 20:51:59 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-208cf673b8dso13598755ad.3 for <dev@dpdk.org>; Thu, 03 Oct 2024 11:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727981518; x=1728586318; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ht6av6cR0vCNx1UyYIJ+jvpdFUoeDn+qjuu0JLzQd8M=; b=O3C722FrfjxBS/zNWJoXsihDxe3WvX278w46Vp0Hw1VPSky8oaj5PAYyHCikPn1TFt yvBircF7B343ThZ1bWbZ4cBI3sAYYrerXxeOhhRt0TvVjK1EvQpW5Oix8Sre2qjMXYLf FgAmAtCC5bGWnyjoFx555r09XArsXownITX+OHkBr4N1MpulfACIe68MO+WU+ql+tN19 DiauP01DQ5V9PHsJmXH9EyjEklwBALj8E5dGUNRVTOMWjQoAYosQouPD2xVeQ/L3HXB+ PZND3iIsDBrf4veaWUmxuTyyZF+LgW8Hx2OjzSLoo0zx+4f2pwPprWaLeHawXXyv30Wo Rl8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727981518; x=1728586318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ht6av6cR0vCNx1UyYIJ+jvpdFUoeDn+qjuu0JLzQd8M=; b=xQv254ELvIwwP83PFG6RhQ/JXYrHpKkTfTuOJ0UCMOKb6SKz33pxvDOWdPyL3lL0Vu dHl24YZM1nWKwT/nibWcWeT9JCA4h6nQMxDOwrfmur58t4ud6BnuGbMFqQBgIJWYdbBG n4WmokKjA0GfwsI2ivWAkcva6yekUdwDDlexQ+yBEBqCDTmml/XnPpbMgObB/vBddwU1 I9qO+kSovY+oBuJw26A+NEumlgkzI7xH9QtU7LXjeCvh38hv2XOShu6qeSS0DyPCIMFM Uf5jp4b42jwlabENyRhirsvmqQo9IejmQnWk6rMYfal/cmJDKFp2wU5nHvUeHVW2/wf2 HCVQ== X-Forwarded-Encrypted: i=1; AJvYcCVBNaJDZo86mtwRhBJWS71i02KOyq0Hdfe/vkbi3CB96KVtd8t/FE11gxLEcXn3HMhpNN0=@dpdk.org X-Gm-Message-State: AOJu0YzaX0zj2wuW0wPz4pRCBGtZeUUZo6p32QsArWsE7nsIYxj+i3+a FaEvC9w0igiswI3OLR3bm0eRMSpo6G+nuZP1UOdfchTHGpKcshvK4ZWynLakKWw= X-Google-Smtp-Source: AGHT+IHZ2UmTaHM1tfDWtSAdjcVFcaagBFxXKGm+5HVZThPybzWPoZq76EMmUhs+/f+889SgkoZ4fA== X-Received: by 2002:a17:90a:ff14:b0:2e0:875a:f72d with SMTP id 98e67ed59e1d1-2e1e5dc6231mr141602a91.0.1727981518288; Thu, 03 Oct 2024 11:51:58 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20bef7074ddsm11972275ad.243.2024.10.03.11.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 11:51:58 -0700 (PDT) Date: Thu, 3 Oct 2024 11:51:56 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: fengchengwen <fengchengwen@huawei.com> Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>, Thomas Monjalon <thomas@monjalon.net>, Dongdong Liu <liudongdong3@huawei.com>, Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@amd.com>, <andrew.rybchenko@oktetlabs.ru>, <ciara.power@intel.com>, <kevin.laatz@intel.com>, <david.marchand@redhat.com> Subject: Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command Message-ID: <20241003115156.0c55c54d@hermes.local> In-Reply-To: <c0251a84-1d64-f140-465c-19c6a1a5a992@huawei.com> References: <20221219090723.29356-1-fengchengwen@huawei.com> <12802674.ZYm5mLc6kN@thomas> <c6ed23e5-d96a-5862-7e9c-1714437d6311@huawei.com> <18761354.fAMKPKieAE@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87A5C@smartserver.smartshare.dk> <c0251a84-1d64-f140-465c-19c6a1a5a992@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 4 Jul 2023 14:41:27 +0800 fengchengwen <fengchengwen@huawei.com> wrote: > > A general comment about telemetry: > > > > If an application exposes telemetry through an end user facing API, e.g. http(s) REST, it would be nice if non-read-only telemetry paths are easy to identify by following some DPDK standard convention, so the application does not need to manually maintain an allow-list of read-only paths. > > +1 for this point. > > > > > Bruce's documentation about trace/log/telemetry/dump might also need to be updated regarding non-read-only telemetry actions. > > I just check Bruce's patch [1], and notice that the telemetry callback must be 'read-only': (Telemetry callbacks should not modify any program state, but be "read-only"). > > From internal product usage, we think xstats-reset is valid to identify problem, but this callback is not read-only. > > We think telemetry callback should not limit to 'read-only'. Perhaps we could develop some strategy to better manage non-read-only callbacks (just like Morten's advise). > > [1]: https://patchwork.dpdk.org/project/dpdk/patch/20230620170728.74117-3-bruce.richardson@intel.com/ This patch set had functional test failures, and there never was a good conclusion about allowing telemetry to do reset. If you want to keep going with it, go through the feedback and resubmit.