From: Vamsi Krishna <vattunuru@marvell.com>
To: <fengchengwen@huawei.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <kevin.laatz@intel.com>,
<bruce.richardson@intel.com>, <jerinj@marvell.com>,
Vamsi Attunuru <vattunuru@marvell.com>
Subject: [PATCH v1 1/1] dma/cnxk: support dma queue priority configuration
Date: Thu, 3 Oct 2024 22:03:55 +0530 [thread overview]
Message-ID: <20241003163355.1384425-1-vattunuru@marvell.com> (raw)
In-Reply-To: <20241003132455.1374860-1-vattunuru@marvell.com>
From: Vamsi Attunuru <vattunuru@marvell.com>
Allow configuration of DPI DMA queue priority through
mailbox request.
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
Depends-on: patch-144960 ("dmadev: support priority configuration")
v1 changes:
* Addressed v0 comments.
drivers/common/cnxk/roc_dpi.c | 2 ++
drivers/common/cnxk/roc_dpi.h | 1 +
drivers/common/cnxk/roc_dpi_priv.h | 2 ++
drivers/common/cnxk/roc_features.h | 6 ++++++
drivers/dma/cnxk/cnxk_dmadev.c | 6 ++++++
drivers/dma/cnxk/cnxk_dmadev.h | 1 +
6 files changed, 18 insertions(+)
diff --git a/drivers/common/cnxk/roc_dpi.c b/drivers/common/cnxk/roc_dpi.c
index 892685d185..71edfcbf9b 100644
--- a/drivers/common/cnxk/roc_dpi.c
+++ b/drivers/common/cnxk/roc_dpi.c
@@ -95,6 +95,7 @@ roc_dpi_configure(struct roc_dpi *roc_dpi, uint32_t chunk_sz, uint64_t aura, uin
mbox_msg.u[1] = 0;
/* DPI PF driver expects vfid starts from index 0 */
mbox_msg.s.vfid = roc_dpi->vfid;
+ mbox_msg.s.pri = roc_dpi->priority;
mbox_msg.s.cmd = DPI_QUEUE_OPEN;
mbox_msg.s.csize = chunk_sz;
mbox_msg.s.aura = aura;
@@ -137,6 +138,7 @@ roc_dpi_configure_v2(struct roc_dpi *roc_dpi, uint32_t chunk_sz, uint64_t aura,
mbox_msg.u[1] = 0;
/* DPI PF driver expects vfid starts from index 0 */
mbox_msg.s.vfid = roc_dpi->vfid;
+ mbox_msg.s.pri = roc_dpi->priority;
mbox_msg.s.cmd = DPI_QUEUE_OPEN_V2;
mbox_msg.s.csize = chunk_sz / 8;
mbox_msg.s.aura = aura;
diff --git a/drivers/common/cnxk/roc_dpi.h b/drivers/common/cnxk/roc_dpi.h
index 7b4f9d4f4f..3a11559df9 100644
--- a/drivers/common/cnxk/roc_dpi.h
+++ b/drivers/common/cnxk/roc_dpi.h
@@ -9,6 +9,7 @@ struct roc_dpi {
struct plt_pci_device *pci_dev;
uint8_t *rbase;
uint16_t vfid;
+ uint8_t priority;
} __plt_cache_aligned;
int __roc_api roc_dpi_dev_init(struct roc_dpi *roc_dpi, uint8_t offset);
diff --git a/drivers/common/cnxk/roc_dpi_priv.h b/drivers/common/cnxk/roc_dpi_priv.h
index 844e5f37ee..1f975915f7 100644
--- a/drivers/common/cnxk/roc_dpi_priv.h
+++ b/drivers/common/cnxk/roc_dpi_priv.h
@@ -38,6 +38,8 @@ typedef union dpi_mbox_msg_t {
uint64_t wqecs : 1;
/* WQE queue DMA completion status offset */
uint64_t wqecsoff : 8;
+ /* Priority */
+ uint64_t pri : 1;
} s;
} dpi_mbox_msg_t;
diff --git a/drivers/common/cnxk/roc_features.h b/drivers/common/cnxk/roc_features.h
index 6abb35c296..0002a7b5c3 100644
--- a/drivers/common/cnxk/roc_features.h
+++ b/drivers/common/cnxk/roc_features.h
@@ -96,4 +96,10 @@ roc_feature_nix_has_second_pass_drop(void)
return 0;
}
+static inline bool
+roc_feature_dpi_has_priority(void)
+{
+ return roc_model_is_cn10k();
+}
+
#endif
diff --git a/drivers/dma/cnxk/cnxk_dmadev.c b/drivers/dma/cnxk/cnxk_dmadev.c
index 2d5307b22e..e7be3767b2 100644
--- a/drivers/dma/cnxk/cnxk_dmadev.c
+++ b/drivers/dma/cnxk/cnxk_dmadev.c
@@ -20,6 +20,10 @@ cnxk_dmadev_info_get(const struct rte_dma_dev *dev, struct rte_dma_info *dev_inf
RTE_DMA_CAPA_DEV_TO_MEM | RTE_DMA_CAPA_DEV_TO_DEV |
RTE_DMA_CAPA_OPS_COPY | RTE_DMA_CAPA_OPS_COPY_SG |
RTE_DMA_CAPA_M2D_AUTO_FREE;
+ if (roc_feature_dpi_has_priority()) {
+ dev_info->dev_capa |= RTE_DMA_CAPA_PRI_POLICY_SP;
+ dev_info->nb_priorities = CN10K_DPI_MAX_PRI;
+ }
dev_info->max_desc = CNXK_DPI_MAX_DESC;
dev_info->min_desc = CNXK_DPI_MIN_DESC;
dev_info->max_sges = CNXK_DPI_MAX_POINTER;
@@ -107,6 +111,8 @@ cnxk_dmadev_configure(struct rte_dma_dev *dev, const struct rte_dma_conf *conf,
*/
cnxk_dmadev_vchan_free(dpivf, RTE_DMA_ALL_VCHAN);
dpivf->num_vchans = conf->nb_vchans;
+ if (roc_feature_dpi_has_priority())
+ dpivf->rdpi.priority = conf->priority;
return 0;
}
diff --git a/drivers/dma/cnxk/cnxk_dmadev.h b/drivers/dma/cnxk/cnxk_dmadev.h
index 15af1d64dc..39fd6afbe9 100644
--- a/drivers/dma/cnxk/cnxk_dmadev.h
+++ b/drivers/dma/cnxk/cnxk_dmadev.h
@@ -28,6 +28,7 @@
((s).var - 1))
#define CNXK_DPI_MAX_DESC 32768
#define CNXK_DPI_MIN_DESC 2
+#define CN10K_DPI_MAX_PRI 2
#define CNXK_DPI_MAX_VCHANS_PER_QUEUE 4
#define CNXK_DPI_QUEUE_BUF_SIZE 16256
#define CNXK_DPI_QUEUE_BUF_SIZE_V2 130944
--
2.34.1
prev parent reply other threads:[~2024-10-03 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 13:24 [PATCH v0 " Vamsi Krishna
2024-10-03 16:33 ` Vamsi Krishna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003163355.1384425-1-vattunuru@marvell.com \
--to=vattunuru@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).