From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] doc: update TAP device features
Date: Thu, 3 Oct 2024 19:26:12 -0700 [thread overview]
Message-ID: <20241003192612.3c5055dd@hermes.local> (raw)
In-Reply-To: <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com>
On Fri, 4 Oct 2024 02:48:21 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 9/4/2024 4:42 PM, Stephen Hemminger wrote:
> > The TAP device does have per-queue stats and handles multi-process.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > doc/guides/nics/features/tap.ini | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
> > index f26355e57f..f2ea5cd833 100644
> > --- a/doc/guides/nics/features/tap.ini
> > +++ b/doc/guides/nics/features/tap.ini
> > @@ -14,10 +14,12 @@ Basic stats = Y
> > L3 checksum offload = Y
> > L4 checksum offload = Y
> > MTU update = Y
> > +Multiprocess aware = Y
> >
>
> ack
>
> > Multicast MAC filter = Y
> > Unicast MAC filter = Y
> > Packet type parsing = Y
> > Flow control = Y
> > +Stats per queue = Y
> >
>
> This feature name is misleading,
> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is
> indeed for covering limitation for some drivers.
> Tap does support getting stats per queue, but doesn't support above
> documented feature.
The stats queue mapping was a feature that was hinted at being removed.
It only exists because of HW limitations on Intel ixgbe NIC and SW
limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS.
Perhaps there should be a generic SW emulation for this the mapping?
next prev parent reply other threads:[~2024-10-04 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:42 Stephen Hemminger
2024-10-04 1:48 ` Ferruh Yigit
2024-10-04 2:26 ` Stephen Hemminger [this message]
2024-10-04 4:09 ` Ferruh Yigit
2024-10-04 7:54 ` Bruce Richardson
2024-10-04 15:24 ` Stephen Hemminger
2024-10-04 17:26 ` Ferruh Yigit
2024-10-04 20:40 ` Per queue stats Stephen Hemminger
2024-10-04 20:48 ` [PATCH] doc: update TAP device features Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003192612.3c5055dd@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).