From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 932F845AA7; Fri, 4 Oct 2024 04:26:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EE95402DD; Fri, 4 Oct 2024 04:26:17 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id D26BA402C9 for ; Fri, 4 Oct 2024 04:26:15 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2e192a2fe6cso1265796a91.3 for ; Thu, 03 Oct 2024 19:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728008775; x=1728613575; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RqO2npbW/WrV5+XNHoG1mrMQL1pzRNMdEdpJyKe7meA=; b=lseljTH54PcvVCbeuHXiaVpetwsTqKDEoIN2KStVLiEaqIDO/BACkPQI9Y6E1IUV4m XpQYxdSI2PxFPar2WduoFFc9i61gDIF/p2cAqI6zzg9xevbtnkEUZm2eCI0VdqCWa8Y1 x3TncXibMXbdN+TToq2XiheQfc2+xEuXQ2bgbdOPdhaSVPP/l04pHPYNuD973gVh1W0O x/5MdQdHAcDS354jJqDOSUmb3krz7omMdOyoxXL4oninmoRSA6AFpSGS4jIF4NtLLmFP oAD1FE1mA+j4VEhfLr0op8e2fInx4k3L2N34bTNYCcs3yzTe0JNIx+N2RVlU8xhnwC5I 2lTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728008775; x=1728613575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RqO2npbW/WrV5+XNHoG1mrMQL1pzRNMdEdpJyKe7meA=; b=LrFCyZoYn7ALEDTEBi0aiYrim7nG0BatW47MQaVMm7layqUuNZq1/ERUuoaDoq5NqT Zy/1F/lgmjp4naIUujXeJ6aFAn8qWmBGxpb8lhqgEZ95lOQaNKw7eWRdgi29iJpGFD1E GCNx5iK4hnZgI7Vq9t8jrlYOwdyJsONMhf3viT+qrUQbI4kKK5hVcXdXhZr6WQVZc3V4 wE3FG7lrGrmv+eAruUT98B6/Eswe0PcZTT+JoU3DdKRFs46Vz8wffrzFcY6tHbxkGUGv paVZPdgvcSf8IYZcuUSsAsz62QzmeIeLvqRu5RsR1YW58TUlQw2eGOeVRNzwhgwHmY1h ybng== X-Gm-Message-State: AOJu0YyhUej2V6jWNNCBcH2/EOjLiVehLTgeBe1iadgQ9XWsqlkw5I2N T2HUicdaJZEy8YvT+DbflgALldTzFXpc9JDcFWNfErgaIFgYVyKraynGsrktVY5fFtoTF89A6eM s6wo= X-Google-Smtp-Source: AGHT+IHjHvK3nx+1A1sQKPab/5bhqwV+XJpPFSCsjtUZarcDe1qS6h6xAN5XTyjA8cPqf97fOKspiQ== X-Received: by 2002:a17:90b:a10:b0:2d8:79bf:3873 with SMTP id 98e67ed59e1d1-2e1e63217fcmr1287877a91.29.1728008774720; Thu, 03 Oct 2024 19:26:14 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20bef70290dsm15029795ad.281.2024.10.03.19.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 19:26:14 -0700 (PDT) Date: Thu, 3 Oct 2024 19:26:12 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH] doc: update TAP device features Message-ID: <20241003192612.3c5055dd@hermes.local> In-Reply-To: <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> References: <20240904154206.13438-1-stephen@networkplumber.org> <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Oct 2024 02:48:21 +0100 Ferruh Yigit wrote: > On 9/4/2024 4:42 PM, Stephen Hemminger wrote: > > The TAP device does have per-queue stats and handles multi-process. > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/nics/features/tap.ini | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini > > index f26355e57f..f2ea5cd833 100644 > > --- a/doc/guides/nics/features/tap.ini > > +++ b/doc/guides/nics/features/tap.ini > > @@ -14,10 +14,12 @@ Basic stats = Y > > L3 checksum offload = Y > > L4 checksum offload = Y > > MTU update = Y > > +Multiprocess aware = Y > > > > ack > > > Multicast MAC filter = Y > > Unicast MAC filter = Y > > Packet type parsing = Y > > Flow control = Y > > +Stats per queue = Y > > > > This feature name is misleading, > it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is > indeed for covering limitation for some drivers. > Tap does support getting stats per queue, but doesn't support above > documented feature. The stats queue mapping was a feature that was hinted at being removed. It only exists because of HW limitations on Intel ixgbe NIC and SW limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS. Perhaps there should be a generic SW emulation for this the mapping?