From: Stephen Hemminger <stephen@networkplumber.org>
To: Conor Walsh <conor.walsh@intel.com>
Cc: ciara.power@intel.com, thomas@monjalon.net,
anatoly.burakov@intel.com, dev@dpdk.org,
bruce.richardson@intel.com
Subject: Re: [PATCH v2 2/2] usertools/telemetry: add new telemetry client
Date: Thu, 3 Oct 2024 19:38:53 -0700 [thread overview]
Message-ID: <20241003193853.19863f3e@hermes.local> (raw)
In-Reply-To: <20220831115250.362189-2-conor.walsh@intel.com>
On Wed, 31 Aug 2022 12:52:50 +0100
Conor Walsh <conor.walsh@intel.com> wrote:
> A lot of DPDK apps do not provide feedback to their users while
> running, but many interesting metrics are available through the
> app's telemetry socket. Currently, the main way to view these
> metrics is to query them using the dpdk-telemetry.py script.
> This is useful to check a few values or to check a value once.
> However, it is difficult to observe key values over time and it
> can be difficult to correctly parse JSON in one’s head!
>
> It is proposed to add a new Python tool to usertools that will
> provide our users with a real-time, easy and visually appealing
> way to view statistics without leaving their terminals.
> The tool can provide various key statistics about any DPDK app
> in real-time. Various real-time graphs are available (using plotext),
> which makes visualizing the metrics easier.
>
> The tool runs completely in terminal and is responsive to any
> terminal size down to 80 characters.
> The TUI is provided using the rich Python module.
>
> The tool is already being used by some of Intel’s DPDK developers
> internally and we feel that it could be useful for the wider
> DPDK community.
>
> A talk about this new tool will be presented at DPDK userspace.
>
> Screenshot: https://cwalsh.tech/dpdk/tui3.png
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
This looks cool and works for me. Guess no one uses telemetry much
otherwise should have gotten accepted.
There are some python style things could be cleaned up:
$ flake8 --max-line-length=100 ./usertools/dpdk-telemetry-tui.py
./usertools/dpdk-telemetry-tui.py:347:5: E125 continuation line with same indent as next logical line
./usertools/dpdk-telemetry-tui.py:397:41: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:398:40: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:399:49: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:399:82: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:539:45: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:540:43: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:580:5: E125 continuation line with same indent as next logical line
./usertools/dpdk-telemetry-tui.py:637:5: E303 too many blank lines (2)
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-10-04 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:15 [PATCH 1/2] usertools/telemetry: move main to function Conor Walsh
2022-08-24 8:15 ` [PATCH 2/2] usertools/telemetry: add new telemetry client Conor Walsh
2022-08-31 11:52 ` [PATCH v2 1/2] usertools/telemetry: move main to function Conor Walsh
2022-08-31 11:52 ` [PATCH v2 2/2] usertools/telemetry: add new telemetry client Conor Walsh
2024-10-04 2:38 ` Stephen Hemminger [this message]
2022-08-31 11:55 ` [PATCH v2 1/2] usertools/telemetry: move main to function Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003193853.19863f3e@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).