From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, dev <dev@dpdk.org>
Subject: Re: [PATCH] doc: update TAP device features
Date: Fri, 4 Oct 2024 08:24:04 -0700 [thread overview]
Message-ID: <20241004082404.47f21091@hermes.local> (raw)
In-Reply-To: <Zv-fQyGS0SnVcVTi@bricha3-mobl1.ger.corp.intel.com>
On Fri, 4 Oct 2024 08:54:43 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Fri, Oct 04, 2024 at 05:09:21AM +0100, Ferruh Yigit wrote:
> > On 10/4/2024 3:26 AM, Stephen Hemminger wrote:
> > > On Fri, 4 Oct 2024 02:48:21 +0100
> > > Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> > >
> > >> On 9/4/2024 4:42 PM, Stephen Hemminger wrote:
> > >>> The TAP device does have per-queue stats and handles multi-process.
> > >>>
> > >>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > >>> ---
> > >>> doc/guides/nics/features/tap.ini | 2 ++
> > >>> 1 file changed, 2 insertions(+)
> > >>>
> > >>> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
> > >>> index f26355e57f..f2ea5cd833 100644
> > >>> --- a/doc/guides/nics/features/tap.ini
> > >>> +++ b/doc/guides/nics/features/tap.ini
> > >>> @@ -14,10 +14,12 @@ Basic stats = Y
> > >>> L3 checksum offload = Y
> > >>> L4 checksum offload = Y
> > >>> MTU update = Y
> > >>> +Multiprocess aware = Y
> > >>>
> > >>
> > >> ack
> > >>
> > >>> Multicast MAC filter = Y
> > >>> Unicast MAC filter = Y
> > >>> Packet type parsing = Y
> > >>> Flow control = Y
> > >>> +Stats per queue = Y
> > >>>
> > >>
> > >> This feature name is misleading,
> > >> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is
> > >> indeed for covering limitation for some drivers.
> > >> Tap does support getting stats per queue, but doesn't support above
> > >> documented feature.
> > >
> > > The stats queue mapping was a feature that was hinted at being removed.
> > > It only exists because of HW limitations on Intel ixgbe NIC and SW
> > > limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS.
> > >
> >
> >
> > We have a plan to remove 'RTE_ETHDEV_QUEUE_STAT_CNTRS', by moving queue
> > stats to xstats.
> >
> > But ixgbe limitation is there.
> >
> > > Perhaps there should be a generic SW emulation for this the mapping?
> > >
> >
> > Ack, cc'ed Bruce.
> > But I am not sure ROI of the effort at this stage.
>
> Not sure what the specific ask for me is here. :-) Overall, I think moving
> queue stats to xstats is the best way to go.
>
> /Bruce
The problem is that xstats are free form, so it is not possible for application
to use them in device independent manner.
next prev parent reply other threads:[~2024-10-04 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:42 Stephen Hemminger
2024-10-04 1:48 ` Ferruh Yigit
2024-10-04 2:26 ` Stephen Hemminger
2024-10-04 4:09 ` Ferruh Yigit
2024-10-04 7:54 ` Bruce Richardson
2024-10-04 15:24 ` Stephen Hemminger [this message]
2024-10-04 17:26 ` Ferruh Yigit
2024-10-04 20:40 ` Per queue stats Stephen Hemminger
2024-10-04 20:48 ` [PATCH] doc: update TAP device features Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004082404.47f21091@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).