From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8B9745AAF; Fri, 4 Oct 2024 17:24:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6753F402B2; Fri, 4 Oct 2024 17:24:09 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id D125E402A3 for ; Fri, 4 Oct 2024 17:24:07 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71b00a97734so2136732b3a.1 for ; Fri, 04 Oct 2024 08:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728055447; x=1728660247; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=PCPaQsT+WiwpNsBYwjrJCzC/VaR3xgp8PneBAIPCF2E=; b=CHUUpyPCElNPLsJdL2KHzwsWtGL2ZNBBJ1mSP+4N+NnhF791+xxKyXXMJ9IdA0mJcF GeEnodCrqk6jEtGtLZkQEne9l0u9u3TcNAGM7fgdEi2Mkudzog47cG4PD7Oi4+7vJw34 Z25iVDGyxo8agY/IYlIPbpTac6b0KL+L6cdbIsBFIdNdd8V/7mvkc0VFza4GfbuFGctn zrVBZOL7pqY5w13pd0vkgLj7wDO3Kl1dm9w0sO1TJSnRErAivq4PgU95WWcCnPzIW8ZL cX9njNhVFZSFeD/yS+OwYJEpHDTfCLaZppAWbeAnKRAobx1x6cBktG4Atzt6gooxaVin WZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728055447; x=1728660247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PCPaQsT+WiwpNsBYwjrJCzC/VaR3xgp8PneBAIPCF2E=; b=xRozxXu5FzdLRaZ5agL6AP8MsrTkOAyu6d0pWS0x116foznF3tU2le/nDRY75BUKNM 0Ut1BOA7ZR9aEapFJIHzK3FZY6wSCEXuN1KOiaIpAa5u6AlkFsV2I1g7HLhkcGDQeeEx oYXb02c7b6r0ssvZJHNlCQzNd67JAlM8tObvnA8yDgHspHRWlXkVphxgpEi7bdG0Aqpt CNm9YXis5ye9SazyDiqU5yp+KXxthECyAcmotlcSur41QKM2yemQhch6EhIG7s2kczUO H0fyUXqvkcsjBelbx79NAWaFewPS9fIocTxsHKN8eh6X9dUiYCWEfftz6CfZMdgjqXm4 KNwQ== X-Forwarded-Encrypted: i=1; AJvYcCWYR2daS9g/4ZycvoK3y4SGadsWhzVqer1gRgsNSiFwqJ99akdRQRDmyhs2ZJGp4me3g3c=@dpdk.org X-Gm-Message-State: AOJu0YyL6cw7pndjK8MBg3emfl+TuLZSjDAdLhEgrQ2ARZ/9yrjeMD09 uB51p4FUMbsUASqhdax2DTBCnIE/qCmIVMWNoUlCb+EYiUyfYHv2SRCivE9Hb78OsPBioMymShT A09QR5w== X-Google-Smtp-Source: AGHT+IFGbwBrbtSD7miUm6axuhmhoINuxNOekzl2NJAvFHBw5g31w/BN4q0qeDZILy5/pdSSfwS+Qg== X-Received: by 2002:a05:6a00:4b0a:b0:71d:d1b7:8dba with SMTP id d2e1a72fcca58-71de24454cfmr4056143b3a.18.1728055446769; Fri, 04 Oct 2024 08:24:06 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71dd9df333csm3341366b3a.180.2024.10.04.08.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 08:24:06 -0700 (PDT) Date: Fri, 4 Oct 2024 08:24:04 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Ferruh Yigit , dev Subject: Re: [PATCH] doc: update TAP device features Message-ID: <20241004082404.47f21091@hermes.local> In-Reply-To: References: <20240904154206.13438-1-stephen@networkplumber.org> <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> <20241003192612.3c5055dd@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Oct 2024 08:54:43 +0100 Bruce Richardson wrote: > On Fri, Oct 04, 2024 at 05:09:21AM +0100, Ferruh Yigit wrote: > > On 10/4/2024 3:26 AM, Stephen Hemminger wrote: > > > On Fri, 4 Oct 2024 02:48:21 +0100 > > > Ferruh Yigit wrote: > > > > > >> On 9/4/2024 4:42 PM, Stephen Hemminger wrote: > > >>> The TAP device does have per-queue stats and handles multi-process. > > >>> > > >>> Signed-off-by: Stephen Hemminger > > >>> --- > > >>> doc/guides/nics/features/tap.ini | 2 ++ > > >>> 1 file changed, 2 insertions(+) > > >>> > > >>> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini > > >>> index f26355e57f..f2ea5cd833 100644 > > >>> --- a/doc/guides/nics/features/tap.ini > > >>> +++ b/doc/guides/nics/features/tap.ini > > >>> @@ -14,10 +14,12 @@ Basic stats = Y > > >>> L3 checksum offload = Y > > >>> L4 checksum offload = Y > > >>> MTU update = Y > > >>> +Multiprocess aware = Y > > >>> > > >> > > >> ack > > >> > > >>> Multicast MAC filter = Y > > >>> Unicast MAC filter = Y > > >>> Packet type parsing = Y > > >>> Flow control = Y > > >>> +Stats per queue = Y > > >>> > > >> > > >> This feature name is misleading, > > >> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is > > >> indeed for covering limitation for some drivers. > > >> Tap does support getting stats per queue, but doesn't support above > > >> documented feature. > > > > > > The stats queue mapping was a feature that was hinted at being removed. > > > It only exists because of HW limitations on Intel ixgbe NIC and SW > > > limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS. > > > > > > > > > We have a plan to remove 'RTE_ETHDEV_QUEUE_STAT_CNTRS', by moving queue > > stats to xstats. > > > > But ixgbe limitation is there. > > > > > Perhaps there should be a generic SW emulation for this the mapping? > > > > > > > Ack, cc'ed Bruce. > > But I am not sure ROI of the effort at this stage. > > Not sure what the specific ask for me is here. :-) Overall, I think moving > queue stats to xstats is the best way to go. > > /Bruce The problem is that xstats are free form, so it is not possible for application to use them in device independent manner.