From: Stephen Hemminger <stephen@networkplumber.org>
To: suntianyuan <suntianyuan@baidu.com>
Cc: <chenbo.xia@intel.com>, <dev@dpdk.org>, <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v2] vhost: fix crash on vhost-user client port deletion
Date: Fri, 4 Oct 2024 09:04:06 -0700 [thread overview]
Message-ID: <20241004090406.34dc79c3@hermes.local> (raw)
In-Reply-To: <20230511145957.33904-1-suntianyuan@baidu.com>
On Thu, 11 May 2023 22:59:57 +0800
suntianyuan <suntianyuan@baidu.com> wrote:
> The rte_vhost_driver_unregister() and vhost_user_read_cb() can be
> called at the same time by 2 threads. reconn may be added back to
> reconn_list by vhost_user_read_cb() after rte_vhost_driver_unregister()
> removed from reconn_list. Then rte_vhost_driver_unregister free vsocket,
> cause vhost_user_client_reconnect access invalid vsocket memory.
>
> Timeline is as below:
> rte_vhost_driver_unregister thread execute vhost_user_remove_reconnect
> vhost_user_read_cb thread execute vhost_user_start_client add reconn to
> reconn_list
> vhost_user_read_cb thread free conn
> rte_vhost_driver_unregister thread cannot find conn, then execute
> vhost_user_socket_mem_free
> vhost_user_client_reconnect access invalid mem, crash
>
> Signed-off-by: suntianyuan <suntianyuan@baidu.com>
There is a test failure in the vf jumbo frames that needs evaluation.
And this kind of patch needs ack from Maxime.
prev parent reply other threads:[~2024-10-04 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 6:23 [PATCH] " suntianyuan
2023-05-11 8:26 ` Xia, Chenbo
2023-05-11 14:59 ` [PATCH v2] " suntianyuan
2024-10-04 16:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004090406.34dc79c3@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=suntianyuan@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).