From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B9EA45AAF; Fri, 4 Oct 2024 18:16:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D66B4279F; Fri, 4 Oct 2024 18:16:54 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 701C34025F for <dev@dpdk.org>; Fri, 4 Oct 2024 18:16:53 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20aff65aa37so20124435ad.1 for <dev@dpdk.org>; Fri, 04 Oct 2024 09:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728058612; x=1728663412; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=31gJmFng9YiNwhDWw/7CTG/DFtWA5VmafvmZtauZ4wc=; b=Aofrp9r1orE0wsLUNQ5+76AmrzvhgTqzEoiTgjV0y/hos4UycFX7akCWj9p4b9Vjba JZCYDksSoyYnY7Li58gQh/Ie9/urMGJjXSZPz/vS4cGYaxLHmqq5xP0EeARC//UwpdYJ O4PBBWhcPHqfTh6a6XXRVxYLpTpIQgOu+L7KkXYif6J3FUMVWFcDAGK2uhXWNMuEKvMQ qjXjz2TLuY1KFU7h7/8LYHXh46cf06twb27mxsiriUo5O/VoGdjll2l6QLO11sIuPyhn rZHwQAaJ9dMPEyhivbMnO1jDHEtYeKcvfYTjg+3XwpxG9eL0zTqmTvDTrIFhYOeWVoBj IpAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728058612; x=1728663412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31gJmFng9YiNwhDWw/7CTG/DFtWA5VmafvmZtauZ4wc=; b=GOQgwBXo49nEz/UJRQriaiCSxjxVC3ipsI7tAh4gaOmxyBn5t7bUz1Z4NYSWDzNp63 7I8eBm5LwtsMPQIXlIZpXq+c19N+N6V47NDVDOLb14FF0u6T7KTnUuCm+Hd3QvrWY+/d rSBYubirc7dT/6GRUudAKsHoThhaQ73eHNsB2BUXv5mlwKRGCKYnKXsq6p4Kf3vwUXDf 7xX2sh7erwbBoIIy+ULaKIdHESHIBx1m08o8j7IPpzegpvtqFGhc6aCH9MJO8VcTtbiN 2gUjVWTRMMPElSE1POI3dLIU8DuZl0IAPW7nHh/iEEAbOvDZEMs4kmzl2LwqDWV5GBbr aVng== X-Gm-Message-State: AOJu0YxcDXxkOR6XupRqgumV7HXtjKQD2G7IxgSIIvjwMByIoCvqZJvD un4w8Wq1VKdVzovTU5LY2yv7of1MCOCqw7P3hMPeUTSQYFhYL85z5pl9KtxqNcEqIHILQ2QZKCZ lr8iupA== X-Google-Smtp-Source: AGHT+IEapUXraI5smSW/+8AvliHIA8xHR9xnb+y3W+9hZE4rpaxunm0grFvLQ1JtmbjVb6bAYbgCXA== X-Received: by 2002:a17:902:e74e:b0:20b:ab74:f560 with SMTP id d9443c01a7336-20bff054cf5mr41591195ad.52.1728058612305; Fri, 04 Oct 2024 09:16:52 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138b1ab5sm361595ad.48.2024.10.04.09.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 09:16:52 -0700 (PDT) Date: Fri, 4 Oct 2024 09:16:47 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: "Robin Jarry" <rjarry@redhat.com> Cc: <dev@dpdk.org>, "Vladimir Medvedkin" <vladimir.medvedkin@intel.com>, "Bruce Richardson" <bruce.richardson@intel.com> Subject: Re: [PATCH dpdk v2 14/16] rib6,fib6,lpm6: remove duplicate constants Message-ID: <20241004091647.06794293@hermes.local> In-Reply-To: <D4N02SY9O8IS.90HIGXJT51EC@redhat.com> References: <20240821162516.610624-17-rjarry@redhat.com> <20241001081728.301272-1-rjarry@redhat.com> <20241001081728.301272-15-rjarry@redhat.com> <20241003161205.5ef4b0b6@hermes.local> <D4N02SY9O8IS.90HIGXJT51EC@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 04 Oct 2024 13:54:42 +0200 "Robin Jarry" <rjarry@redhat.com> wrote: > Stephen Hemminger, Oct 04, 2024 at 01:12: > > On Tue, 1 Oct 2024 10:17:26 +0200 > > Robin Jarry <rjarry@redhat.com> wrote: > > > >> Replace all address size and max depth macros with common ones from > >> rte_ip6.h. > >> > >> Signed-off-by: Robin Jarry <rjarry@redhat.com> > > > > This looks good but since these #defines are in public headers you need > > to leave a copy (with __rte_deprecated) around for a couple of releases > > so that userspace is notified. > > I'm not sure how to indicate that a macro is deprecated. Do I need to > change it to a variable? > You can do something like: #define RTE_FIB6_MAXDEPTH RTE_DEPRECATED(RTE_FIB6_MAXDEPTH) RTE_IPV6_MAX_DEPTH The part in the middle will cause warning if used.