From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C496D45AAF; Fri, 4 Oct 2024 18:35:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC7E340649; Fri, 4 Oct 2024 18:35:04 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 497E34029F for ; Fri, 4 Oct 2024 18:35:03 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-71def8abc2fso277073b3a.1 for ; Fri, 04 Oct 2024 09:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728059702; x=1728664502; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BSW0Be6U9H7owIwlbjv6IZoNcyHwbM9iOPWvbUTkVGY=; b=KVr3w+QiSVfEOe3sw8PjY5gv5vJ4MAI5IID+kKkHAEKWgsV2R/hR2E57afixziBeZl El6eHqEhUzguU6DtNNS0OabhxjbiFx0bocwxnE6DfKSCqHwES4Iomh/Lh68dDW1N7GM/ VvVuzbXeT+AscdDHhnVYe4ANNXNxbhtHqdR0Ngkbpt6zW2MG4t9wnxaQfYLnnXJ0Xptn fr8WdjfHADgfSjCwvB3BrLlTcNGLk3HO2FjR2ekvSDuUvdTuGSnQN4XG5SLvgHUX3E2t aXNlL38ubEehaOP2+6eawVVHpyUb8i505q3vrcUAEYx+bvy8B2Xtz00HsRdaLQGwmBYZ NadA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728059702; x=1728664502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BSW0Be6U9H7owIwlbjv6IZoNcyHwbM9iOPWvbUTkVGY=; b=E/4ei6q/y0BowbGbdHv6Rfj+EbtFccZddmZ7VEvObgLdYNA/1PUQdf8iOI+0dcjYFA 4k5wd/dyxOGDXbqrFC+6RYefR+8NdPNbXhzOasI/HmUNzPWPYT7iMHvbb/4HOJKsIxk1 SiyJUy9uMsrVaFmQxqgVeRijgOzPCUtG13Sv6CvKwC/Z7vS1HvETVdAaIuaEccJNxCk7 RU7l4sCsfhUbHq0ZnsmBPSP05ebQ9fsB7sNEZLsJ8HxUbDcd6DowS6YG7td/2C90bPDN Yy19FcEGTgr6wevaQdPBFyy5eWXpQ5aP0U6yM836+df1jbx4StoPgVSMZgKxnVNjq3o0 SqXw== X-Forwarded-Encrypted: i=1; AJvYcCUsgaLc+xesx7/O0Ef1U9mRN2H8LAYF0hizmK4rQi1JV03JQAcOz3jWo6KsSj+FcfOOKbU=@dpdk.org X-Gm-Message-State: AOJu0YykwDnWey6cz5gsXK7zw2SXatYC9rlkWsw7kxiIFCph+0GD/8NQ t+fRLVDZtjnMtHS4TYTX3OzLNpNI0VklfK3obdA0kmfmd3XUf9j+7sZsyEyKWRs= X-Google-Smtp-Source: AGHT+IGzUVH5Bt2S+aBxReykhjLS3aEy3Iv7hABpv37Q6hvQvkD6k+/gSqsLGgqK9yuD/1dvUlDDEw== X-Received: by 2002:a05:6a00:4fd3:b0:714:3de8:a616 with SMTP id d2e1a72fcca58-71de2449f43mr4827999b3a.19.1728059702394; Fri, 04 Oct 2024 09:35:02 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0d66475sm47331b3a.149.2024.10.04.09.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 09:35:02 -0700 (PDT) Date: Fri, 4 Oct 2024 09:35:00 -0700 From: Stephen Hemminger To: Cc: , , , , , , , , , Subject: Re: [PATCH v5 0/6] Introduce event pre-scheduling Message-ID: <20241004093500.4826372a@hermes.local> In-Reply-To: <20241004162451.6842-1-pbhagavatula@marvell.com> References: <20241001131901.7920-1-pbhagavatula@marvell.com> <20241004162451.6842-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Oct 2024 21:54:45 +0530 wrote: > From: Pavan Nikhilesh > > Event pre-scheduling improves scheduling performance by assigning events > to event ports in advance when dequeues are issued. > This series introduces various types and levels of pre-scheduling to the > eventdev library. > > pre-scheduling Types: > * RTE_EVENT_PRESCHEDULE_NONE: No pre-scheduling. > * RTE_EVENT_PRESCHEDULE: Always issue a pre-schedule when dequeue is issued. > * RTE_EVENT_PRESCHEDULE_ADAPTIVE: Delay issuing pre-schedule until there > are no forward progress constraints with the held flow contexts. > > pre-scheduling Levels: > * Event Device Level Pre-scheduling: Pre-scheduling can be enabled or disabled at the > event device during configuration. Event devices can indicate pre-scheduling > capabilities using `RTE_EVENT_DEV_CAP_EVENT_PRESCHEDULE` and > `RTE_EVENT_DEV_CAP_EVENT_PRESCHEDULE_ADAPTIVE` via the event device info > function `info.event_dev_cap`. > * Event Port Level Prefetch: Pre-scheduling can be selectively enabled or disabled > at the event port during runtime. Event devices can indicate this capability > using `RTE_EVENT_PORT_CAP_PER_PORT_PRESCHEDULE` via the event device info > function `info.event_port_cap`. > * Application Controlled Prefetch Hint: Applications can provide hints to the > event device to start pre-scheduling events using the new API > `rte_event_port_pre-schedule`. Event devices can indicate this capabilities using > `RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT` via the event device info function > `info.event_dev_cap`. > > The rte_event_dequeue_burst operation initiates the pre-schedule operation, which > completes in parallel without affecting the flow context of the dequeued events and > dequeue latency. On the next dequeue operation, the pre-scheduleed events are > dequeued, and pre-schedule operation is initiated again. > > In the case of application-controlled pre-schedule hints, the currently held flow > contexts, if any, are not affected by the pre-schedule operation. On the next > dequeue operation, the pre-scheduleed events are returned, but pre-schedule is not > initiated again until the application provides the hint again. If pre-scheduling > is already enabled at the event device level or event port level, the hint is ignored. > > v2 Changes: > - s/prefetch/pre-schedule (Mattias). > v3 Changes: > - Add CNXK preschedule implementation. > - Update test-eventdev to use prescheduling. > - Update examples to use prescheduling. > v4 Changes: > - Fix compilation. > v5 Changes: > - Update ABI changes > - s/RTE_EVENT_DEV_PRESCHEDULE/RTE_EVENT_PRESCHEDULE/ > - s/RTE_EVENT_DEV_CAP_SW_PRESCHEDULE/RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT/ > - s/RTE_EVENT_PORT_CAP_EVENT_PER_PORT_PRESCHEDULE/RTE_EVENT_PORT_CAP_PER_PORT_PRESCHEDULE > - Various documentation fixes and updates. > > > Pavan Nikhilesh (6): > eventdev: introduce event pre-scheduling > eventdev: add event port pre-schedule modify > eventdev: add event preschedule hint > event/cnkx: add pre-schedule support > app/test-eventdev: add pre-scheduling support > examples: use eventdev pre-scheduling > > app/test-eventdev/evt_common.h | 45 +++-- > app/test-eventdev/evt_options.c | 17 ++ > app/test-eventdev/evt_options.h | 1 + > app/test/test_eventdev.c | 143 ++++++++++++++++ > doc/guides/eventdevs/cnxk.rst | 10 -- > doc/guides/eventdevs/features/cnxk.ini | 1 + > doc/guides/eventdevs/features/default.ini | 1 + > doc/guides/prog_guide/eventdev/eventdev.rst | 48 ++++++ > doc/guides/rel_notes/release_24_11.rst | 13 ++ > doc/guides/tools/testeventdev.rst | 6 + > drivers/event/cnxk/cn10k_eventdev.c | 19 ++- > drivers/event/cnxk/cn10k_worker.c | 21 +++ > drivers/event/cnxk/cn10k_worker.h | 2 + > drivers/event/cnxk/cnxk_eventdev.c | 2 - > drivers/event/cnxk/cnxk_eventdev.h | 1 - > .../pipeline_worker_generic.c | 6 + > .../eventdev_pipeline/pipeline_worker_tx.c | 6 + > examples/ipsec-secgw/event_helper.c | 6 + > examples/l2fwd-event/l2fwd_event_generic.c | 6 + > .../l2fwd-event/l2fwd_event_internal_port.c | 6 + > examples/l3fwd/l3fwd_event_generic.c | 6 + > examples/l3fwd/l3fwd_event_internal_port.c | 6 + > lib/eventdev/eventdev_pmd.h | 4 + > lib/eventdev/eventdev_private.c | 41 ++++- > lib/eventdev/eventdev_trace_points.c | 6 + > lib/eventdev/rte_eventdev.h | 159 ++++++++++++++++++ > lib/eventdev/rte_eventdev_core.h | 14 +- > lib/eventdev/rte_eventdev_trace_fp.h | 19 ++- > lib/eventdev/version.map | 6 + > 29 files changed, 592 insertions(+), 29 deletions(-) Looks good, but the new API's should be experimental right?