From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D1C445A7C; Fri, 4 Oct 2024 19:36:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04C7B42DA3; Fri, 4 Oct 2024 19:36:06 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 58F4242DA3 for ; Fri, 4 Oct 2024 19:36:04 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2e077a4b8c0so1766352a91.1 for ; Fri, 04 Oct 2024 10:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728063363; x=1728668163; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Miu5wflKHcjtimjuCCkbt0ML5Es9hqWAVz5tQXbGYEQ=; b=frBz3LJruumWWjzrL3Q9jY6UBiLvqMB3xkXGj7+BtLu6Dd/KL7EelmWDc5/ZIXMS8d cRwxehu3xZgAQxzbvXa/OoiukLh72d22tuxeVSx88kY0SLBmSiOGncqPvbk48FsAEzDe S+RoK25eVco6NeoPEFVIMWQYaTovmg2cDjzEFUI0A7v2cjG0mMwE8u1Om7xGdvr0vP9Z gWzHPKgKOPsQAHimKnOCOzrcqMXyn3kGpmbzM8bqnFiAXRHx6Hwzyrgn/G3jcXiehjXF ntNzoBH2/e9mCqF6quq+3zxD6Q4C79aSM2nQsmi43b8Xu8tGBa9daGHbpK/6j6TCVoRt 6rJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728063363; x=1728668163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Miu5wflKHcjtimjuCCkbt0ML5Es9hqWAVz5tQXbGYEQ=; b=T/rMZ2bYLEvnxmMiJ0NoiJLfgHxLqOthqo9TPlZpjjMycV5ECwKicJWPGZ/sxlyxb6 nwdCdSSiA7ZbWDaXGaJRQuKcJ8RyfoTivIl/yGRT/cQNHmzLhSBKbD6SCkuMRwqmfboY QzIJ2hsX+WUBGEdnrR2ZL2eGq6e61q3Wf4wsCZp1Xmh3mUuekAGx7F25zTGctmdLJzA7 SG8jjyWXNtJ4mC8dMJMTgytGzOECfuSOuNzBzJiatFned7BewB+k27+wC3EuNeKKBNAe XR3snxrTtdWCrd04hUkrJc4/Ivj8MhCe3wui0kBJamkUEsac4pG/ZVaAvFOg8elbN0lH gsdA== X-Forwarded-Encrypted: i=1; AJvYcCVkjzHZ96uXvDMj6gabWJbAt3QJkvclLn41jAdG1k+q29QcBIm+jR9Nw9SXWWtXOsGTH/w=@dpdk.org X-Gm-Message-State: AOJu0Yy9+zNuhnq3lADbFyYUZXYnICyCPFw1n/JfqYBayd/2wq6s7eV7 MqphngGLFN3lj5DLm3F7UIvOitrm1Gy4hOAfC8TMzZ+kahSm74qdKXJ4WXQj0XE= X-Google-Smtp-Source: AGHT+IEg5W8d9wsbux+G/jDf2OWtd7SJBGSFuMCvOvOjjH3lpyFDfzdRyfAiN+BmmDVCC0SKUCSOew== X-Received: by 2002:a17:90a:f2c9:b0:2d8:e6d8:14c8 with SMTP id 98e67ed59e1d1-2e1e5da4102mr5364997a91.15.1728063363319; Fri, 04 Oct 2024 10:36:03 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e20b128847sm171548a91.49.2024.10.04.10.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 10:36:03 -0700 (PDT) Date: Fri, 4 Oct 2024 10:36:01 -0700 From: Stephen Hemminger To: "Jianyue Wu" Cc: "Tyler Retzlaff" , ferruh.yigit@amd.com, "dev@dpdk.org" , "jianyue.wu@nokia-sbell.com" Subject: Re: [PATCH v2] eal/linux: enhanced error handling for affinity Message-ID: <20241004103601.04ed3885@hermes.local> In-Reply-To: <5afd96e5.d333.18f24ab9f10.Coremail.wujianyue000@163.com> References: <20240425111130.8306-1-wujianyue000@163.com> <20240426154737.GB27008@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20240426171853.7649b935@hermes.local> <5afd96e5.d333.18f24ab9f10.Coremail.wujianyue000@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 28 Apr 2024 20:26:18 +0800 (CST) "Jianyue Wu" wrote: > Yes, agree with that, there is also trace from kernel can see that. I'll ignore this patch. > > > At 2024-04-27 08:18:53, "Stephen Hemminger" wrote: > >On Fri, 26 Apr 2024 08:47:37 -0700 > >Tyler Retzlaff wrote: > > > >> > int > >> > -- > >> > >> i do not think introducing os specific behavior/logging to the EAL > >> is a good idea. logging although not formally part of the api surface > >> should present the same experience for all platforms. the EAL should > >> have a higher standard here. > >> > >> > 2.34.1 > > > >For this case, the error message would be better if there was some way > >to look at the cgroups and mark the cores that are not available as if > >they were offline lcores. > > > > The current behavior is good enough. If application has an issue with affinity because of cgroups or something else, then the developer is going to need to investigate and adding another message in EAL is not going to help. And introducing #ifdef is adding unnecessary special cases.