From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6B7D45AB0; Fri, 4 Oct 2024 22:41:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B38F5402ED; Fri, 4 Oct 2024 22:41:01 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id A83B2402B7 for ; Fri, 4 Oct 2024 22:40:59 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-71def18fe1cso436745b3a.0 for ; Fri, 04 Oct 2024 13:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728074458; x=1728679258; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6P1suI57UFXHeRZM8sogr0J/Ft1H/kqYNxT4HkeNUBA=; b=jC7Y999dwM9Ah00OVnmsuutllRCM55DMNOnqZAOPmhiLmBVxT2ZYUWxP8XW93jvW00 5VV46vf/V7Ps0nQQXP15hO6r6kqM3YSHQnvD26HNOI7j1u7VeRRGgtdgPQ3c2VO5GPHB 6g8y3yYtCnacE05hbRvq1d/8tAM3bz/dFz1ZTlco3eCOtHokeQ8kT55XywLVHsxlDM7Z kw3/nB7I2fK/+pEmQMSTLGXgKTJqn/7yHmHVIUvRDpGc+8q3I0GlRPgMN0ZcwbNWV54D o9R25MPRVkJF+kp12LLL6i/4qGBlgSRMi/FEgaq7lwYiguXL7irKOSZYanmA5aTMh3BF twZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728074458; x=1728679258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6P1suI57UFXHeRZM8sogr0J/Ft1H/kqYNxT4HkeNUBA=; b=voY71/rCrVM86SH86zYLA0g0hMevl/Kl5x70OYASc50ii4bKu8mgTZjyI0wL0TlCc8 tcon7Mn2SXRmhbv5uo+qicwvPa1a1J2CczS9enAZqY2TNNlnjoCygDcmQfinNWGXV9Im oPZYQIt0d7DKvEUAIq5kgLAitvxJSuL49/ll2527tBbaziQ6xK7OKwHY+YjmWHsssQdY FLWDuP9d23Dq0fe5INqon8KVrg/BucH0HMGk8t3K/0xR0lvixVl+R46rJE1pH3L+u0TH xdNo+F3/LJZHrwjoBPWxVwW3Np0ViWRgIHBg5b+s8nx+HDfuJEvQ1NfIgimZANV9Rbb1 DS9g== X-Forwarded-Encrypted: i=1; AJvYcCUyDN9VSEDTshQa1N++nervi3OQBWxiPprxdx2wDEiJ48M7yfnCRrl3teDc6FhWulKlpRQ=@dpdk.org X-Gm-Message-State: AOJu0YzmL+KXGkBzczc2aSa7x/1Kz7OvTqxPHcIUrjdq5OA6jLj0rzhl YTiZa+sL8GSxLA/2bbozTQ/du+H426gP2aaO1eYP5fGxol6aPQhp7oTunGYOZJU= X-Google-Smtp-Source: AGHT+IHYlzEyECopDOWXzmDnAyomMxtov7IfPOpbtvPyn2NFps4/bw9p0XKdQnuUuTKN0QCRWYEsdw== X-Received: by 2002:aa7:8e0e:0:b0:717:9897:1405 with SMTP id d2e1a72fcca58-71de2439b2dmr5083367b3a.17.1728074458394; Fri, 04 Oct 2024 13:40:58 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0d452a9sm283529b3a.123.2024.10.04.13.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 13:40:58 -0700 (PDT) Date: Fri, 4 Oct 2024 13:40:56 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Bruce Richardson , dev Subject: Per queue stats Message-ID: <20241004134056.25d9e361@hermes.local> In-Reply-To: <2782da8e-1de0-467c-8139-874184c470d2@amd.com> References: <20240904154206.13438-1-stephen@networkplumber.org> <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> <20241003192612.3c5055dd@hermes.local> <2782da8e-1de0-467c-8139-874184c470d2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ... > >>> The stats queue mapping was a feature that was hinted at being removed. > >>> It only exists because of HW limitations on Intel ixgbe NIC and SW > >>> limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS. > >>> > >> > >> > >> We have a plan to remove 'RTE_ETHDEV_QUEUE_STAT_CNTRS', by moving queue > >> stats to xstats. > >> > >> But ixgbe limitation is there. > >> > >>> Perhaps there should be a generic SW emulation for this the mapping? > >>> > >> > >> Ack, cc'ed Bruce. > >> But I am not sure ROI of the effort at this stage. > > > > Not sure what the specific ask for me is here. :-) Overall, I think moving > > queue stats to xstats is the best way to go. > > > > cc'ed because of "generic SW emulation" comment. > > I was thinking if this mapping can be done transparent to the user by > driver mapping queue <-> stats_register before reading stats, but @Bruce > let me know this won't work because the stats tracking only happens > after the mapping. > > @Stephen, do you have something specific in your mind for SW emulation > for mapping? Probably not worth doing mapping tables for SW drivers. My preference would be something like: 1. Introduce new API's rte_ethdev_get_queue_stats() and rte_ethdev_reset_queue_stats(). with callbacks in ethdev ops. if driver does not support this, then do a shim in ethdev that uses old stats fields. 2. Mark the stats mapping API's as deprecated and always return error. Making special case for ixgbe at this point really is not worth maintaining. 3. After all drivers converted over, drop the fields in ethdev stats for queues. And fix the examples, etc. Yes this would be a big API change. Would take a year to get done (ie 25.11).