From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CCBE45AB0; Fri, 4 Oct 2024 22:48:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FB56402ED; Fri, 4 Oct 2024 22:48:46 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 5383F402B7 for ; Fri, 4 Oct 2024 22:48:45 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20b0b5cdb57so27160585ad.1 for ; Fri, 04 Oct 2024 13:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728074924; x=1728679724; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Hyu7oVd89vGmDhOadDKloU3AvV8Sfy+orMx5dG8axi8=; b=NswTer/irY8D8Z0fbH9xYFT0h/tZz5f5cTDmWEfryRPKMPGSQ1C3vJ1CKL0H/yAMiW UA6NJNXybuIy5oL0i7BzXP52Ze9WCwoBAxCxGi20S1b0qhsFvx6Xqxeq45efjr2Xt8jC OKrp/WnquewW9aQmJZl+49f4TBNLQ3Z3QdeDoEBqYWQ0NJRvTEYiLpXybZxKFHh0KdDl CJslS3ljE66w4VJKNq77YEwzi3WEt9WOgqk63SpTalluHoKI5r8J0uMRdtgLX1cohiBl TUVFrJYqrUpK/NkERtX0foslwsf+u9dFuEZilkMoRLSRjaoiOlRNpAdC/z7pG2H41bd7 HS2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728074924; x=1728679724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hyu7oVd89vGmDhOadDKloU3AvV8Sfy+orMx5dG8axi8=; b=tYKrP8wLO3Qt2cO09ALN3HjrktsAu0Gtq8XITqOzEJ8NdWjXvNokLwbnJti6maQ30Z L9OQ67W5RXkDDOXknunIeEq/bTdMyUhjc89coF0eN49nvC17KN8JPSV/L6Enq5x2Kaz+ x9YoBP3pFn/gkluz2oqzZm2SdmKal58ywzePiZJ5kxYiczAVzUFl8cpFWzz7Et0Yf6F5 4TfXGgsMilsK0JHLPWMwU5VquEJ4VN4DkkWJMX0kdVj9qihw/K7f6XtG9ntsr9xakXnO 0zh6WY7j827/3bYn1v7W+S0tLOLf9anNxXIqx0sr254wTvRyajs8eMQX4CRqCZpfdPpi IOsw== X-Gm-Message-State: AOJu0Yz2dTWTYcSiFRL+w1VMc0W08xJHTPPKJ/F23lq4gzH76mJiz+HZ bx+RWbd7/dZxmy5UQ9/yeduEBvV42K5ZltIf94+Kqw6yZL4cRpmaMHgt6cexCtY= X-Google-Smtp-Source: AGHT+IHuxrzdmLOfQwffUgxlTAfe7RB9ft2FguTWGL6V8WbM05WT0Mn/IHVpdrJBFprel++U4bK9/Q== X-Received: by 2002:a17:903:1247:b0:205:5c06:39e6 with SMTP id d9443c01a7336-20be176ce3cmr119908265ad.0.1728074924348; Fri, 04 Oct 2024 13:48:44 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c139a408csm2555135ad.307.2024.10.04.13.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 13:48:44 -0700 (PDT) Date: Fri, 4 Oct 2024 13:48:42 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH] doc: update TAP device features Message-ID: <20241004134842.0fd518ab@hermes.local> In-Reply-To: <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> References: <20240904154206.13438-1-stephen@networkplumber.org> <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Oct 2024 02:48:21 +0100 Ferruh Yigit wrote: > > +Stats per queue = Y > > > > This feature name is misleading, > it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is > indeed for covering limitation for some drivers. > Tap does support getting stats per queue, but doesn't support above > documented feature. Just looked and the current state of the feature matrix is not correct for this part of the table. Although the feature intro says it is stats per queue mapping, that is not what other drivers are doing. Only these drivers have queue_stats_mapping_set: cnxk, enic, igc, ixgbe, txgbe, virtio These drivers claim to have 'Stats per queue' but do not have stats mapping: af_xdp, ark, atlantic, avp, bnxt, cxgbe, failsafe, fm10, hinic, hns3, ionic, mlx4, mlx5, netvsc, nfb, nfp, ngbe, qede, thunderx, vmxnet3 So the overwhelming practice is that the features.rst description is wrong!