From: Stephen Hemminger <stephen@networkplumber.org>
To: jhascoet <ju.hascoet@gmail.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: [PATCH] app: enhance error check if enqueue fail in test_mbuf test_refcnt_iter
Date: Fri, 4 Oct 2024 14:18:28 -0700 [thread overview]
Message-ID: <20241004141828.720c7a2c@hermes.local> (raw)
In-Reply-To: <20230824073718.718872-1-jhascoet@kalray.eu>
On Thu, 24 Aug 2023 09:37:18 +0200
jhascoet <ju.hascoet@gmail.com> wrote:
> From: Julien Hascoet <ju.hascoet@gmail.com>
>
> As the ring is big enough by construction, the ring
> enqueue ops cannot fail; therefore, we check and panic
> on it as soon as it is detected.
>
> Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
> ---
As per earlier patch in the email thread.
This is a test for something that should never happen.
Adding that test code is good and bad. Good, tests should never assume
code works. Bad, it creates more paths and complexity in the test code.
If the test was broken, and enqueue fails, it would fail in later checks
because of unfreed mbuf's.
Bottom line: lets skip this patch, it only happened to the submitter
because of other problems in their environment.
prev parent reply other threads:[~2024-10-04 21:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 5:38 [PATCH] app: fix silent " jhascoet
2023-08-09 9:18 ` David Marchand
2023-08-10 6:00 ` jhascoet
2023-08-10 15:33 ` Stephen Hemminger
2023-08-10 15:40 ` [PUB] " Julien Hascoet
2023-08-10 16:09 ` jhascoet
2023-08-18 5:16 ` Hascoet Julien
2023-08-18 6:25 ` David Marchand
2023-08-22 6:34 ` jhascoet
2023-08-22 8:34 ` Olivier Matz
2023-08-24 6:51 ` Hascoet Julien
2023-08-30 16:16 ` Thomas Monjalon
2023-08-24 7:37 ` [PATCH] app: enhance error check if " jhascoet
2024-10-04 21:18 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004141828.720c7a2c@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ju.hascoet@gmail.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).