From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2116245AB0; Fri, 4 Oct 2024 23:18:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FD294329A; Fri, 4 Oct 2024 23:18:34 +0200 (CEST) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by mails.dpdk.org (Postfix) with ESMTP id 69887402EB for ; Fri, 4 Oct 2024 23:18:32 +0200 (CEST) Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-e251eda7f03so2158980276.0 for ; Fri, 04 Oct 2024 14:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728076711; x=1728681511; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/OFq0wLrViFhlivAcY0FKPvq78oeX9/TDarsRXIbLXY=; b=Fn4okrAynH1mJK1q5E3ZfKdf9jlzdwGhytHGHPdKASXrtlm23/5IVvQ5csRShXX0/+ bEruP0r8KI6QheevnNYUu166RpwG09k3FsAId6KTEi7XW5Suvy2cbVhATVuFYn6M3nWY i9EndY0M3X/5NxI0zOjd9E4OwXSKKc5puxNwGkCpFc131weJFBzPoHZnrmAW0uXLYHRs GLKOsOPTilySyxHTGcredorMl68eHZS5ddJJnXvSZ48mmffJEfgokl+3u5D9AE+UNeXB GIFgvPKzMt6O7OCh9q5gC5vcqvlCGXXVmKpGABdOa+Hnh5noIL3zDMyFDQk5bUA3XP/q dszQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728076711; x=1728681511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OFq0wLrViFhlivAcY0FKPvq78oeX9/TDarsRXIbLXY=; b=ViX3m+osV1UsVOXLQDPysNi6v/+bryyhA8QMu/EL9g8JAUp1yCmwrV+ildhPRSHb8W sSXaL9u9bOQ/6WvAKb/Ep2UraWX17EYCzS7bnd0aJIAgje4E9NrjqTWp0H6vN3Ephcc6 Iqvf1xNEhuIqVm8cIjGZT/KEZuO6AzuEOXplMl9k3MU3l8rev0xQFEL7Cf749cJmjAoc 7FqxkHauT9AYInSvqeBqpSdYOyMhjCGzbrqqFJwM4Dxik7z6BWxFMMykLf/7Os4EH++4 Ti+Pqer5aGa7q5EPOGCWcCNOKnOEnCrhawgc8MVJZRePyzT1urur7l1yRrQ0Z/0MVuBY Iaxg== X-Forwarded-Encrypted: i=1; AJvYcCUZrrX32ScHmyx5emv4/ai13q7mvXWzT8jjL0vcbQli2i4c+HX56X4Xq9gqTqR+W1/FD5I=@dpdk.org X-Gm-Message-State: AOJu0YyYjNzYmMkmOmChItl+wDEZ+QMd/YQROqFuiEUIsfxio6jIkUad s0Gb36vkP4kaxMZiXwy7t8hxeaBQVlN4VkRQ4kX51psW71keph2Un5SjaHA+4aq5uEi0sDVJ9ka r88eICw== X-Google-Smtp-Source: AGHT+IEKj929RHjTVYlXKO3UEKoPFUi4YS2HK9+YMz5OvBiDWA4XDd2c8XI1bR25Z75+mfG6SRluzg== X-Received: by 2002:a05:6902:a8c:b0:e1a:90ef:3b6d with SMTP id 3f1490d57ef6-e286f7f5d68mr6262433276.7.1728076711531; Fri, 04 Oct 2024 14:18:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e28a5c4f923sm89505276.27.2024.10.04.14.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 14:18:31 -0700 (PDT) Date: Fri, 4 Oct 2024 14:18:28 -0700 From: Stephen Hemminger To: jhascoet Cc: olivier.matz@6wind.com, dev@dpdk.org Subject: Re: [PATCH] app: enhance error check if enqueue fail in test_mbuf test_refcnt_iter Message-ID: <20241004141828.720c7a2c@hermes.local> In-Reply-To: <20230824073718.718872-1-jhascoet@kalray.eu> References: <20230810160941.3895855-1-jhascoet@kalray.eu> <20230824073718.718872-1-jhascoet@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 24 Aug 2023 09:37:18 +0200 jhascoet wrote: > From: Julien Hascoet > > As the ring is big enough by construction, the ring > enqueue ops cannot fail; therefore, we check and panic > on it as soon as it is detected. > > Signed-off-by: Julien Hascoet > --- As per earlier patch in the email thread. This is a test for something that should never happen. Adding that test code is good and bad. Good, tests should never assume code works. Bad, it creates more paths and complexity in the test code. If the test was broken, and enqueue fails, it would fail in later checks because of unfreed mbuf's. Bottom line: lets skip this patch, it only happened to the submitter because of other problems in their environment.