From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5F56045AAF;
Fri, 4 Oct 2024 17:08:39 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 58B1042797;
Fri, 4 Oct 2024 17:08:10 +0200 (CEST)
Received: from egress-ip11a.ess.de.barracuda.com
(egress-ip11a.ess.de.barracuda.com [18.184.203.234])
by mails.dpdk.org (Postfix) with ESMTP id 8EC8E410FC
for <dev@dpdk.org>; Fri, 4 Oct 2024 17:08:04 +0200 (CEST)
Received: from EUR02-VI1-obe.outbound.protection.outlook.com
(mail-vi1eur02lp2049.outbound.protection.outlook.com [104.47.11.49]) by
mx-outbound8-201.eu-central-1a.ess.aws.cudaops.com (version=TLSv1.2
cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
Fri, 04 Oct 2024 15:08:04 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=C9fhRWjILzCL4eiWdxeFQJggJHb6HQNprVXVQiY8GVnifgJH6B+w983QdgSuWeJ4H1KDEWv2vIHOjfHEf804p0TH+dxm0CeOdYZtDJ/uqpGErTUDsSroXgNDmyB1gY/oHoEcphprOiqt7LZLk+qXdt7nMwbetD+a+jNya0wNi/cT+MgKgiXgWOgvJSTHlu9e/evf8pNVPzsN0yOFjGVp8CY2Se3Uy0gJdEI+nOulevr4CIuMGn1mHTE/4rXTuI370RYrhcqHajQfdPh87SEHBj37rW0sdDEcAabHmXnLnbfTpkSfjuTxODxHC36AqGp/ahASRuvHgoON8XQodXmPIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=76Z5PdSX5ahAcGWPUhzBAP2hMQNbeRKcAltgsSf2l7w=;
b=IBZPFGDXHUBsl/drLnn/p4Uc59mmj9bC/cq2JCl96pFlEEqHm7gNHoSIefI845aYxVghk6PWu/i2bZhWn8Lpe9jFHgiI++paD8yXmuaWa2a9Nm6xmYFoEqQXGvhwxymCF9e17kwLYW68cRRPk5ysRC0nzQIk1xCVgZtMRj4HOEOSQcacjwEfxdC3jftIQOcIyZx+LESZ1MR2bgBV8NqeuFPZC6b+/duo06L4z0KxYRU4yuqp/se3l67+H0m+3sTLGiOL6maCsNX2wDK6XbuWpU1SGBR+nccGhISMtZpF3ScEzVdEsxLxWlyVuqWMlxdFsHK5PBpeLjQ1G4nFsOuFoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is
178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com;
dmarc=fail (p=reject sp=reject pct=100) action=oreject
header.from=napatech.com; dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=76Z5PdSX5ahAcGWPUhzBAP2hMQNbeRKcAltgsSf2l7w=;
b=NAS8CefrNbScah7a4tFA2lKn44Pl1ZQ0g4hiBlZoCu8o7WYhZ3f2I6FhV05zJUVsk/ccU4HxFPnvBzSngVvccq36wsmvEcpyiHup6t8INRs1vzQmEGnYinhSJD+wdqz/6sNJS38FgblI2ObtWWgkEbPl6AZpGZe22Wn9i54Oga8=
Received: from AM0PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:208:3e::19)
by AM9P190MB1089.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:26c::23)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18; Fri, 4 Oct
2024 15:08:01 +0000
Received: from AMS0EPF000001AC.eurprd05.prod.outlook.com
(2603:10a6:208:3e:cafe::d4) by AM0PR02CA0006.outlook.office365.com
(2603:10a6:208:3e::19) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18 via Frontend
Transport; Fri, 4 Oct 2024 15:08:01 +0000
X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4)
smtp.mailfrom=napatech.com; dkim=none (message not signed)
header.d=none;dmarc=fail action=oreject header.from=napatech.com;
Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not
designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com;
client-ip=178.72.21.4; helo=localhost.localdomain;
Received: from localhost.localdomain (178.72.21.4) by
AMS0EPF000001AC.mail.protection.outlook.com (10.167.16.152) with Microsoft
SMTP Server id 15.20.7918.13 via Frontend Transport; Fri, 4 Oct 2024 15:08:00
+0000
From: Serhii Iliushyk <sil-plv@napatech.com>
To: dev@dpdk.org
Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com,
andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com,
Oleksandr Kolomeiets <okl-plv@napatech.com>
Subject: [PATCH v1 4/5] net/ntnic: remove extra calling of the API for release
port
Date: Fri, 4 Oct 2024 17:06:51 +0200
Message-ID: <20241004150749.261020-5-sil-plv@napatech.com>
X-Mailer: git-send-email 2.45.0
In-Reply-To: <20241004150749.261020-1-sil-plv@napatech.com>
References: <20241004150749.261020-1-sil-plv@napatech.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AMS0EPF000001AC:EE_|AM9P190MB1089:EE_
Content-Type: text/plain
X-MS-Office365-Filtering-Correlation-Id: 259eee20-fbdb-4e67-9815-08dce48656a2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
ARA:13230040|376014|36860700013|1800799024|82310400026;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?O/t8YSmm3/h0fU6b+fLXvCEh2g4x2GYeX1lnmleNqvDoGVTY1Rmhlvmfxvri?=
=?us-ascii?Q?i0bEUPBfGhu1LbTK9PCyfxgEHDmiQpAMBHDZ5m/uXWPJXYH2a39tblE43qvn?=
=?us-ascii?Q?GDf6mtBEpqJRBZIi11iCgN02ITgs4g5zWiGyYNskY45WZoPpeNQXHFJeSSMm?=
=?us-ascii?Q?XVlVmZSIX/SVQ3SUrRsnFir4mqQUdEgOvlLU6txa3NlmEksBQlJ0IljFWIjr?=
=?us-ascii?Q?fPsGpLmkHfVZTN7mfhehoqWoCODaRJRGa+S2KTUbVez0hUj/1mRnAC0VFfwP?=
=?us-ascii?Q?6q4lboHE+wrG67gkQUoinJKU7s/kELjFmx1GLJg28g9mH+KjML5QU5AKcgLy?=
=?us-ascii?Q?LmhQm5LbRpXsOJ24u5Ofy9aaweZGMLW20sVNtCsXjt/cZWsKZQkPIGvyuJGv?=
=?us-ascii?Q?urXNCImZwG4J7C4A8q8L2vXeT13Xj1Uy1dA7yWacx6cAUAssa8MIlMFL0iO8?=
=?us-ascii?Q?x98F6xlbyqNbezDcESBSRFJuuv7/jMWShwHPB07nkP+Y8A53pa0aZoNNQUKH?=
=?us-ascii?Q?9IPYWx5Mj5rnpuwH3RS+G24hhrF0OnQDjOcbP5882/K/VBc+UcJdt6u/5VfS?=
=?us-ascii?Q?FzvvhRdABmR37S0qM8iKH6EJb5HGrBQ3LsysQLLBMKPru+4BQBT3mDqqrd3Q?=
=?us-ascii?Q?k4F94WWc8+AagR+iGka8skbcz6OrgC7T8Zj4vWjtbhSxYOcF9caywkRyBNpZ?=
=?us-ascii?Q?pUoAYNeSeEMfj9YAYZ1YMN2HA8V+r0qKnECwLLm1oB+KQpohVel0L2ONh7AH?=
=?us-ascii?Q?s58cNpLAM2YHG9sUFeqiWXd3++qRfHfWT9uP+xcOMiiCcdno+WdheRFPaB0J?=
=?us-ascii?Q?boCM48BorboUs8yFk0TDzxlb4ScP41ct4Lmu2gAz6zTskIosZzHW9ZLYNFgZ?=
=?us-ascii?Q?XO1Vi+b43DFX6EP3UAQFzbFn0WFz4gJAH8jCO1BIJjLyjbmo3erP0f+L+bDG?=
=?us-ascii?Q?kHQWCTuIFDEcJhsUKRx53auHodghlH3gMJfpQd9TJWw/2HI6+MXglFg+ApvP?=
=?us-ascii?Q?5cyqYfv0CkJfOA6HzG+GTKHMvbcMPVc1zWy6yTZ81E7ntc80DBeuNretF0gL?=
=?us-ascii?Q?baplEHztfS4NL22T75xJ8205qrBK7fAqjj5/DCxdZG4DrWQoSaRjrXlfTTO4?=
=?us-ascii?Q?/y8RTdP9CrkDbqSuyaUfa8nXpavGU9bBYDAkCqOYeGyf6uHKAiUl8iKoCb1t?=
=?us-ascii?Q?qbD8O3ccn8ozmw/KPaMNDjbDSmeWdHLqQ0c0tncQk1U5B3pyLEBaTrSfNMk4?=
=?us-ascii?Q?SDFIEUZNN5hzEHUDM/ZkJtkZPQ0D/01KnzqoDBQvQtQqjFIIouoM+IHoip8P?=
=?us-ascii?Q?H9VgxUqy860rjG1XQe09FQ4B+AQPYO9bZRxFTmV7yXm2oXStXLaSKPXmuY1A?=
=?us-ascii?Q?x1plwdE=3D?=
X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent;
CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uh/hELntKrTsKglcGSNsqAJYPKpPv/rnLOjkbG33Uc32vukAWrILhRQ0VhC092v84+zFQiRMphX33gv9x/JJtaKjnrq7sMVMsi1cb0T/EfeEmIMKxPXAY0CT02lGL1T8z11sE0Txf9zfSMhLCoR6qAC+2b6pHy1ASck7sPb3H92p5nZg27UpaHSjKHCxiB5gwpdVrVAHTBRS1nI4aj9G0BmY/UQAqi55qgI2rBc3+tkjUycdfrhn16ekI3mk1ArK0MkmoCs48F5TdN6yzcLC1+VuWuk1lAOMuOddv7YOdEV2Za4MZr/DOVkYuvXqiue98Pd/Fok5VrPuVf2/jbweFgW+4xq39AbV+oTxmHOfveUObk73PC3myKY1DMTMycAyH2s8NXmoJwRokfYzK8gBgOQ0tTUXzrmnlrI4cJdUmdC9PKexBtV/y/kVy8djDbbnmRNTXZAZyoZ0zTNp7XqI26sqCq6K55dZQVaH+86wUkOTeYIfCEADlebpWNIWUQ0TgCOy81dBOoN/B2sBjS3fofweNrATrWmBUL5sIXGfFjyDgBB0pd+PVCm+81wXILK/OmYdP+QbEWSJ2wkCnsL6KZPdHGhSIZMI8kMk7B4/2UyFWDxWl8GFGkix3OKl+X+EpDKPHxrXsMlrPuL+IhEokQ==
X-OriginatorOrg: napatech.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 15:08:00.8295 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 259eee20-fbdb-4e67-9815-08dce48656a2
X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4];
Helo=[localhost.localdomain]
X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001AC.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P190MB1089
X-BESS-ID: 1728054482-302249-12643-31655-2
X-BESS-VER: 2019.1_20240924.1654
X-BESS-Apparent-Source-IP: 104.47.11.49
X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVhaWJkBGBlAs1TzV0MLUONE8xc
Qy2SzVMDk1zSTVwMjAwtTcxMLMMFWpNhYAwxXAvUAAAAA=
X-BESS-Outbound-Spam-Score: 0.00
X-BESS-Outbound-Spam-Report: Code version 3.2,
rules version 3.2.2.259494 [from
cloudscan20-7.eu-central-1b.ess.aws.cudaops.com]
Rule breakdown below
pts rule name description
---- ---------------------- --------------------------------
0.00 BSF_BESS_OUTBOUND META: BESS Outbound
X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of
KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND
X-BESS-BRTS-Status: 1
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
From: Oleksandr Kolomeiets <okl-plv@napatech.com>
During rte_eth_dev_close execution,
eth_dev_close function exported by ntnic is called,
followed by a call to rte_eth_dev_release_port.
Since there is no possible returns between the calls,
calling rte_eth_dev_release_port from eth_dev_close
is redundant and error-prone.
Signed-off-by: Oleksandr Kolomeiets <okl-plv@napatech.com>
---
drivers/net/ntnic/ntnic_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c
index f351469d0a..52ca8f2844 100644
--- a/drivers/net/ntnic/ntnic_ethdev.c
+++ b/drivers/net/ntnic/ntnic_ethdev.c
@@ -383,7 +383,6 @@ eth_dev_close(struct rte_eth_dev *eth_dev)
internals->p_drv = NULL;
- rte_eth_dev_release_port(eth_dev);
if (p_drv) {
/* decrease initialized ethernet devices */
p_drv->n_eth_dev_init_count--;
--
2.45.0